From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 732406B004F for ; Thu, 27 Aug 2009 15:27:52 -0400 (EDT) Message-ID: <4A96DFFF.1040501@redhat.com> Date: Thu, 27 Aug 2009 22:35:27 +0300 From: Izik Eidus MIME-Version: 1.0 Subject: Re: [PATCH 13/12] ksm: fix munlock during exit_mmap deadlock References: <20090825145832.GP14722@random.random> <20090825152217.GQ14722@random.random> <20090825181019.GT14722@random.random> <20090825194530.GU14722@random.random> <20090826194444.GB14722@random.random> <4A95A10C.5040008@redhat.com> <20090826211400.GE14722@random.random> <4A95AE06.305@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Andrea Arcangeli , Rik van Riel , Chris Wright , Nick Piggin , Andrew Morton , "Justin M. Forbes" , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Hugh Dickins wrote: > > It may be that MADV_UNMERGEABLE isn't really needed (I think I even > admitted once that probably nobody would use it other than we testing > it). Yet I hesitate to rip it out: somehow it still seems right to > have it in there. Why did you have unregistering in the /dev/ksm KSM? > It was more to give possiblaty to applications save cpu cycles of ksmd so it wont continue to scan memory regions that don`t need ksm anymore, As you said if someone will ever use it?, have no idea... > > I didn't seem idiotic to me, but I hadn't realized the ksmd timelapse > uncertainty Andrea points out. Well, I'm not keen to change the way > it's working at present, but I do think you're right to question all > these aspects of unmerging. > Yes lets keep it like that, UNMERGEABLE sound anyway like something that going to break the pages..., we can always add later STOPMERGE as a call that tell ksm to stop merge the pages but not break the shared pages... > Hugh > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org