From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 6CE016B004D for ; Wed, 26 Aug 2009 10:36:46 -0400 (EDT) Message-ID: <4A954876.4070406@redhat.com> Date: Wed, 26 Aug 2009 10:36:38 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH mmotm] mm: introduce page_lru_base_type fix References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Andrew Morton , Johannes Weiner , Minchan Kim , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Hugh Dickins wrote: > My usual tmpfs swapping loads on recent mmotms have oddly > aroused the OOM killer after an hour or two. Bisection led to > mm-return-boolean-from-page_is_file_cache.patch, but really it's > the prior mm-introduce-page_lru_base_type.patch that's at fault. > > It converted page_lru() to use page_lru_base_type(), but forgot > to convert del_page_from_lru() - which then decremented the wrong > stats once page_is_file_cache() was changed to a boolean. > > Fix that, move page_lru_base_type() before del_page_from_lru(), > and mark it "inline" like the other mm_inline.h functions. > > Signed-off-by: Hugh Dickins Reviewed-by: Rik van Riel -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org