From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 532576B004D for ; Mon, 17 Aug 2009 23:06:42 -0400 (EDT) Message-ID: <4A8A1B2E.20505@redhat.com> Date: Tue, 18 Aug 2009 11:08:30 +0800 From: Amerigo Wang MIME-Version: 1.0 Subject: Re: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo' References: <20090817094525.6355.88682.sendpatchset@localhost.localdomain> <20090817094822.GA17838@elte.hu> <1250502847.5038.16.camel@penberg-laptop> <4A8986BB.80409@cs.helsinki.fi> <4A8A0B0D.6080400@redhat.com> <4A8A0B14.8040700@cn.fujitsu.com> In-Reply-To: <4A8A0B14.8040700@cn.fujitsu.com> Content-Type: multipart/mixed; boundary="------------000201070303040303050302" Sender: owner-linux-mm@kvack.org To: Li Zefan Cc: Christoph Lameter , Pekka Enberg , Ingo Molnar , linux-kernel@vger.kernel.org, Vegard Nossum , Eduard - Gabriel Munteanu , Thomas Gleixner , linux-mm@kvack.org, David Rientjes , Matt Mackall , Arjan van de Ven List-ID: This is a multi-part message in MIME format. --------------000201070303040303050302 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Li Zefan wrote: >> static int __init slab_proc_init(void) >> { >> - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations); >> + proc_create("slabinfo",S_IRUSR|S_IRUGO,NULL,&proc_slabinfo_operations); >> > > S_IRUSR|S_IRUGO == S_IRUGO > > Ah, yeah. Thanks! Update it. Signed-off-by: WANG Cong --------------000201070303040303050302 Content-Type: text/plain; name="proc-file-write-permission-fix2.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="proc-file-write-permission-fix2.diff" diff --git a/mm/slub.c b/mm/slub.c index b9f1491..61398c0 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4726,7 +4726,7 @@ static const struct file_operations proc_slabinfo_operations = { static int __init slab_proc_init(void) { - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations); + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations); return 0; } module_init(slab_proc_init); --------------000201070303040303050302-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org