linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mmotm: slqb correctly return value for notification handler
@ 2009-08-07  3:23 Shaohua Li
  2009-08-10  6:42 ` Pekka Enberg
  0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2009-08-07  3:23 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, penberg

Correctly return value for notification handler. The bug causes other
handlers are ignored and panic kernel.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
 mm/slqb.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: mmotm/mm/slqb.c
===================================================================
--- mmotm.orig/mm/slqb.c	2009-08-07 11:14:39.000000000 +0800
+++ mmotm/mm/slqb.c	2009-08-07 11:17:36.000000000 +0800
@@ -2846,7 +2846,10 @@ static int slab_memory_callback(struct n
 		break;
 	}
 
-	ret = notifier_from_errno(ret);
+	if (ret)
+		ret = notifier_from_errno(ret);
+	else
+		ret = NOTIFY_OK;
 	return ret;
 }
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmotm: slqb correctly return value for notification handler
  2009-08-07  3:23 [PATCH] mmotm: slqb correctly return value for notification handler Shaohua Li
@ 2009-08-10  6:42 ` Pekka Enberg
  0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2009-08-10  6:42 UTC (permalink / raw)
  To: Shaohua Li; +Cc: akpm, linux-mm, Nick Piggin

Shaohua Li wrote:
> Correctly return value for notification handler. The bug causes other
> handlers are ignored and panic kernel.
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

Applied to slab.git, thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-10  6:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-07  3:23 [PATCH] mmotm: slqb correctly return value for notification handler Shaohua Li
2009-08-10  6:42 ` Pekka Enberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox