From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 533F16B005A for ; Tue, 4 Aug 2009 08:31:39 -0400 (EDT) Message-ID: <4A78319D.9030002@redhat.com> Date: Tue, 04 Aug 2009 16:03:25 +0300 From: Izik Eidus MIME-Version: 1.0 Subject: Re: [PATCH 8/12] ksm: distribute remove_mm_from_lists References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Andrea Arcangeli , Rik van Riel , Chris Wright , Nick Piggin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Hugh Dickins wrote: > Do some housekeeping in ksm.c, to help make the next patch easier > to understand: remove the function remove_mm_from_lists, distributing > its code to its callsites scan_get_next_rmap_item and __ksm_exit. > > That turns out to be a win in scan_get_next_rmap_item: move its > remove_trailing_rmap_items and cursor advancement up, and it becomes > simpler than before. __ksm_exit becomes messier, but will change > again; and moving its remove_trailing_rmap_items up lets us strengthen > the unstable tree item's age condition in remove_rmap_item_from_tree. > > Signed-off-by: Hugh Dickins > --- > > Acked-by: Izik Eidus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org