From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id EACBA6B005A for ; Mon, 3 Aug 2009 10:16:13 -0400 (EDT) Message-ID: <4A76F57A.7090805@redhat.com> Date: Mon, 03 Aug 2009 17:34:34 +0300 From: Izik Eidus MIME-Version: 1.0 Subject: Re: [PATCH 2/12] ksm: move pages_sharing updates References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Andrea Arcangeli , Rik van Riel , Chris Wright , Nick Piggin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Hugh Dickins wrote: > The pages_shared count is incremented and decremented when adding a node > to and removing a node from the stable tree: easy to understand. But the > pages_sharing count was hard to follow, being adjusted in various places: > increment and decrement it when adding to and removing from the stable tree. > > And the pages_sharing variable used to include the pages_shared, then those > were subtracted when shown in the pages_sharing sysfs file: now keep it as > an exclusive count of leaves hanging off the stable tree nodes, throughout. > > Signed-off-by: Hugh Dickins > --- > > ACK, (Code is simpler that way) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org