From: "H. Peter Anvin" <hpa@zytor.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: "Li, Ming Chun" <macli@brc.ubc.ca>, linux-mm@kvack.org
Subject: Re: Replacing 0x% with %# ?
Date: Thu, 23 Jul 2009 11:01:06 -0700 [thread overview]
Message-ID: <4A68A562.9020109@zytor.com> (raw)
In-Reply-To: <2f11576a0907231041x1841b8d4y554470b04e9ecc81@mail.gmail.com>
KOSAKI Motohiro wrote:
>>>> Hi MM list:
>>>>
>>>> I am newbie and wish to contribute tiny bit. Before I submit a trivial
>>>> patch, I would ask if it is worth replacing '0x%' with '%#' in printk in
>>>> mm/*.c? If it is going to be noise for you guys, I would drop it and keep
>>>> silent :).
>>> Never mind. we already post many trivial cleanup patches.
>>>
>> The other thing is that we reallly should make %p include the 0x prefix, as
>> it does in userspace.
>
> I think you mean %x, not %p. if so, I agree you. this difference
> doesn't make any sense.
No, I mean %p. %x should definitely not issue the 0x prefix without a #
modifier.
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-07-23 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 22:53 Li, Ming Chun
2009-07-21 6:50 ` KOSAKI Motohiro
2009-07-22 23:24 ` H. Peter Anvin
2009-07-23 17:41 ` KOSAKI Motohiro
2009-07-23 18:01 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A68A562.9020109@zytor.com \
--to=hpa@zytor.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=macli@brc.ubc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox