From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 317DF6B004F for ; Mon, 13 Jul 2009 04:32:32 -0400 (EDT) Message-ID: <4A5AF637.3090405@panasas.com> Date: Mon, 13 Jul 2009 11:54:15 +0300 From: Boaz Harrosh MIME-Version: 1.0 Subject: Re: [rfc][patch 3/4] fs: new truncate sequence References: <20090707150758.GA18075@infradead.org> <20090707154809.GH2714@wotan.suse.de> <20090707163042.GA14947@infradead.org> <20090708063225.GL2714@wotan.suse.de> <20090708104701.GA31419@infradead.org> <20090708123412.GQ2714@wotan.suse.de> <4A54C435.1000503@panasas.com> <20090709075100.GU2714@wotan.suse.de> <4A59A517.1080605@panasas.com> <20090712144717.GA18163@infradead.org> <20090713065917.GO14666@wotan.suse.de> In-Reply-To: <20090713065917.GO14666@wotan.suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Nick Piggin Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Jan Kara , LKML , linux-mm@kvack.org List-ID: On 07/13/2009 09:59 AM, Nick Piggin wrote: > On Sun, Jul 12, 2009 at 10:47:18AM -0400, Christoph Hellwig wrote: >> On Sun, Jul 12, 2009 at 11:55:51AM +0300, Boaz Harrosh wrote: >>> I wish you would split it. >>> >>> one - helper to be called by converted file systems >>> (Which just ignores the ATTR_SIZE) >>> second - to be set into .setattr which does the simple_setsize + above. >>> >>> More clear for FS users like me (and that ugly unmask of ATTR_SIZE) >>> >>> or it's just me? >> Yeah, that seems be a lot cleaner. But let's wait until we got >> rid of ->truncate for all filesystems to have the bigger picture. > > Agreed, if it is a common sequence / requirement for filesystems > then of course I will not object to a helper to make things clearer > or share code. > > I would like to see inode_setattr renamed into simple_setattr, and > then also .setattr made mandatory, so I don't like to cut code out > of inode_setattr which makes it unable to be the simple_setattr > after the old truncate code is removed. > I thought you meant inode_setattr will go away. There will only be simple_setattr() and inode_setattr_nosize() For the time been simple_setattr() will also take care of old ->truncate FSs. And in the absence of .setattr simple_setattr() is called. Have I miss-understood? again please tell me when all this is in effect I want to do the conversion in exofs. [BTW these changes are a life saver for me in regard to the kind of things I need to do for pNFS-exports] Thanks Boaz -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org