From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id CF7216B0055 for ; Tue, 23 Jun 2009 17:37:35 -0400 (EDT) Message-ID: <4A414B3E.9020000@redhat.com> Date: Tue, 23 Jun 2009 17:38:06 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] mm: don't rely on flags coincidence References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Linus Torvalds , Nick Piggin , Andrew Morton , Mel Gorman , Wu Fengguang , Ingo Molnar , linux-mm@kvack.org List-ID: Hugh Dickins wrote: > Indeed FOLL_WRITE matches FAULT_FLAG_WRITE, matches GUP_FLAGS_WRITE, > and it's tempting to devise a set of Grand Unified Paging flags; > but not today. So until then, let's rely upon the compiler to spot > the coincidence, "rather than have that subtle dependency and a > comment for it" - as you remarked in another context yesterday. > > Signed-off-by: Hugh Dickins Good catch. Reviewed-by: Rik van Riel -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org