From: Rik van Riel <riel@redhat.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: don't rely on flags coincidence
Date: Tue, 23 Jun 2009 17:38:06 -0400 [thread overview]
Message-ID: <4A414B3E.9020000@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0906231349250.19552@sister.anvils>
Hugh Dickins wrote:
> Indeed FOLL_WRITE matches FAULT_FLAG_WRITE, matches GUP_FLAGS_WRITE,
> and it's tempting to devise a set of Grand Unified Paging flags;
> but not today. So until then, let's rely upon the compiler to spot
> the coincidence, "rather than have that subtle dependency and a
> comment for it" - as you remarked in another context yesterday.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Good catch.
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-23 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 20:42 handle_mm_fault() calling convention cleanup Linus Torvalds
2009-06-22 2:20 ` David Miller
2009-06-22 8:10 ` Ingo Molnar
2009-06-22 9:26 ` Martin Schwidefsky
2009-06-22 14:22 ` David Howells
2009-06-22 14:58 ` James Bottomley
2009-06-22 15:49 ` Russell King
2009-06-23 7:18 ` Nick Piggin
2009-06-23 12:49 ` [PATCH] hugetlb: fault flags instead of write_access Hugh Dickins
2009-06-23 12:56 ` Wu Fengguang
2009-06-23 21:36 ` Rik van Riel
2009-06-29 12:29 ` Mel Gorman
2009-06-23 12:52 ` [PATCH] mm: don't rely on flags coincidence Hugh Dickins
2009-06-23 13:00 ` Wu Fengguang
2009-06-23 21:38 ` Rik van Riel [this message]
2009-07-03 23:35 ` handle_mm_fault() calling convention cleanup Benjamin Herrenschmidt
2009-07-04 16:44 ` Linus Torvalds
2009-07-04 21:08 ` Benjamin Herrenschmidt
2009-07-06 7:31 ` Nick Piggin
2009-07-06 10:56 ` Benjamin Herrenschmidt
2009-07-06 11:53 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A414B3E.9020000@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox