Re: boot panic with memcg enabled (Was [PATCH 3/4] memcg: don't use bootmem allocator in setup code)

[Li Zefan <lizf@cn.fujitsu.com>]

KAMEZAWA Hiroyuki wrote:
> On Fri, 12 Jun 2009 11:55:01 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> 
>> On Fri, 12 Jun 2009 10:50:00 +0800
>> Li Zefan <lizf@cn.fujitsu.com> wrote:
>>
>>> (This patch should have CCed memcg maitainers)
>>>
>>> My box failed to boot due to initialization failure of page_cgroup, and
>>> it's caused by this patch:
>>>
>>> +	page = alloc_pages_node(nid, GFP_NOWAIT | __GFP_ZERO, order);
>>>
>> Oh, I don't know this patch ;(
>>
>>> I added a printk, and found that order == 11 == MAX_ORDER.
>>>
>> maybe possible because this allocates countinous pages of 60%? length of
>> memmap. 
>> If __alloc_bootmem_node_nopanic() is not available any more, memcg should be
>> only used under CONFIG_SPARSEMEM. 
>>
>> Is that a request from bootmem maintainer ?
>>
> In other words,
>  - Is there any replacment function to allocate continuous pages bigger
>    than MAX_ORDER ?
>  - If not, memcg (and io-controller under development) shouldn't support
>    memory model other than SPARSEMEM.
> 
> IIUC, page_cgroup_init() is called before mem_init() and we could use
> alloc_bootmem() here.
> 
> Could someone teach me which thread should I read to know
> "why alloc_bootmem() is gone ?" ?
> 

alloc_bootmem() is not gone, but slab allocator is setup much earlier now.
See this commit:

commit 83b519e8b9572c319c8e0c615ee5dd7272856090
Author: Pekka Enberg <penberg@cs.helsinki.fi>
Date:   Wed Jun 10 19:40:04 2009 +0300

    slab: setup allocators earlier in the boot sequence

now page_cgroup_init() is called after mem_init().

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>