linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	yanmin.zhang@intel.com, Wu Fengguang <fengguang.wu@intel.com>,
	linuxram@us.ibm.com, linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] Reintroduce zone_reclaim_interval for when	zone_reclaim() scans and fails to avoid CPU spinning at 100% on NUMA
Date: Mon, 08 Jun 2009 10:48:16 -0400	[thread overview]
Message-ID: <4A2D24B0.4080301@redhat.com> (raw)
In-Reply-To: <20090608135433.GD15070@csn.ul.ie>

Mel Gorman wrote:
> On Mon, Jun 08, 2009 at 09:31:09AM -0400, Rik van Riel wrote:
>> Mel Gorman wrote:
>>
>>> The scanning occurs because zone_reclaim() cannot tell
>>> in advance the scan is pointless because the counters do not distinguish
>>> between pagecache pages backed by disk and by RAM. 
>> Yes it can.  Since 2.6.27, filesystem backed and swap/ram backed
>> pages have been living on separate LRU lists. 
> 
> Yes, they're on separate LRU lists but they are not the only pages on those
> lists. The tmpfs pages are mixed in together with anonymous pages so we
> cannot use NR_*_ANON.
> 
> Look at patch 2 and where I introduced;

I have to admit I did not read patches 2 and 3 before
replying to the (strange looking, at the time) text
above patch 1.

With that logic from patch 2 in place, patch 1 makes
perfect sense.

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-06-08 13:29 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 13:01 [PATCH 0/3] [RFC] Functional fix to zone_reclaim() and bring behaviour more in line with expectations Mel Gorman
2009-06-08 13:01 ` [PATCH 1/3] Reintroduce zone_reclaim_interval for when zone_reclaim() scans and fails to avoid CPU spinning at 100% on NUMA Mel Gorman
2009-06-08 13:31   ` Rik van Riel
2009-06-08 13:54     ` Mel Gorman
2009-06-08 14:33       ` Christoph Lameter
2009-06-08 14:38         ` Mel Gorman
2009-06-08 14:55           ` Christoph Lameter
2009-06-08 15:11             ` Mel Gorman
2009-06-10  5:23               ` Andrew Morton
2009-06-10  6:44                 ` KOSAKI Motohiro
2009-06-10 10:00                 ` Mel Gorman
2009-06-08 14:48       ` Rik van Riel [this message]
2009-06-09  8:08         ` Mel Gorman
2009-06-09  1:58   ` Wu Fengguang
2009-06-09  8:14     ` Mel Gorman
2009-06-09  8:25       ` Wu Fengguang
2009-06-09  8:31         ` Mel Gorman
2009-06-09  9:07           ` Wu Fengguang
2009-06-09  9:40             ` Mel Gorman
2009-06-09 13:38               ` Wu Fengguang
2009-06-09 15:06                 ` Mel Gorman
2009-06-10  2:14                   ` Wu Fengguang
2009-06-10  9:54                     ` Mel Gorman
2009-06-09  7:48   ` KOSAKI Motohiro
2009-06-09  8:18     ` Mel Gorman
2009-06-09  8:45       ` KOSAKI Motohiro
2009-06-09  9:42         ` Mel Gorman
2009-06-09  9:45           ` KOSAKI Motohiro
2009-06-09  9:59             ` KOSAKI Motohiro
2009-06-09 10:44               ` Mel Gorman
2009-06-09 10:50                 ` KOSAKI Motohiro
2009-06-08 13:01 ` [PATCH 2/3] Properly account for the number of page cache pages zone_reclaim() can reclaim Mel Gorman
2009-06-08 14:25   ` Christoph Lameter
2009-06-08 14:36     ` Mel Gorman
2009-06-09  2:25   ` Wu Fengguang
2009-06-09  8:27     ` Mel Gorman
2009-06-09  8:45       ` Wu Fengguang
2009-06-09 10:48         ` Mel Gorman
2009-06-09 12:08           ` Wu Fengguang
2009-06-09  8:55       ` KOSAKI Motohiro
2009-06-09  2:37   ` Wu Fengguang
2009-06-09  8:19   ` KOSAKI Motohiro
2009-06-09  8:47     ` Mel Gorman
2009-06-08 13:01 ` [PATCH 3/3] Do not unconditionally treat zones that fail zone_reclaim() as full Mel Gorman
2009-06-08 14:32   ` Christoph Lameter
2009-06-08 14:43     ` Mel Gorman
2009-06-09  3:11   ` Wu Fengguang
2009-06-09  8:50     ` Mel Gorman
2009-06-09  7:48   ` KOSAKI Motohiro
2009-06-09  9:25     ` Mel Gorman
2009-06-09 12:05       ` KOSAKI Motohiro
2009-06-09 13:28         ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2D24B0.4080301@redhat.com \
    --to=riel@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxram@us.ibm.com \
    --cc=mel@csn.ul.ie \
    --cc=yanmin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox