From: Rik van Riel <riel@redhat.com>
To: "Larry H." <research@subreption.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
pageexec@freemail.hu, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Use kzfree in mac80211 key handling to enforce data sanitization
Date: Sat, 30 May 2009 22:14:46 -0400 [thread overview]
Message-ID: <4A21E816.4050203@redhat.com> (raw)
In-Reply-To: <20090531015801.GB8941@oblivion.subreption.com>
Larry H. wrote:
> [PATCH] Use kzfree in mac80211 key handling to enforce data sanitization
>
> This patch replaces the kfree() calls within the mac80211 WEP RC4 key
> handling and ieee80211 management APIs with kzfree(), to enforce
> sanitization of the key buffer contents.
>
> This prevents the keys from persisting on memory, potentially
> leaking to other kernel users after re-allocation of the memory by
> the LIFO allocators, or in coldboot attack scenarios. Information can be
> leaked as well due to use of uninitialized variables, or other bugs.
>
> This patch doesn't affect fastpaths.
This seems to be essentially what Ingo proposed.
Clearing out a buffer that held a wifi key on free
makes sense, even for systems that are not in
paranoid mode.
> Signed-off-by: Larry Highsmith <research@subreption.com>
Acked-by: Rik van Riiel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-05-31 2:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 1:58 Larry H.
2009-05-31 2:14 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A21E816.4050203@redhat.com \
--to=riel@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pageexec@freemail.hu \
--cc=research@subreption.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox