Re: [PATCH 3/7] percpu: clean up percpu variable definitions

[Tejun Heo <tj@kernel.org>]

Rusty Russell wrote:
> On Wed, 20 May 2009 05:07:35 pm Tejun Heo wrote:
>> Percpu variable definition is about to be updated such that
>>
>> * percpu symbols must be unique even the static ones
>>
>> * in-function static definition is not allowed
> 
> That spluttering noise is be choking on the title of this patch :)
> 
> Making these pseudo statics is in no way a cleanup.  How about we just
> say "they can't be static" and do something like:
> 
> /* Sorry, can't be static: that breaks archs which need these weak. */
> #define DEFINE_PER_CPU(type, var) \
> 	extern typeof(type) var; DEFINE_PER_CPU_SECTION(type, name, "")

Heh... well, even though I authored the patch, I kind of agree with
you.  Maybe it would be better to simply disallow static declaration /
definition at all.  I wanted to give a go at the original idea as it
seemed to have some potential.  The result isn't too disappointing but
I can't really say there are distinctively compelling advantages to
justify the added complexity and subtlety.

What do others think?  Is everyone happy with going extern only?

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>