linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] memcg: remove forward declaration from sched.h
@ 2009-05-22  6:27 Li Zefan
  2009-05-22  8:17 ` KAMEZAWA Hiroyuki
  0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2009-05-22  6:27 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Balbir Singh, KAMEZAWA Hiroyuki, LKML, linux-mm

This forward declaration seems pointless.

compile tested.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 sched.h |    1 -
 1 file changed, 1 deletion(-)

--- a/include/linux/sched.h	2009-05-22 13:43:01.000000000 +0800
+++ b/include/linux/sched.h	2009-05-22 13:38:59.000000000 +0800
@@ -93,7 +93,6 @@ struct sched_param {
 
 #include <asm/processor.h>
 
-struct mem_cgroup;
 struct exec_domain;
 struct futex_pi_state;
 struct robust_list_head;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] memcg: remove forward declaration from sched.h
  2009-05-22  6:27 [PATCH] memcg: remove forward declaration from sched.h Li Zefan
@ 2009-05-22  8:17 ` KAMEZAWA Hiroyuki
  2009-05-22  8:37   ` Li Zefan
  0 siblings, 1 reply; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2009-05-22  8:17 UTC (permalink / raw)
  To: Li Zefan; +Cc: Andrew Morton, Balbir Singh, LKML, linux-mm

On Fri, 22 May 2009 14:27:32 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> This forward declaration seems pointless.
> 
> compile tested.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Nice catch. (but I don't know why this sneaked into..)
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>


> ---
>  sched.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/include/linux/sched.h	2009-05-22 13:43:01.000000000 +0800
> +++ b/include/linux/sched.h	2009-05-22 13:38:59.000000000 +0800
> @@ -93,7 +93,6 @@ struct sched_param {
>  
>  #include <asm/processor.h>
>  
> -struct mem_cgroup;
>  struct exec_domain;
>  struct futex_pi_state;
>  struct robust_list_head;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] memcg: remove forward declaration from sched.h
  2009-05-22  8:17 ` KAMEZAWA Hiroyuki
@ 2009-05-22  8:37   ` Li Zefan
  0 siblings, 0 replies; 3+ messages in thread
From: Li Zefan @ 2009-05-22  8:37 UTC (permalink / raw)
  To: KAMEZAWA Hiroyuki; +Cc: Andrew Morton, Balbir Singh, LKML, linux-mm

KAMEZAWA Hiroyuki wrote:
> On Fri, 22 May 2009 14:27:32 +0800
> Li Zefan <lizf@cn.fujitsu.com> wrote:
> 
>> This forward declaration seems pointless.
>>
>> compile tested.
>>
>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> Nice catch. (but I don't know why this sneaked into..)

It was long long ago when memcg was merged ;)

| commit 78fb74669e80883323391090e4d26d17fe29488f
| Author: Pavel Emelianov <xemul@openvz.org>
| Date:   Thu Feb 7 00:13:51 2008 -0800
|
|    Memory controller: accounting setup

But in that patch, the forward declation in sched.h was unneeded.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-05-22  8:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-22  6:27 [PATCH] memcg: remove forward declaration from sched.h Li Zefan
2009-05-22  8:17 ` KAMEZAWA Hiroyuki
2009-05-22  8:37   ` Li Zefan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox