From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AAF6C61DA4 for ; Thu, 9 Mar 2023 06:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80B9E6B0071; Thu, 9 Mar 2023 01:03:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BB9E6B0072; Thu, 9 Mar 2023 01:03:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AA55280001; Thu, 9 Mar 2023 01:03:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C1BE6B0071 for ; Thu, 9 Mar 2023 01:03:54 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 367961606EE for ; Thu, 9 Mar 2023 06:03:54 +0000 (UTC) X-FDA: 80548318788.30.A4CA432 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf29.hostedemail.com (Postfix) with ESMTP id 474A7120015 for ; Thu, 9 Mar 2023 06:03:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678341830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kt0vB7nTGOPw7D4hktlUjQ7Y9Ns7YAuzTCXelcyp6k4=; b=7aQCCYxZ6nDfwGXfxB+/Vj4A8fQvj+9eKGOR5GtslT50GG1GYEUPrvntUMd+R6ci920WSE 6KPn2pcQlc9cTufNKAjgGMSTgI+IaP7ft3yRlM1/8/D7+kcHBloCJIvZfM4B4frZ3qYnsQ D+ZcRyoSzGjk3CGM47ltzi9LFs6yshw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678341830; a=rsa-sha256; cv=none; b=XAj0NDGieQIrxRYAJDU+5IpLfbplR8In52CGNpUo2baQ2JmHa0Jk10OUiMm1TyM8FSasom MbsRtdeKS+3Obs0utFZfra/W0UegxAnxiV/E7QXYMN//YDO/7TcqIwvwipFL9EPFOMxN9X OUz92JaP3ecFXX3nW/ZR6YLYdn+8bUo= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PXJSf2GNZzSkRQ; Thu, 9 Mar 2023 14:00:34 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 14:03:39 +0800 Message-ID: <49f2c8df-0578-b99e-8687-d77047bd5a33@huawei.com> Date: Thu, 9 Mar 2023 14:03:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: memory-failure: Move memory failure sysctls to its own file Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Luis Chamberlain , Andrew Morton , Miaohe Lin , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Kees Cook , Iurii Zaikin References: <20230309045924.52395-1-wangkefeng.wang@huawei.com> <20230309051439.GA4018963@hori.linux.bs1.fc.nec.co.jp> From: Kefeng Wang In-Reply-To: <20230309051439.GA4018963@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 474A7120015 X-Stat-Signature: yhtoyjz575i8jru3zt3b8tcjjxjnipdg X-Rspam-User: X-HE-Tag: 1678341829-810141 X-HE-Meta: U2FsdGVkX1/cyxChcLj6y3b2CafslXieGeDGIHx9z8/vTx2E56J3iUs7uU9IXR0tNpazy9wlwiB4WjIZ5MAfWznG/j22tra40Of/NVLsXMzFxhQ4zLLYfYfRIQDIwZ+CiS80RyYtMtIWlvCnk+dTPcucBmXKNda6PMKIe7hvfFycWNxs0F5ZgztXHcPaB9smR+n0Xjh5zNadv4KiLSV07bXP3szzEWvQayEj1AkLjSYE0v2xLGcyps/YOCdypXbscOSux4ezj1gnoBqcfj6EVdv8GYJ4IbhMlJATmjnh4TAISLVab4b45Wm2ap9NYKZZp5U1rBa8eFGs+UWDzZBvzWZi8j6jWgQerga30Cph4o3I1Q+un1gUuGHUvEJ4FoPDpCLPVJKArt1YqXeN78aI39iJRnG6ajjZ5uGtAVLX0MVdCxUiI0x6JmpUWZdbnqJmnWKYqbWTDW5uIypGf3iD1lu7DItPq4r3pIVH8rKlkNzwmKq1gmfoqDFGnpl2oWzpcWXoQeEEub3oI19x/JlqbERI/iQz2VIkxj/YJzCgfBUwKzWAoGOjbY4b7fxfXtVATN7eVHhZJvKRYqAiRn/Dm/+qju9Eazy/TizBrI9OYzQ/Y8IbsAc5y6l0iUhRBvctuikkz6kSMnJpCX3O4qO9p/RP5Y9FIKL3I1oubuB+sBJyWGsNaQJFlkPZWBqzfBqBpWibECDuQ2g/6RH0TF7tKsQ9p7yaHS3dtn4XkKG4IUweZybr4wKG7HcAguBjg6AITj3p2IXKEzGot54ShIjpXCcgS3vD+QJYdLn3wdA3+pF6nQrMgk/lHuMDlUeU7TvSr7hcW1idrg2lORKpSbxFoyRT6rZ6r9J1eg8GSuUfulV9MvPd5eys2IeXXNz77/9tBvOLGDDvDtgvHQS9uKbhzCuNChLufd5DEZwH8s5on5aR9XZbTQdilW53XznL4U0QtkcavERRMYK6tmFHRN/ m3ZSU0IQ pqlfsCyxAu6W1znt8xsgEIho/779UZzJnRtcG0mUnUSw5oybh8Lv3C6YynivYlMO8obxNlnDxqApYysCu/WeTMeEfBb1Mx5LHpH77wKD4PIUPIUsNaCXHZNG2hb4EWv3iFx815j5nlFxTblJAL5SNsC0C0ECC7IyCfOiqD8nIeAAqpM36DI+WAvB+P7sq4BNkp2MjGD+T/0mmQXgwlgE4QMwRTvFmUCABwvBIHgm/vWwY8AFXbAwuZtsdqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/9 13:14, HORIGUCHI NAOYA(堀口 直也) wrote: > On Thu, Mar 09, 2023 at 12:59:24PM +0800, Kefeng Wang wrote: >> The sysctl_memory_failure_early_kill and memory_failure_recovery >> are only used in memory-failure.c, move them to its own file. > > Thank you for the patch. > > Could you explain the benefit to move them? > We seem to have many other parameters in kernel/sysctl.c which are used > only in single places, so why do we handle these two differently? > Actually, all of them need to be moved into theirs own file as required by proc sysctl maintainer, see [1] > Thanks, > Naoya Horiguchi [1] https://lore.kernel.org/all/20211123202347.818157-1-mcgrof@kernel.org/