From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>
Subject: Re: [PATCH] mm: memory-failure: Move memory failure sysctls to its own file
Date: Thu, 9 Mar 2023 14:03:39 +0800 [thread overview]
Message-ID: <49f2c8df-0578-b99e-8687-d77047bd5a33@huawei.com> (raw)
In-Reply-To: <20230309051439.GA4018963@hori.linux.bs1.fc.nec.co.jp>
On 2023/3/9 13:14, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Thu, Mar 09, 2023 at 12:59:24PM +0800, Kefeng Wang wrote:
>> The sysctl_memory_failure_early_kill and memory_failure_recovery
>> are only used in memory-failure.c, move them to its own file.
>
> Thank you for the patch.
>
> Could you explain the benefit to move them?
> We seem to have many other parameters in kernel/sysctl.c which are used
> only in single places, so why do we handle these two differently?
>
Actually, all of them need to be moved into theirs own file as required
by proc sysctl maintainer, see [1]
> Thanks,
> Naoya Horiguchi
[1] https://lore.kernel.org/all/20211123202347.818157-1-mcgrof@kernel.org/
next prev parent reply other threads:[~2023-03-09 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 4:59 Kefeng Wang
2023-03-09 5:14 ` HORIGUCHI NAOYA(堀口 直也)
2023-03-09 6:03 ` Kefeng Wang [this message]
2023-03-10 0:20 ` HORIGUCHI NAOYA(堀口 直也)
2023-03-10 3:57 ` [PATCH v2] " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f2c8df-0578-b99e-8687-d77047bd5a33@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox