From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D2CCFA74C for ; Fri, 4 Oct 2024 09:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A01C86B03F3; Fri, 4 Oct 2024 05:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D166B0303; Fri, 4 Oct 2024 05:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F26C6B0304; Fri, 4 Oct 2024 05:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4F1276B02B0 for ; Fri, 4 Oct 2024 05:18:18 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8E281A12D9 for ; Fri, 4 Oct 2024 09:18:17 +0000 (UTC) X-FDA: 82635368634.23.EC25BB9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 7F206C0016 for ; Fri, 4 Oct 2024 09:18:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj3a0tJL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QfQE8COh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj3a0tJL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QfQE8COh; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728033399; a=rsa-sha256; cv=none; b=CeHal70hAfjZcC2H4REgsjqulf3NTWK1BC8hJMEZOfFVMcAFIb/MxaasI0gwr3kgf8LEhn wWRZOVcYAl4qY17j51zMLBZ11cAVOi6Q4U/fLPnaL9q4Tqv31H3O1mUNAi0h4+QnZpZ4et OKEYUzN3ngy5bGET4Cx9zLLAac3/ecI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj3a0tJL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QfQE8COh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uj3a0tJL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QfQE8COh; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728033399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hJvWtxFfWRqgDS5wtzltJ9aaFP0PBIh4+i3oe2Vw3LE=; b=lfxO86s4JDa9QSQtDTrSO2KkFIGuJuCAOkJYM6Ef8B/FBW6PilaqBXkk8n6D7O0V9g/Bju sm8swSUxPiXqBRQum3AFSM3h15YsSlA0l0tX/0bAH0H2IjfnLxwkcZ4cH8wuZuaZ496C9b cNuEsrwBlgrap7JrHyHe3FgxhOmdxjE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF47D21E2C; Fri, 4 Oct 2024 09:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728033493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hJvWtxFfWRqgDS5wtzltJ9aaFP0PBIh4+i3oe2Vw3LE=; b=Uj3a0tJLi6vJzbP43NaX8EQChX1CPkjOjqQ0cGbAsOUcjFqUMl8GpsKYUEkeTmN1+RZh7J k7sa6TiYIWDFhNgVZD+qdEbWD07n8B4eRUy2WRcsqpmQAgfvCErCgScq9MmNAHUEiYSvu/ gZvjXSJkAN9mhCVplFM4rT1m1JSchD0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728033493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hJvWtxFfWRqgDS5wtzltJ9aaFP0PBIh4+i3oe2Vw3LE=; b=QfQE8COh2bEZTLQnOpylbVMrsW0InMP+mAHxnM0ZPaw0zrBEImDfE9ux3+Js+UfxPSRuJC MR4tDAfZeFxBu7Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728033493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hJvWtxFfWRqgDS5wtzltJ9aaFP0PBIh4+i3oe2Vw3LE=; b=Uj3a0tJLi6vJzbP43NaX8EQChX1CPkjOjqQ0cGbAsOUcjFqUMl8GpsKYUEkeTmN1+RZh7J k7sa6TiYIWDFhNgVZD+qdEbWD07n8B4eRUy2WRcsqpmQAgfvCErCgScq9MmNAHUEiYSvu/ gZvjXSJkAN9mhCVplFM4rT1m1JSchD0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728033493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hJvWtxFfWRqgDS5wtzltJ9aaFP0PBIh4+i3oe2Vw3LE=; b=QfQE8COh2bEZTLQnOpylbVMrsW0InMP+mAHxnM0ZPaw0zrBEImDfE9ux3+Js+UfxPSRuJC MR4tDAfZeFxBu7Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8309813A55; Fri, 4 Oct 2024 09:18:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sMKfH9Wy/2YrCAAAD6G6ig (envelope-from ); Fri, 04 Oct 2024 09:18:13 +0000 Message-ID: <49ef066d-d001-411e-8db7-f064bdc2104c@suse.cz> Date: Fri, 4 Oct 2024 11:18:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] mm/slub: Improve data handling of krealloc() when orig_size is enabled To: Marco Elver Cc: Feng Tang , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Shuah Khan , David Gow , Danilo Krummrich , Alexander Potapenko , Andrey Ryabinin , Dmitry Vyukov , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Eric Dumazet References: <20240911064535.557650-1-feng.tang@intel.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 7F206C0016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 34w6qa7ryruta4dsf75fgzps3c1co1c6 X-HE-Tag: 1728033495-445609 X-HE-Meta: U2FsdGVkX1+oeBEaXfe73dIFj9AtfzeXMySb7llVbvqz1zISOBEA2H/wAyqAA5niocj4fQeJ8X0vsEH3wC9BoUcb3LuU0c5O3oufBQplRW+hPHBQOVeKIbymxrK5ZM09gJKjdPhKxLX0VND0swVV5jgA3DN3m5JJY4YGFDZo9jU6JX4D4eCoIM3Gl6C9C5/Yf82DU4+4o2b/MB1oZs0pYnYuw72UlwObzmJ4ysV4NU3AGN0iRxbctCaoKXQObDQOWg5I5QuCVF63jkpNOyW8JE/wReCMlByHnBBrzFDnEaDIp3Kej0m8+F+yGyGJtAW6gp8ZgLmgE3KyZs1A+/VoSOLVkQRi83honbwWXbSMeywzJXej2lTs/HGC0NUP/3JuPdu0J1+X/gSEpQt+ZEsrJmEP6GkitZNu0ZgfgXgfLQ8cb841YjvOmo2b9ZQZKXsFPexfGaj0Qs/u9llNS6eIJmkQz1QqjU0Rl9XkJcPUJpHc64BkZ5SPj1t61myDB1p/IyN5+5mMJPk9nXyfYecJ7kmwBj4+pTh0uga+QWkSmeVjpRzYqFLSFZuCBt2OaFX+vyngE96nPNUvzeR+dcxCU4XtLTQGcwPquYl4HyQangNksynDBLJaOadJJe//S7JTta/o8AkcMI/rNTcfMsdzPLKnkWg5f7CdcyuqTnpDBpuTSouEQjT/nWrSaq9NUbTdVLCU50Lw69Zg1UweaaWGradRHqLDFC3mQtYkGqU8M5TayOyNLCDDtQ35cO9uJ1ZYYytAFGe9y5Sgo9zF6r65c1s3TPtLdlfOyvdKy4QjgO1UejPS8tU/nELKK9K7NFgNLVpiC5Wma5hCVmcjn0EUv7UdHrwc1vEbbyMH1aXSQcT6l3ee2UrLyLpiWB4K0x9ET8LbGGiI9SsBd/a/vxYw/oC073n4ZZrSGlAG8dCCT4QvO5bbBOBwcVzJCpmxJ34aDA6WMbRQFZhVS8kc1Ea LedUsVUZ lD7CIPOL/14fxlRchK1W9Fwll5Twkn1DIzm8M5Jgw3izykaIb5Q+Hj3srrw3ZUSLE6fI2nIgj8B+ehWMUEdTPQH1HduhcjdL507BsyYmn1YJ2zslgWAtNR3VEJxuf0LOJ+PQFd/Jre/vA9FoQLMViZJAIJxm8bh/aYLxTq77ro6NCQ1JxQHZwBBS8oXKqMezpWyvkAkw0+DRxIaul4aELpQuhkHyujt9xX02+hu1T0p8I4RRmt9G6noC2M411Me8KTYtZ3b/BE1ijTMvChtpyIllwGnYKM8QAVfaR6Vf8P1i89FZ+TR2MvSih+cXLtHNR2OqniVMGnI7CrNJMTggA173vE3/2uOeIC0bFEdqwQY5Vt8YjMeqkckCVNi70B0HM2MrsJoEmMeY6hboxnUbJDnWVlgAfdcls6TL4qb4zTngmQunvo1vumhXGCBfBi0FjhhosNLOIbNVcLaU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/4/24 08:44, Marco Elver wrote: > On Wed, 2 Oct 2024 at 12:42, Vlastimil Babka wrote: >> >> On 9/11/24 08:45, Feng Tang wrote: >> > Danilo Krummrich's patch [1] raised one problem about krealloc() that >> > its caller doesn't pass the old request size, say the object is 64 >> > bytes kmalloc one, but caller originally only requested 48 bytes. Then >> > when krealloc() shrinks or grows in the same object, or allocate a new >> > bigger object, it lacks this 'original size' information to do accurate >> > data preserving or zeroing (when __GFP_ZERO is set). >> > >> > Thus with slub debug redzone and object tracking enabled, parts of the >> > object after krealloc() might contain redzone data instead of zeroes, >> > which is violating the __GFP_ZERO guarantees. Good thing is in this >> > case, kmalloc caches do have this 'orig_size' feature, which could be >> > used to improve the situation here. >> > >> > To make the 'orig_size' accurate, we adjust some kasan/slub meta data >> > handling. Also add a slub kunit test case for krealloc(). >> > >> > This patchset has dependency over patches in both -mm tree and -slab >> > trees, so it is written based on linux-next tree '20240910' version. >> > >> > [1]. https://lore.kernel.org/lkml/20240812223707.32049-1-dakr@kernel.org/ >> >> Thanks, added to slab/for-next > > This series just hit -next, and we're seeing several "KFENCE: memory > corruption ...". Here's one: > https://lore.kernel.org/all/66ff8bf6.050a0220.49194.0453.GAE@google.com/ > > One more (no link): > >> ================================================================== >> BUG: KFENCE: memory corruption in xfs_iext_destroy_node+0xab/0x670 fs/xfs/libxfs/xfs_iext_tree.c:1051 >> >> Corrupted memory at 0xffff88823bf5a0d0 [ 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 ] (in kfence-#172): >> xfs_iext_destroy_node+0xab/0x670 fs/xfs/libxfs/xfs_iext_tree.c:1051 >> xfs_iext_destroy+0x66/0x100 fs/xfs/libxfs/xfs_iext_tree.c:1062 >> xfs_inode_free_callback+0x91/0x1d0 fs/xfs/xfs_icache.c:145 >> rcu_do_batch kernel/rcu/tree.c:2567 [inline] > [...] >> >> kfence-#172: 0xffff88823bf5a000-0xffff88823bf5a0cf, size=208, cache=kmalloc-256 >> >> allocated by task 5494 on cpu 0 at 101.266046s (0.409225s ago): >> __do_krealloc mm/slub.c:4784 [inline] >> krealloc_noprof+0xd6/0x2e0 mm/slub.c:4838 >> xfs_iext_realloc_root fs/xfs/libxfs/xfs_iext_tree.c:613 [inline] > [...] >> >> freed by task 16 on cpu 0 at 101.573936s (0.186416s ago): >> xfs_iext_destroy_node+0xab/0x670 fs/xfs/libxfs/xfs_iext_tree.c:1051 >> xfs_iext_destroy+0x66/0x100 fs/xfs/libxfs/xfs_iext_tree.c:1062 >> xfs_inode_free_callback+0x91/0x1d0 fs/xfs/xfs_icache.c:145 > [...] >> >> CPU: 0 UID: 0 PID: 16 Comm: ksoftirqd/0 Not tainted 6.12.0-rc1-next-20241003-syzkaller #0 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 >> ================================================================== > > Unfortunately there's no reproducer yet it seems. Unless it's > immediately obvious to say what's wrong, is it possible to take this > series out of -next to confirm this series is causing the memory > corruptions? Syzbot should then stop finding these crashes. I think it's commit d0a38fad51cc7 doing in __do_krealloc() - ks = ksize(p); + + s = virt_to_cache(p); + orig_size = get_orig_size(s, (void *)p); + ks = s->object_size; so for kfence objects we don't get their actual allocation size but the potentially larger bucket size? I guess we could do: ks = kfence_ksize(p) ?: s->object_size; ? > Thanks, > -- Marco