From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4D8C369D3 for ; Mon, 21 Apr 2025 18:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8F656B0005; Mon, 21 Apr 2025 14:40:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3E446B0007; Mon, 21 Apr 2025 14:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92CF46B0008; Mon, 21 Apr 2025 14:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 761DA6B0005 for ; Mon, 21 Apr 2025 14:40:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 23E3DBA27F for ; Mon, 21 Apr 2025 18:40:01 +0000 (UTC) X-FDA: 83358915402.06.1D82945 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 2640D180006 for ; Mon, 21 Apr 2025 18:39:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fgVKUPZh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745260799; a=rsa-sha256; cv=none; b=Jlm6m5PZLMlKwSxTeSNyjmmV9Bm909ORHMBrh8aRXKjz4bSBmc1z+BzRvE5q7veb2jZi7/ SftHyAawxJ1NK32zLX3Tf1pKBJUkr3sE3eBhQJJjXVn89bCvL5AlWhgA9yofe0JFGzOaF3 iE0FE0uk7bQfFl5My4EWVsDq4UefHSc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fgVKUPZh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745260799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAIZxQy/P+3Nu1Z7kf1woofN4LtVgfCv1xgdmj9WMHU=; b=iR0FSWmi9cyotmWbsxUF+uyDLAf9S1YHA2H/dpS4AC3nM90y+XiYl5wD/J99cgdRzi4v5I GnVMwupCtbiWRAv+1SH2lfAyOOFyRJq9o2UjvWkWSsyaXPNXvi0mfXajBfV84qyJ2uCSdG coqGiwv98p/jAC1vzilVmhaYcketEZ0= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-224171d6826so60349065ad.3 for ; Mon, 21 Apr 2025 11:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745260798; x=1745865598; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lAIZxQy/P+3Nu1Z7kf1woofN4LtVgfCv1xgdmj9WMHU=; b=fgVKUPZhOp9UyYK1pqQn1aSYwmYrRewHo9mdepP6YaaPqOvxN4OwYkBF6/3JnzeXiw 5b8bgkexaPC4miQd+qAER6MIkeev/NnC2TmfIN2Z5kPNtuzVJ4c6MWF5lLbcFP8QVm1L dcYXBPBIOL1IiFSSFWOw0IKD6RZK5luRpIZqF+R59lI5ww9fRHnifs4bYdoCPSzJtC+r m2iF5d6poZ1YWBagWaFcw9WryBqbsJIaDVhvvMgFV8cK+ikv/L4dhZ7xX7fVREOn67yo QrT9EKGj49UTLBpeg6tXGk27XMOS5k3Ve9ZzzJz8vweyVgbc93VBtRNEGrSDVNhKRSg8 OkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745260798; x=1745865598; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lAIZxQy/P+3Nu1Z7kf1woofN4LtVgfCv1xgdmj9WMHU=; b=j11rhGh8Jc/pJhTGJtEyF97Cg5ZOShlvgz7/T3wXKxh1Hue8IJzU1atpGg1lwEggar 0ssKy1bJmDlX69VNqeBhbh0+fzsnPxVOdXmQ6waBLr7g3MJZZPwVg1HnKXZ5wbh8O60L fQCd11NnAxRwwLCd/k5b0diY19cpKPhsh8M9n+jNAMafKvvEhgTPnG0FL0E5XoZBKrpy pRz12bDKNG2tlVwWmERZuofY/lJNgRlowvB0DlRrTE6dWecz+53/f8qG8m7b/Gmz1dLV c2GIK4ucjgVHXorD1x8LG8dh8H332XwnT9qh3ZpvqpBHMHygYhbtiSC4RWH2W/zz6pxc MJvg== X-Forwarded-Encrypted: i=1; AJvYcCWjDi95vXmcnUMgIgCo0QnE8jTx12LcTWVFprWMfAQ4G5IaoHCVsNIXBy+gCmzT2kgpYQPzUGhFeA==@kvack.org X-Gm-Message-State: AOJu0YwnnOiOd40Sqebo/SPGsiQw9J3MwiyMCSB4HJsVaM+tHzfCp0Rs /hwwOfee6Ed9WA0bBuF1YKSMWid+cfzAOoYf10n9w4g8rudw6Pnn X-Gm-Gg: ASbGncullvJTtVFUa2KmiUaUo5vWj+pGoBaqVQWo0CHl5zW3Ag+E7OcJOWYqhM2j1QY klWz6hl3kvptPTRolEWr5w2YvDmdhvLnR3NV0NXWyi/1Ba13fZZ1vVvdGku9b6XBLmHAmr/mBPC ttY+HTkmanQOT+pk/9Zoms1+6uLyLb/sWDBnuO1wKwajKi0nxm50DPpJptYKZJ8vqqR1xvydzQn OVM4nb59eme50lgwAT5LhbFeZ3ktHfJ2HheDOJjVy+K0uKqu9oS8F8bvcH0odNn+ZcriMBHN5xv f07erHFRT2DMJnC1IUPCqrdQnBf/Z7XWBlLthAbPWtQ4Gwpysf7AXIoe70DXi1jWCCbPpMR6pQ= = X-Google-Smtp-Source: AGHT+IGyoj4Rh+vfqZuk2CgjmnG5MfA3k6Mav6BUL84u1b/tcnNzmceNx1bsHWamLU00lRtJUqTBaQ== X-Received: by 2002:a17:902:ce86:b0:224:de2:7fd6 with SMTP id d9443c01a7336-22c535a7ef7mr158432195ad.25.1745260797898; Mon, 21 Apr 2025 11:39:57 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1151:15:3aff:e3c0:27f0:39c9? ([2620:10d:c090:500::6:17e0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbf8e4932sm7178117b3a.55.2025.04.21.11.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Apr 2025 11:39:57 -0700 (PDT) Message-ID: <49e38715-6fa4-4483-bdff-29732270438c@gmail.com> Date: Mon, 21 Apr 2025 11:39:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cgroup: fix pointer check in css_rstat_init() To: Tejun Heo Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org References: <20250421165117.30975-1-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2640D180006 X-Stat-Signature: zsk4k665u9ym3w333eqxz9xjerrmubb4 X-Rspam-User: X-HE-Tag: 1745260798-219400 X-HE-Meta: U2FsdGVkX19iv3qoF4CK7LzgyUPC4MqGkoY/oIC6509cKUpPojAeS/61J8K8OzsS/J1JEPsCbI0ZaGT8zhdIIUCoCFPTk6G98tHfkWGUFLWUBUrrOzTqBhD7AQeU3AnupYwOQwLq7ciRNQc8D+lQUWDNPHVRTMXPgWF8O8GtaUXjXzExjVQSRJHY63WE98U5IR/c4uHH9TEqRvAoKhUtS8DbTxQqKv5oQQSlwYeYCP807YsFpj++RNZ0DKrYHVuUuNBtxhdTWwqDAiuaqO/ZwMaeTDxRjmuI+dZ6lP8DyF1RYKUjnhhKNDyri9kQQap0dymrP4aaZmhcSrDb8cdUAjo3mieVY1kgrPpSqC4iC7C1gayK7ZcDNUBWJpv6CYgwSdvkUfvXeLToGpatMhyDki9hlU3ac5kaeTZi5ItvYLMpnNvHI5wtj6k+dce7yYhByemy3k2bW+Y6MyuRYdFvuicQLskJRtj7N46owvlvXDOrvARTIQHQLqsD+qrHiu5j/XGpZ/lMverHcfwleYJ1Kuh38BBuzR4gJ1feyc4t9ldJqLw0TjeEvfSAIZbG1fDY4t8vQFqRRw0qJwhJlTvW3Gd7b860P3CoBBmfvk4H6aGB9qwE3FTjcIoAi7n8Uco5Ap/IfKXcYfN8EpVzpLHoGVoBZLyHcwCeNq/Hp8lcqtBMkflB4KXgAg5lSB/pYqFVYMGs3URs5iYevXPlIRrQ9Yk4G980V1oa19wXnFrjGirhpzz+VYqf87b2BKYNcQjuaCcsjQ8WUGTb+6AiRWLedtdmQvphAgx35hxoIpEqfknjEkCPbMgMc8JSp8aKdtAzinEKzhcOEOW1ZyBxWdZLXLazBDjEgllcIyiBPgMd/rOk5DxRIiX7PwWg4C9VtQFzJ0I48ypdaD5FP2H4cGv1gy5aG2i4D6VmFk1xP/7sukKLLxyTPoqD4NKkRNO2XH5vcZh8zFiGbhPm35XQZp9 O5M7FGHQ l6ya8hznoYDQ00IHZg4c/SgJLGYN51x42lF1CN22wkkUwRT7ehqDzChRJ3EMdDTKKk7NnW6n9lsMXM9Pu0TUmL5UYCXu5v1IZePcQpn5QDLQ6UVUU8REtYakkzieceauykQXUI8tedI64/TXviYo4R+V6v0Jg/GfU5uDDxHaVau3MSoYyiwvHswWmmi5Seqe9HXfmgeMABi7kNJnzjjm4xMNDV+uexfrERXS1J5qWrtrRyocxW/fd7lTrc8ZlvGiS71nFUGJl5aoQqoyCrgHYKR8bZhbs91QJzEKmd3GwxoYmyw74vff/JsWg1hdYYn0m3GUEF4NsK0cW+hYf2gte8VIdN19cw905oEBbkCTNf+aWCtTSxWYXVr9K9rRjuaV2b8O0iXB2JtJI/k1S+giCQfSN4N0rWNbrLspoS6UpBOQb8FclqeMQp7won1kGt/zzGbc+IaCp7LVn2PghI9yrHkxpH9Ayju1jYoxb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/21/25 11:36 AM, Tejun Heo wrote: > On Mon, Apr 21, 2025 at 09:51:17AM -0700, JP Kobryn wrote: >> In css_rstat_init() allocations are done for the cgroup's pointers >> rstat_cpu and rstat_base_cpu. Make sure the allocation checks are >> consistent with what they are allocating. >> >> Signed-off-by: JP Kobryn > > Applied to cgroup/for-6.16. BTW, it could be nicer if you note the commit > that's being fixed or at least the target branch (here, cgroup/for-6.16). > > Thanks. > Thanks, will keep in mind moving forward.