From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C92C4345F for ; Wed, 24 Apr 2024 09:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 081368D0003; Wed, 24 Apr 2024 05:23:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00A378D0001; Wed, 24 Apr 2024 05:23:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E12FC8D0003; Wed, 24 Apr 2024 05:23:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C267A8D0001 for ; Wed, 24 Apr 2024 05:23:51 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4C7F71A0639 for ; Wed, 24 Apr 2024 09:23:51 +0000 (UTC) X-FDA: 82043888262.12.EEB7C64 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 04CB680016 for ; Wed, 24 Apr 2024 09:23:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Flg+A1hC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713950629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AssHIO3VvfTUux2rCuscSCwR8gSBFHOzhHWhVW5L1Nc=; b=d3iiYoypm2bcvb6/g5rAvQL+rFrBcUsKAuiKcsS5gM2O0hPZlwflCkrKNrfKO0YJ0fSWAs 22Lzf5LCOqkWQrCdyGv4n+IhOSrrTomejZ8IcTOT/MgdsuNZJp+eRqyQ1jbW3vOUkEXbnh ci4ytwFViAIYzY8FxftSwrxHC7nkB3s= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Flg+A1hC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713950629; a=rsa-sha256; cv=none; b=FmYDtjtWtvrz49E6b6ejhpyzytt0KKZzqJmZuAP8CBUm5jgg+/2VjvVSmoQgJx8YueIbgh kdloRzAfRlrh5sp4HEyOuPRZx4Ux/155Ry13/U4SsEb5df8hOrRCwngdvEF/Gdh1vqa7Jt c6/TBUchU7qdB0jJtaK9+8NPnMb3b7A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713950628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AssHIO3VvfTUux2rCuscSCwR8gSBFHOzhHWhVW5L1Nc=; b=Flg+A1hCu2adc2bBqpF99eCds7akDdhrgdEp7JrWACzZLKarkRZHTtIjoAwWfKp+8iaqKS K90G582D/Wpl0HJdfmRenD9h0fmJ6S0f521gI6y28b0K7AOnbJ967pTnfV1kethwXtTMXI yklwA0TvlZW1bnL6Mdu3AKKyhNguJDM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-oHPjeIHpNo6w9T6cOHJzZg-1; Wed, 24 Apr 2024 05:23:15 -0400 X-MC-Unique: oHPjeIHpNo6w9T6cOHJzZg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-34b5bece899so1431864f8f.3 for ; Wed, 24 Apr 2024 02:23:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713950594; x=1714555394; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AssHIO3VvfTUux2rCuscSCwR8gSBFHOzhHWhVW5L1Nc=; b=cJ+3EZ7Ne+Py91e7UjuQMz5R0EcdiYihx3iDz19XgaXSnZbUppueoxif8TCi5cDE0X RI/1H0uYf0D4synk/Q9aM8sidMN5MSis3PwZZDLzUeTxTNdftChGBG4UUWVEJZVGZpOE VgFYCtPLQwdnhf2qy0PjpXsqkvNzt5GMvQf6N9K+EYJrHUsrICLWZNOaHNp1y0ZfcHqQ hFg3F/+ozJPLOKlZnlMqRbxKI2AYAuHH4Wf6vBpOauasb7HlSXoHCr76y890SF1HdS6x jCdQgAOYpYUz//12OcF1f1+oxqFY5poWFmc0Ws41k3YKxclsBLY43/7ZTYnJmRBcCT1N d9Qg== X-Gm-Message-State: AOJu0YzP5838Pwrd0QGCZn7agXMK+0kSYND69OzigBlh5ynkIJYcQpQ3 vvLXn9tuhTchPp0Yz1Vd+ArAMUpU8zBeDIr65EV4eQVUs2l9RbDgCF/xNbo2N+g8obouG3R1J+g HVy7xbpk9QR/bpK3IlQ7f+ZoDlIqt9vWTxjy8VeI+ogckJH52 X-Received: by 2002:a5d:5581:0:b0:346:305c:b0eb with SMTP id i1-20020a5d5581000000b00346305cb0ebmr1232541wrv.22.1713950593766; Wed, 24 Apr 2024 02:23:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZI0XljlkmGfMm6bHycu8l8UnnsK6poVO81jpHTyzkE/qoi5wGjXy4wj72Gwrz6+jCvRQTVw== X-Received: by 2002:a5d:5581:0:b0:346:305c:b0eb with SMTP id i1-20020a5d5581000000b00346305cb0ebmr1232518wrv.22.1713950593363; Wed, 24 Apr 2024 02:23:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id x13-20020a5d54cd000000b0034335e47102sm16556281wrv.113.2024.04.24.02.23.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 02:23:12 -0700 (PDT) Message-ID: <49d85e19-feac-417b-9640-ff8059bc8b0b@redhat.com> Date: Wed, 24 Apr 2024 11:23:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm,swap: cleanup VMA based swap readahead window calculation To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Alistair Popple , Anshuman Khandual , Mel Gorman , Miaohe Lin , Minchan Kim , Ryan Roberts , Yang Shi , Yu Zhao , Kairui Song , Barry Song , Chris Li , Yosry Ahmed References: <20240424063042.665018-1-ying.huang@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240424063042.665018-1-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 04CB680016 X-Stat-Signature: xyypfoip9k3h8jjqeu9ku4p4encqsm6y X-HE-Tag: 1713950628-568559 X-HE-Meta: U2FsdGVkX1+XpopTqxM99+Tn8j+wEMyHpG3kvlzNtNLne9y/AZbnc6AT0Jyyn4JZO6W4KR+zW+tMw00yD9TANF/vM6i1aN88L3wERlwUfha0HlZX+8Vtt6v7ZlELCVR0BxwO416MIBC1nCpBwmjn8evFin+agXSimFL7PdtvNy1MiiEDo6bEmVpUg8IE1O0FXLQb2JdcvPnL8CcA4RQE8PpksmK3BmXxC2lBaFVds8ExTDrczLt/k4Pv3HN06X+pHolE7GKXa0uwe585+eOSde7Q9LfquFFkJqydZ05HK0hXUHIpPx/+80qpc68iZrhzbAJF8PQwe/l/NExXzV3JMpo5EHIyKDjweP/x1R/YkiuSPcOldGhmiUZRkGV50x6FvvdIYVdNcagENW6Ewba3ZbEv7f8tIZjd/kUuxdVXcTq6C4nfD3p6AqZaTXuFZfSlM/0//eIKac6DodGRsJbzQegKM46EQGLvVYkMK0zuCq0cTGtCMvhAVzay/JDJi/R7Ukc9OLgapCIwYJW9+LWvSbdy+LgmX8ID+7V0+vY+SHquqaP4kVzF2gZNzssUD67T9itIOHiXa7ZiST/4A+l/1IHT4VJ7ntsMD96UOiBKpTZIXgi1Mp/q/j2tVJ4YTFNEeSjHeZ6SRnKF7iaqjEAvCs5z2sRu6Gm1TAi/MA0EM/iczOn6SNehv3mDjzyW24Qy5t2Y90KJsmH8AWgBLOJX+dnP0qFqk2FSGNxfLAZeQoSAfSU1L30rECzkNjIKBBfKn5m8h0gYpASILwdfIroQo4+KzzTtULGIU7WydldkUKbxqvb8MxN5aBE7wGFo6/KubXAmAdqbmqHY0GdIHDx2lHG0g7qPXkYAI5gLI2MrqDqzMNEOVFMSGyuCQesYexHNSeG2bMT7Ca1lETFXgrPbyplRwqwe7ivPSRfHHyKe1dRvax/7tPiorDX629Pk46LZJ5kA5xVCDo3fSCC9wwI R0pJufIs gztY2nzgpy9iKAQCWBvqSM29y7ua193xwWWHb7lnszjzLenaTqG06iaz7oDar+G0eKGa1B4FyKBGfcea1Dah9KEOMCy4qIpEB/GXPik52hTiIlYyN3DiL114WfPN7tZIyr+7/Bno64cKNS/redHr2FAJD3EBAFiyAXhDgxyqQfS92BMkBw3C7doYwak9ibS29l8bBK0wJJGsOjL/bAcU5nweGzipUe8lfhwqOXCd7U+a/yjMrw6zdOLsmrX0jCIV0KfjrrMlfPft/ZdrSepv5kWyZxgYbWga4TCPCSQosJBgP42mTuxUsMwypOTLDRT+djoyNwby5yJYOp5TCAV54u/t6NUJH/7/SPGQMkdZjLnr8Ty4swhzM5qSbl8x6kd4bKESx34U/nxMPvKHDvKt6salVZYeXbytVMRf5MEfyiXdzKGE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 08:30, Huang Ying wrote: > When VMA based swap readahead is introduced in commit > ec560175c0b6 ("mm, swap: VMA based swap readahead"), "struct > vma_swap_readahead" is defined to describe the readahead window. > Because we wanted to save the PTE entries in the struct at that time. > But after commit 4f8fcf4ced0b ("mm/swap: swap_vma_readahead() do the > pte_offset_map()"), we no longer save PTE entries in the struct. The > size of the struct becomes so small, that it's better to use the > fields of the struct directly. This can simplify the code to improve > the code readability. The line number of source code reduces too. > > No functionality change is expected in this patch. From a quick scan, you perform quite some unrelated changes that make the code harder to review than it should be. Consider separating any cleanups from the core change of removing the struct. -- Cheers, David / dhildenb