From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E11C4332F for ; Tue, 24 May 2022 14:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3CD38D0005; Tue, 24 May 2022 10:31:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE8E48D0002; Tue, 24 May 2022 10:31:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD9578D0005; Tue, 24 May 2022 10:31:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9BC2A8D0002 for ; Tue, 24 May 2022 10:31:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 64F7A34914 for ; Tue, 24 May 2022 14:31:09 +0000 (UTC) X-FDA: 79500873858.23.B4E047F Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf01.hostedemail.com (Postfix) with ESMTP id 727B040039 for ; Tue, 24 May 2022 14:31:05 +0000 (UTC) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4L6xRM08ZJz1JC6X; Tue, 24 May 2022 22:29:35 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 24 May 2022 22:31:04 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 24 May 2022 22:31:03 +0800 Message-ID: <49ca1cd8-e9a4-a76f-abae-d6204691665f@huawei.com> Date: Tue, 24 May 2022 22:31:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Content-Language: en-US To: Arnd Bergmann CC: kernel test robot , Catalin Marinas , Will Deacon , Andrew Morton , Linux ARM , Linux Kernel Mailing List , , Linux-MM , Christoph Hellwig , "Anshuman Khandual" References: <20220519082552.117736-5-wangkefeng.wang@huawei.com> <202205240657.BXxrhbgp-lkp@intel.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 727B040039 X-Stat-Signature: agcmc8nj1y1gwxxacrwigmezcite87ux X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-HE-Tag: 1653402665-925761 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/5/24 20:35, Arnd Bergmann wrote: > On Tue, May 24, 2022 at 11:48 AM Kefeng Wang wrote: >>>>> mm/ioremap.c:59:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *addr @@ got void [noderef] __iomem *vaddr @@ >>> mm/ioremap.c:59:16: sparse: expected void const *addr >>> mm/ioremap.c:59:16: sparse: got void [noderef] __iomem *vaddr >>> >>> vim +59 mm/ioremap.c >>> >>> 51 >>> 52 void iounmap(volatile void __iomem *addr) >>> 53 { >>> 54 void __iomem *vaddr = (void __iomem *)((unsigned long)addr & PAGE_MASK); >>> 55 >>> 56 if (arch_iounmap(vaddr)) >>> 57 return; >>> 58 >>> > 59 vunmap(vaddr); >> 1) Will add generic "arch_ioremap/arch_iounmap define" >> >> 2) and change this to vunmap((void *)vaddr); > I think this need an extra __force to actually suppress the sparse > warning, as in > > vunmap((void __force *)vaddr); > > Using __force is usually wrong, this is one of the exceptions, so > maybe add a comment > as well. Right, I found this too， and  using  ___force in local, will update, thank. > > Arnd > > .