From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AFBD2E010 for ; Wed, 23 Oct 2024 04:19:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F82C6B00A3; Wed, 23 Oct 2024 00:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A8096B00A5; Wed, 23 Oct 2024 00:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897FC6B00A6; Wed, 23 Oct 2024 00:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C2146B00A3 for ; Wed, 23 Oct 2024 00:19:15 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4F1A61206B2 for ; Wed, 23 Oct 2024 04:18:59 +0000 (UTC) X-FDA: 82703561430.07.67ADB35 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 7E4691C0006 for ; Wed, 23 Oct 2024 04:19:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729656951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGL0m7G5QGdxHnK0ZB88mRBsl2QSAlA+12PD69VE9gI=; b=cuaz701SleiPzyCmbovlyhyBVx33mKXh553sihuY8aQBrjFtKUY1OCEYAwjNUGlwykfpsd jP18m5hpC7sIfB6qb3tnfcvZI3/oHEMR2Hoaxa4cEvb8JukLZYRWi+kss3Ji1IKL0NBFOK 8LGV+zFuJxJfONNv9lEe55dFhZYaDXE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729656951; a=rsa-sha256; cv=none; b=t5OFSFa8ir/iEs7mmhpeBUUocQ0ZCn4jUGrYeUyF0UtPzCu3IPGb6N6/NeFPXESx19tz+u Grgl8DypKWR9ZK2+w6etO1hI/9GjprCLrxvh1DNU01NsXhxKf3WoifChQAPwP1OIN8k0kP FcCwRpZTx+61d2u0MOp7QqewoWcZ7dc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 84C24339; Tue, 22 Oct 2024 21:19:41 -0700 (PDT) Received: from [10.163.41.228] (unknown [10.163.41.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E7413F528; Tue, 22 Oct 2024 21:19:08 -0700 (PDT) Message-ID: <49a7dbae-d382-4b60-b08e-2aaca9eb343f@arm.com> Date: Wed, 23 Oct 2024 09:49:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/codetag: fix arg in pgalloc_tag_copy alloc_tag_sub To: Sourav Panda , akpm@linux-foundation.org, surenb@google.com, yuzhao@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com, weixugc@google.com References: <20241022232440.334820-1-souravpanda@google.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241022232440.334820-1-souravpanda@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7E4691C0006 X-Stat-Signature: qjjppynw4epd9ck473cxrfcroe7eb9bm X-Rspam-User: X-HE-Tag: 1729657145-84260 X-HE-Meta: U2FsdGVkX1/55Nx6NiuAAltuLn9Vm3eGPrz6YRyYFfKe9DgcL6f2zVgzTW9r6Klw0HYH1I6IjrF1z14WMDgIW9yx0W7JBaTpXhSrQfV5fwFdga8z3Lj2hmGYsjImG1tN+D42FQOYX7sV5NFdX0dtEglj3x+frG5+b3v87j7eZmbFUGYlNmI1qZ356IZ99A2WOxSBuV1R7+yvPyEQw0kE6YPY4wt1gcxpKW/fMW9sAkmP9i0aVbgrQWxB/tMKJ0TD+nHPRzOQDwdMN+3SDK0b2EyuksmduG6/+6XF5OjB3/D69hacxhfIeIx41ed1zZGMUD+kTw3MULECPx621eGKebjxlg1o4finIb7tm5NkR2AMqgks6Cxy2YbBSmmjrykJMhxwdN8n8MbwNQvurKvEr3KdYrFCE1jdB4NvSiLIdjusAPDstaYBk/oaZUrdOogWHAfZ+PSVttfwjZYCC32NdyX2/mlMjj554ZHVzJD+8TlE7TzqKFynClV4e8arSU6j753Mr3AJgX1jzdPTqMpyiPhNGslq1mgB7Kp5WEQciI7fWmEm17IGrSxCByNnf6K1Xf3WuBCnLIUtNsgMUio1QDlvmwD6XHJF6veAmlT6SORMzagmTihei/ARWfF5ePNzbsXxPKhho+DP9sF4bNhTtjizjJUlSn+O8ATydl6UJfL+oYe/AoqzcwRU9mQMj+f621feDFQqbdUyGnwgZnGUqIlyeCPThV+DL2Re9VqZvlHc3t5wWy17kf/vdIWGTMvMy0ZO8v/eTVLb71H96725cNaO7C3feqAcCypQV6moPNmtoEJU2t2NQEwpqMd+OZpy5k2ozKlokva+KkIBKNctVtRbv0dV+g2BlOJVmV+ApdSTG8TY3hAAT8GZs/l6+Ey5XanAzSV3O68nRgLR18NrZSdGY64kBNdwuZ1hmAhpqUP+WEuMYHX7MUQiuRA5uK1ykjNhI9geVh1gLqLXlcV t6A4Q/uW 87cAcLYZAD+675HryfcPQSopO5uaLMQHu+djnY6+Nuvrgl3jX8QgjCGLSirtPGWARpA8/RXnIn00iMXkQUGlmo6GNp10hfCsD8PQhCYAuIQ7yHqdttT162XBNwrJRxqRENQxwFIN2GFQ09IIFzUrhgC/i0cJxB1qaZhrJq1EfBo18EET/9bk4uKonokaFAnfQBMQSO+iUOfyHsLFBdSW7XXI64nS11pKT7f/PQ8/yUH1mhn2ae81xUNSUj3AE6T/e2T6uIHCCHUMnXF5l4hKaVMC2wkQDtGF91kI/tjS/QL3wab/Zy3z8ZhcP3X2/BMslJnAZ2p3UubcwVc2Ctw5QzfXdcVeI3OboxZx0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/23/24 04:54, Sourav Panda wrote: > alloc_tag_sub() takes bytes as opposed to number of pages as argument. > > Currently pgalloc_tag_copy() passes the number of pages. This fix passes > the correct unit, which is the number of bytes allocated. > > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") > Signed-off-by: Sourav Panda > Acked-by: Suren Baghdasaryan > Reviewed-by: Pasha Tatashin > --- > Changelog: > Added Acked-by: Suren Baghdasaryan > Added Reviewed-by: Pasha Tatashin Very minor nit. Just mentioning that the tags have been picked up should suffice. > Fixed the nit pointed by Wei in the commit message > > v1: > https://lore.kernel.org/all/20241022205622.133697-1-souravpanda@google.com/ > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index ecf63d2b0582..2890001c8b97 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4203,7 +4203,7 @@ static inline void pgalloc_tag_copy(struct folio *new, struct folio *old) > /* Clear the old ref to the original allocation tag. */ > clear_page_tag_ref(&old->page); > /* Decrement the counters of the tag on get_new_folio. */ > - alloc_tag_sub(ref, folio_nr_pages(new)); > + alloc_tag_sub(ref, folio_size(new)); > > __alloc_tag_ref_set(ref, tag); > Reviewed-by: Anshuman Khandual