Re: [linux-next:master 10717/11408] include/uapi/asm-generic/mman-common.h:16:25: error: expected identifier before numeric constant

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

This is already addressed, the relevant patch has been dropped (see discussion in [0]) and should
disappear from -next shortly.

[0]: https://lore.kernel.org/all/<20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3@kuka.com/

We are putting together an alternative that won't break s390...

On Thu, May 15, 2025 at 11:13:14PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   484803582c77061b470ac64a634f25f89715be3f
> commit: e9fda188b61524e6426fee21fe939ebc13866fc5 [10717/11408] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP
> config: s390-alldefconfig (https://download.01.org/0day-ci/archive/20250515/202505152329.ZRMQwmrx-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505152329.ZRMQwmrx-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505152329.ZRMQwmrx-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    In file included from include/uapi/asm-generic/mman.h:5,
>                     from ./arch/s390/include/generated/uapi/asm/mman.h:1,
>                     from include/linux/huge_mm.h:509,
>                     from include/linux/mm.h:1016,
>                     from include/linux/kvm_host.h:16,
>                     from arch/s390/kvm/kvm-s390.h:17,
>                     from arch/s390/kvm/gaccess.c:18:
> >> include/uapi/asm-generic/mman-common.h:16:25: error: expected identifier before numeric constant
>       16 | #define PROT_NONE       0x0             /* page can not be accessed */
>          |                         ^~~
>    arch/s390/kvm/gaccess.c:321:9: note: in expansion of macro 'PROT_NONE'
>      321 |         PROT_NONE,
>          |         ^~~~~~~~~
>    arch/s390/kvm/gaccess.c: In function 'trans_exc_ending':
> >> arch/s390/kvm/gaccess.c:344:17: error: duplicate case value
>      344 |                 case PROT_TYPE_LA:
>          |                 ^~~~
>    arch/s390/kvm/gaccess.c:337:17: note: previously used here
>      337 |                 case PROT_NONE:
>          |                 ^~~~
>    In file included from include/linux/compiler_types.h:89,
>                     from <command-line>:
>    include/linux/compiler_attributes.h:214:41: warning: attribute 'fallthrough' not preceding a case label or default label
>      214 | # define fallthrough                    __attribute__((__fallthrough__))
>          |                                         ^~~~~~~~~~~~~
>    arch/s390/kvm/gaccess.c:343:25: note: in expansion of macro 'fallthrough'
>      343 |                         fallthrough;
>          |                         ^~~~~~~~~~~
>
>
> vim +16 include/uapi/asm-generic/mman-common.h
>
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15   9
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  10  #define PROT_READ	0x1		/* page can be read */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  11  #define PROT_WRITE	0x2		/* page can be written */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  12  #define PROT_EXEC	0x4		/* page can be executed */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  13  #define PROT_SEM	0x8		/* page may be used for atomic ops */
> d41938d2cbee92 include/uapi/asm-generic/mman-common.h Dave Martin        2019-12-11  14  /*			0x10		   reserved for arch-specific use */
> d41938d2cbee92 include/uapi/asm-generic/mman-common.h Dave Martin        2019-12-11  15  /*			0x20		   reserved for arch-specific use */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15 @16  #define PROT_NONE	0x0		/* page can not be accessed */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  17  #define PROT_GROWSDOWN	0x01000000	/* mprotect flag: extend change to start of growsdown vma */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  18  #define PROT_GROWSUP	0x02000000	/* mprotect flag: extend change to end of growsup vma */
> 5f6164f3092832 include/asm-generic/mman.h             Michael S. Tsirkin 2006-02-15  19
>
> :::::: The code at line 16 was first introduced by commit
> :::::: 5f6164f3092832e0d9b12eed52e09a76bf39c64a [PATCH] add asm-generic/mman.h
>
> :::::: TO: Michael S. Tsirkin <mst@mellanox.co.il>
> :::::: CC: Linus Torvalds <torvalds@g5.osdl.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki