From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02463C77B7A for ; Thu, 25 May 2023 11:42:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E2536B0074; Thu, 25 May 2023 07:42:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 893A66B0078; Thu, 25 May 2023 07:42:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 781F46B007B; Thu, 25 May 2023 07:42:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 690CE6B0074 for ; Thu, 25 May 2023 07:42:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 320731A0BD8 for ; Thu, 25 May 2023 11:42:07 +0000 (UTC) X-FDA: 80828588694.04.2B44FB4 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf03.hostedemail.com (Postfix) with ESMTP id A79BF20009 for ; Thu, 25 May 2023 11:42:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685014925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8rmPNqUcyRtwtii7WXMDiOcC3Xt9J809ABjDNrpL0w=; b=b8L9Su+xcmzYjdgpOO1kPFHRuCt7YSC4IEQf35Xgxjsg6OuT1xCLKW0KaE9mABY9bMSgdk AOk79p2iHJCmLYMvKaNZXEihTJJ8Gm6FfhieaFS7shNRqUpBC+GPSLuq1rg04O3MMyTuQd CdlUbv6XSCGkwzDJV0j+bE9341seL34= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685014925; a=rsa-sha256; cv=none; b=iLSKW2JKVAM5P7e5h+bZhPyh3NXgXY7eXDT9m2wu5ArGbyWF1r5/3+ensvrrWc2zJ072DZ gIOBjh75z45oWseiv1F24NHvaP262sFzRQa8X3oIKnAv/quHyKarFy2Ywtb1yHXVE4Gou3 aIC+WbvkhKE2rUcZVpZWy6mlrAm4ceI= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QRmHs5KcbzqSTH; Thu, 25 May 2023 19:37:29 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 19:42:00 +0800 Message-ID: <49933f51-a17e-8eef-7539-10759a6fa3e2@huawei.com> Date: Thu, 25 May 2023 19:42:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2] memblock: update numa node of memblk reserved type Content-Language: en-US To: Mike Rapoport , Andrew Morton , CC: , , , References: <20230525115742.124190-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20230525115742.124190-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A79BF20009 X-Stat-Signature: 3n315tca58ygxk8r5rem67et46t8cjwx X-Rspam-User: X-HE-Tag: 1685014924-217790 X-HE-Meta: U2FsdGVkX1+gQWcnDRRcyjZE+FEs23cKF0xuC/K/kHlAAWIjiOmPEe0B1M1TjA+rHKUMKZxF5fG0SLcaZ/UcMHvsIfMoWThkfyOJXEyFRsVBxmIK49LSUOwonHd+RBlHeExasmhmhuFAeTTQSzsjVyNzG5DCstjcEE9aqHYM+UEG+0+4pGGg+3MI44BZ3CKQNpZ9jPMQ7LmMrWSGUDKVZNwSeSQYXtDUrmfHmgda799iEzsBoz7iCS125WNjrzppwsymWGQ+DYApTIekGrw7QG/O7UMyc+T8DiZQqpAumzwq8HnTtXzrCmS4YUr6FPS6bCJ7Lqf8kznMZjOmuyLupxkhusWkwESS3mlghjebGVjRO8vaxkMJrelCIH93nrAbGD1/C7ew07wJ/oFKbsaRwUflOPdi5KrUy07+C0YzkWQdfG/PgdI0l9qt086el/1u8Bkwr0FXeRcbJ0iJ1G1TgLFdbQSxp4AS8xhJrYO+GH/tanvNYMWn/k0sIhRFY17UD/rBfuVsuXGd9S7M6jDp1WcQwBs9U8N8BGcOLWZjIRoYC3OHWdODM4eUFUR65JFCugX9S962KSwO0oc/g0hxBqNMafmDy4wHYLKH8ZqqxzpJDUjKrrwBxot3DtlgH5TJyVJyxcop8jT/bncLW6/PIFbThdp1sstf5NOa+8prYOJ2yJsUTdXC7o55+C05xWF5XTo9A9BjCJ9KhdorPHNhBZH/xRrwksOujxS/vE1lyyjWJB/GeRpHRNZbboyexpnEBPW3o5HTJJUSR1Y9O18m6lDF0r3ERLIPqrjfU822P9ZT8psS0SwSeVlwePJL1QGrfvlr4QvmxogUZ+tTPDU8Qo8HZUfBZtA+1zd56WHsqHMSNLIspRs0GDcFk/2+4+e4RXztWpLvWASrY4OA+EMwyemvVOUqkIjS1VnWgWH9Ls03lc0l1eff8sjDahzi7G0aF1nNRr5WtBKU11jcoLu 1+IZN12R RHmD2T8ejY97B2gOeZsAAGUXBDp1Fz0Vqtav6L12ju/sgCt8lt3H8hLJHIpINVrL6d/XPn4kEkc1luDO68oVwGxITlar/u4wVVh4mNikJRSreKawIjr61CMrRiw4xOWkoNSvut4blAxsT8NMS0VjGvWr5uA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: please ignore it, send wrong patch... On 2023/5/25 19:57, Kefeng Wang wrote: > The numa node of memblk reserved type is always wrong when check > memblock_dump_all() or sysfs file (/sys/kernel/debug/memblock/reserved), > no one use reserved type's node except the two debug interfaces, > but uncorrect value is bad as the above interfaces are visible for > user. Let's fix it according to the numa node information from memblk > memory type by adding a memblock_reserved_update_node(), note, it will > be called twice since memblock_reserve could still be called after > memblock_dump_all(), or the sysfs file read may get some wrong value. > > Signed-off-by: Kefeng Wang > --- > v2: > - update changelog, explain why update reserved node info twice > - move memblock_reserved_update_node() from sysfs read into > memblock_init_debugfs() > > mm/memblock.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index c5c80d9bcea3..50dd12958e60 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1899,6 +1899,28 @@ phys_addr_t __init_memblock memblock_get_current_limit(void) > return memblock.current_limit; > } > > +static void __init_memblock memblock_reserved_update_node(void) > +{ > + struct memblock_region *rgn; > + phys_addr_t base, end, size; > + int ret; > + > + if (!IS_ENABLED(CONFIG_NUMA)) > + return; > + > + for_each_mem_region(rgn) { > + base = rgn->base; > + size = rgn->size; > + end = base + size - 1; > + > + ret = memblock_set_node(base, size, &memblock.reserved, > + memblock_get_region_node(rgn)); > + if (ret) > + pr_err("memblock: Failed to update reserved [%pa-%pa] node", > + &base, &end); > + } > +} > + > static void __init_memblock memblock_dump(struct memblock_type *type) > { > phys_addr_t base, end, size; > @@ -1932,6 +1954,7 @@ static void __init_memblock __memblock_dump_all(void) > &memblock.memory.total_size, > &memblock.reserved.total_size); > > + memblock_reserved_update_node(); > memblock_dump(&memblock.memory); > memblock_dump(&memblock.reserved); > #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP > @@ -2209,6 +2232,7 @@ static int __init memblock_init_debugfs(void) > debugfs_create_file("physmem", 0444, root, &physmem, > &memblock_debug_fops); > #endif > + memblock_reserved_update_node(); > > return 0; > }