From: Li Zefan <lizf@cn.fujitsu.com>
To: balbir@linux.vnet.ibm.com
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [-mm patch] Show memcg information during OOM (v3)
Date: Wed, 04 Feb 2009 09:35:32 +0800 [thread overview]
Message-ID: <4988F0E4.3010404@cn.fujitsu.com> (raw)
In-Reply-To: <4988E727.8030807@cn.fujitsu.com>
>> +void mem_cgroup_print_oom_info(struct mem_cgroup *memcg, struct task_struct *p)
>> +{
>> + struct cgroup *task_cgrp;
>> + struct cgroup *mem_cgrp;
>> + /*
>> + * Need a buffer on stack, can't rely on allocations. The code relies
>
> I think it's in .bss section, but not on stack
> and it's better to explain why
> the static buffer is safe in the comment.
>
Sorry, I just saw the below comment.
>> + * on the assumption that OOM is serialized for memory controller.
>> + * If this assumption is broken, revisit this code.
>> + */
>> + static char task_memcg_name[PATH_MAX];
>> + static char memcg_name[PATH_MAX];
>> + int ret;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-04 1:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 17:21 Balbir Singh
2009-02-03 22:46 ` Andrew Morton
2009-02-04 3:36 ` Balbir Singh
2009-02-05 21:55 ` Andrew Morton
2009-02-06 2:26 ` Balbir Singh
2009-02-06 7:01 ` Balbir Singh
2009-02-04 0:53 ` Li Zefan
2009-02-04 1:35 ` Li Zefan [this message]
2009-02-04 3:37 ` Balbir Singh
2009-02-04 5:24 ` KAMEZAWA Hiroyuki
2009-02-04 6:42 ` Balbir Singh
2009-02-04 6:48 ` Li Zefan
2009-02-04 6:52 ` KAMEZAWA Hiroyuki
2009-02-04 6:50 ` KAMEZAWA Hiroyuki
2009-02-05 4:00 ` Lai Jiangshan
2009-02-05 4:55 ` KAMEZAWA Hiroyuki
2009-02-06 3:02 ` Li Zefan
2009-02-06 3:10 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4988F0E4.3010404@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox