From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0ECC6FD1D for ; Tue, 21 Mar 2023 07:48:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81EF6B0078; Tue, 21 Mar 2023 03:48:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E31466B007B; Tue, 21 Mar 2023 03:48:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1F4B6B007D; Tue, 21 Mar 2023 03:48:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C63616B0078 for ; Tue, 21 Mar 2023 03:48:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 84CD3AB385 for ; Tue, 21 Mar 2023 07:48:34 +0000 (UTC) X-FDA: 80592128148.24.6175988 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf29.hostedemail.com (Postfix) with ESMTP id 87611120018 for ; Tue, 21 Mar 2023 07:48:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hs4Xd6jb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4I+JAgRO; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679384912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x0T22BvyLsxTGKRp8ptWSENdQ9AmQVE5GpVIAlDWlTA=; b=2IGmo5DpnXL3fkiYwXyAdHBEfEq3zHq9Zgb4IkCHgpFa8gPbYjV8bp87zNBud9C8jv/yL+ HY7vtl1UEFmVs4uC3MCQGuPcW+mvjmHT/Eg4cUGVrMlIA7+xFdwiBolI545tURTsrNDmRr vEURdpfrtuzmrIlsR4vHgU3o55Te11w= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hs4Xd6jb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4I+JAgRO; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679384912; a=rsa-sha256; cv=none; b=KbzxKA9BRav6N/6CHVUw73gtI8kQoPm6ut5o8jfr7WaLR3+7FsHmAUC/lnwPBtQ1qg88ZO mL7OcM2kZVoZwm/cJf+rN8Gg8fwADBj3HFTQ50zDrJTpP7TgAK8yQ37pphkXOFsIxee7fi xQrG3JEVPhPHv82lgaX06sFicP+mHoc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02A051FD6A; Tue, 21 Mar 2023 07:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679384911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x0T22BvyLsxTGKRp8ptWSENdQ9AmQVE5GpVIAlDWlTA=; b=hs4Xd6jbhFnM66NWCm2SPklmq1+37dljFeBscauEi982ADeYjhibIiWXW8keHZOvQaP7DD qttn2UaybcB+7d9rPZGox3kNcQdQ8JNvsUGFvbPSZK8jb5G4WQqhLEPYP7XIzzumL8HU+c KdBf/xwk4cjZ6NaspVKB6WBCLzytAqA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679384911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x0T22BvyLsxTGKRp8ptWSENdQ9AmQVE5GpVIAlDWlTA=; b=4I+JAgROtJSR6tNw7RBJK0pVCf0hOuyUJTV1w2guIaO2+hrG3UQUYhbjpWn3MiYha8fQeP 6hhbjYcM3xSu42Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2BDC13440; Tue, 21 Mar 2023 07:48:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p+bHMk5hGWSfKwAAMHmgww (envelope-from ); Tue, 21 Mar 2023 07:48:30 +0000 Message-ID: <498307e2-3952-801b-4847-1255214f5c76@suse.cz> Date: Tue, 21 Mar 2023 08:48:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 01/10] sparc/mm: Fix MAX_ORDER usage in tsb_grow() To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, David Miller References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-2-kirill.shutemov@linux.intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20230315113133.11326-2-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 87611120018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: kjgy3h3bufxrxzprqmcmijuyje31tysp X-HE-Tag: 1679384912-682522 X-HE-Meta: U2FsdGVkX185JpYLm0Sz2Y1SotCbhC0JBjWoX8lbBACgmndCN/lXMr5W0PucjiTekJa8cC6kqpXX1mRNk0zxefVRpMiN8wguW+8V7V5JT7gbbzGnQ1ElzBlCghP7jtr9sdC/VUkTOJ7Cru+azXlDZKh9c76gWW+LZDbR7aZxBauiOTzt+apNbLkVMQ7c5p02LcR1TPxozEz1Mljw9yBEL102FQMk5Wn4WnaVM8Dy6ujmVOHnk7ZYF9Zz5Oo4wCw4q+nzHTxRBTXCEMzZmLPsXu+7JAWnFBr7Xz6f9X3nsJTiz+zVC7bBVz6mYylLWBhStGSWQx7+tfu4IrD4cCHh5Nv9nT6iNDsAMD09p68sLhXPU8JNwLf3xFu69PenxABi0P/sNR6zD+NgNGoA8cKzk46vwJzsKdr6j5QmgDV9pfAmuTwyE2zHiJqa18TD38HTdBFLZ33PHqxbrRiMQL+H79lT6hzNRt9ZA3SUEhvWEjLLY090aZy6/ha8jBBcy5elNsiBvdzaY7i4poZYt/r3VorumnUMhJntGogU6EHMkEXJOtuLOjexmvqccoNCOqBQAXGNs6HOpzjzHpwtvQNyKBfNY6U/FPLzt4i6n9vemnapq88+C9HRtd8A6Wx4Nwg3SbY5QJc/TZD3w7l926aO08v7+RUK4MwUhaWwyLxeiRwGwof6CM0w0MtA6JoVsa16t4q8YcefophKtL1X8NpUACzUWveI638dI20wtXdHWXHCEvQcyM9s/ez4C66LOA0pRHBhqaq/4+UqXC44NxGgfTKbCMHT9TIcjF2jpk9jzgkvH6zIc1cavIQc81zIzq7K9sh+I5IOwK4Re/xaTXSsBYX787O1VsCiMHnrywF8rp3KBh6t0MgX1Je3mmSA5cI3uRm/uHhGbmg1COGubLh5nH+67rbFKNkX7WacOjv/F0aPKbxMsCYXYAfAAVbuZt+2eKjPy/u4Zp0IEX5lvTi boQwMGKz B83Pe13k/UuKgKDimAfXk5d0Nhrmb3NC9oJljoHnZajCfr6ACtNy+XdjQaZRLejNNXPtLiKSmpDKfk1otbsXgoIpPbzZ7A6hBsF13AEh/xUsraCVMriWv9n5eDnKt4s+OOnirmzk0nRzfNi8f1jYLc7XF9oYpbVBbu4fM9CD+OVWNKENJqtOGbYtfyQ38ovNt2DefPAfOqy+d6FxEKTQNfJev1yIrkU+M8aBNEKJrYWiM1IUG8WE27RVS7Oarx8/mJqY8zw1Ul2Tt6ZxsHwah1SY036DYnUs/SELdHhPAkMlOjZM/mNx/MOvFGLjb0gzYUCAmBkjpUQ2YtUtuk9c70aVAOI1dV/N8IJCIc2H2uzwFp66Rbf6awJmvCNUeg7KfLwzBlM1XUPTtWw6bQZdz/I+gbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in tsb_grow(). > > Signed-off-by: Kirill A. Shutemov Acked-by: Vlastimil Babka > Cc: sparclinux@vger.kernel.org > Cc: David Miller > --- > arch/sparc/mm/tsb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/sparc/mm/tsb.c b/arch/sparc/mm/tsb.c > index 912205787161..dba8dffe2113 100644 > --- a/arch/sparc/mm/tsb.c > +++ b/arch/sparc/mm/tsb.c > @@ -402,8 +402,8 @@ void tsb_grow(struct mm_struct *mm, unsigned long tsb_index, unsigned long rss) > unsigned long new_rss_limit; > gfp_t gfp_flags; > > - if (max_tsb_size > (PAGE_SIZE << MAX_ORDER)) > - max_tsb_size = (PAGE_SIZE << MAX_ORDER); > + if (max_tsb_size > (PAGE_SIZE << (MAX_ORDER - 1))) > + max_tsb_size = (PAGE_SIZE << (MAX_ORDER - 1)); > > new_cache_index = 0; > for (new_size = 8192; new_size < max_tsb_size; new_size <<= 1UL) {