From: John Hubbard <jhubbard@nvidia.com>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
Minchan Kim <minchan@google.com>,
Joel Fernandes <joelaf@google.com>,
Lokesh Gidra <lokeshgidra@google.com>,
"Cc: Android Kernel" <kernel-team@android.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
the arch/x86 maintainers <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Sami Tolvanen <samitolvanen@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
Hassan Naveed <hnaveed@wavecomp.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Mark Rutland <mark.rutland@arm.com>,
Mike Rapoport <rppt@kernel.org>, Gavin Shan <gshan@redhat.com>,
Dave Martin <Dave.Martin@arm.com>, Jia He <justin.he@arm.com>,
Zhenyu Ye <yezhenyu2@huawei.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Zi Yan <ziy@nvidia.com>, Mina Almasry <almasrymina@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Ram Pai <linuxram@us.ibm.com>,
"Sandipan Das" <sandipan@linux.ibm.com>,
Dave Hansen <dave.hansen@intel.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
Brian Geffon <bgeffon@google.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
Ira Weiny <ira.weiny@intel.com>,
"SeongJae Park" <sjpark@amazon.de>,
LKML <linux-kernel@vger.kernel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 1/5] kselftests: vm: Add mremap tests
Date: Thu, 1 Oct 2020 11:36:25 -0700 [thread overview]
Message-ID: <49725bf8-edde-0773-ade3-6e2d0d380b34@nvidia.com> (raw)
In-Reply-To: <CAC_TJvdrAhyypTFqgYRmZj1ndiuuad0VfvgENhdWAO+Kp1r_=Q@mail.gmail.com>
On 10/1/20 8:46 AM, Kalesh Singh wrote:
> On Thu, Oct 1, 2020 at 3:24 AM John Hubbard <jhubbard@nvidia.com> wrote:
>> On 9/30/20 3:21 PM, Kalesh Singh wrote:
...
> The bulk of the test time comes from setting and verifying the byte
> pattern in 1GB
> or larger regions for testing the HAVE_MOVE_PUD functionality. Without testing
> 1GB or larger regions the test takes 0.18 seconds on my x86_64 system.
>
> One option I think would be to only validate to a certain threshold of the remap
> region. We can have a flag to specify a threshold or to validate the
> full size of the
> remapped region. I did some initial testing with a 4MB threshold and
> the total time
> dropped to 0.38 seconds from 1:12 minutes (for verifying the entire
> remapped region).
> The 4MB threshold would cover the full region of all the tests
> excluding those for the
> 1GB and 2GB sized regions. Let me know what you think.
>
That sounds beautiful.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-10-01 18:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:21 [PATCH 0/5] Speed up mremap on large regions Kalesh Singh
2020-09-30 22:21 ` [PATCH 1/5] kselftests: vm: Add mremap tests Kalesh Singh
2020-10-01 7:24 ` John Hubbard
2020-10-01 15:46 ` Kalesh Singh
2020-10-01 18:36 ` John Hubbard [this message]
2020-09-30 22:21 ` [PATCH 2/5] arm64: mremap speedup - Enable HAVE_MOVE_PMD Kalesh Singh
2020-09-30 22:21 ` [PATCH 3/5] mm: Speedup mremap on 1GB or larger regions Kalesh Singh
2020-10-01 12:36 ` Kirill A. Shutemov
2020-10-01 16:40 ` Kalesh Singh
2020-10-01 18:10 ` Kalesh Singh
2020-09-30 22:21 ` [PATCH 4/5] arm64: mremap speedup - Enable HAVE_MOVE_PUD Kalesh Singh
2020-09-30 22:21 ` [PATCH 5/5] x86: " Kalesh Singh
2020-09-30 22:32 ` [PATCH 0/5] Speed up mremap on large regions Kirill A. Shutemov
2020-09-30 22:42 ` Lokesh Gidra
2020-09-30 22:46 ` Joel Fernandes
2020-09-30 23:03 ` Kalesh Singh
2020-10-01 12:27 ` Kirill A. Shutemov
2020-10-01 15:59 ` Kalesh Singh
2020-10-02 0:09 ` Lokesh Gidra
2020-10-02 5:35 ` Kirill A. Shutemov
2020-10-02 6:39 ` Lokesh Gidra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49725bf8-edde-0773-ade3-6e2d0d380b34@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=bgeffon@google.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christian.brauner@ubuntu.com \
--cc=dave.hansen@intel.com \
--cc=frederic@kernel.org \
--cc=gshan@redhat.com \
--cc=hnaveed@wavecomp.com \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=joelaf@google.com \
--cc=justin.he@arm.com \
--cc=kaleshsingh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=lokeshgidra@google.com \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rcampbell@nvidia.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=sandipan@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=sjpark@amazon.de \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yezhenyu2@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox