From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906C2C0015E for ; Tue, 15 Aug 2023 21:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEB58940030; Tue, 15 Aug 2023 17:02:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9B5B8D0001; Tue, 15 Aug 2023 17:02:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62BB940030; Tue, 15 Aug 2023 17:02:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C251C8D0001 for ; Tue, 15 Aug 2023 17:02:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 80957160154 for ; Tue, 15 Aug 2023 21:02:11 +0000 (UTC) X-FDA: 81127561662.03.F879175 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 8B0E31C0019 for ; Tue, 15 Aug 2023 21:02:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bqt6Z6qZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692133328; a=rsa-sha256; cv=none; b=JEBxkMToF5fDdnknKbHoTIJta8CmFQeOggMdr+mPIhz0mCqhIejY6aKamhz6N2txo9ToIg cnRLt6wTIu0SvtKwsGGEbTx/UHsEB59mHml30vSsHgVBQfStuQ9iFIACVa+eSxcqZPlQ03 rhlPNNFZjxurAqtY0RyhoLNuDQeJWag= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bqt6Z6qZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692133328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qVDcaAEMVdIG5TRpfoE9KkvgEeerSr7AgJFNzqhB4sc=; b=cfrHHYyJdBha5SKg0QyVT8zroE6OWrmGodO8r60yaMhYCVzgrJ9CRdEyAlYrViUUWDLbJP dZbPaVuNOHtFhUKJ+ZA0Kt1+M8xQvNsNlqSkLvm1JrLiQ1NAZn5y2PLDXUyAZONOykapl1 MHThVdfv9T3M47azTklp8Rt3z8c2dm0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F0D665752; Tue, 15 Aug 2023 21:02:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFEC6C433C9; Tue, 15 Aug 2023 21:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692133326; bh=cyy9dMmZpCKf0kwV7gSnc6iwwZGFtG1+94Uv3PmsMU4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bqt6Z6qZREPwPFwBqdMZB2kGJkkZypRmE9bwxc/FX8l6pnZwrXqDF3bNuPrbnNof+ Zbk1pTJchswaB67AS8Nj1Fds9Y0G2RQA9I45EqR3l7nWywG7yppNaZroed7qaeEEAZ 33mA8BkQ+gc93Br35uBf/91KWeipdjt2HZOsVUK2Ux2Vxd9ZCygGsOHP3hrhNO5jUy 2VYsEWdiWM2RoeaISTVoMt6DhY/pcivI+RFTbrq8SXdIqqMaMX6HRMevIxKwi4XifW 48vwEdEv9oFNrQbuyJP6Pq9qrvMreh/m17TY8MRUHS9jLxuBTcpwnJXfg4G673G6/2 25g2vLFO2qOfA== Date: Tue, 15 Aug 2023 22:01:57 +0100 From: Mark Brown To: "Edgecombe, Rick P" Cc: "corbet@lwn.net" , "ardb@kernel.org" , "maz@kernel.org" , "shuah@kernel.org" , "Szabolcs.Nagy@arm.com" , "keescook@chromium.org" , "james.morse@arm.com" , "debug@rivosinc.com" , "akpm@linux-foundation.org" , "catalin.marinas@arm.com" , "oleg@redhat.com" , "arnd@arndb.de" , "ebiederm@xmission.com" , "will@kernel.org" , "suzuki.poulose@arm.com" , "oliver.upton@linux.dev" , "hjl.tools@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "paul.walmsley@sifive.com" , "aou@eecs.berkeley.edu" , "palmer@dabbelt.com" , "linux-doc@vger.kernel.org" , "kvmarm@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-arch@vger.kernel.org" Subject: Re: [PATCH v4 21/36] arm64/mm: Implement map_shadow_stack() Message-ID: <496b9d81-c4c8-471d-9be0-3a0c8fbab436@sirena.org.uk> References: <20230807-arm64-gcs-v4-0-68cfa37f9069@kernel.org> <20230807-arm64-gcs-v4-21-68cfa37f9069@kernel.org> <8a7bb14f808ab9da413c11f281041375d9a54b01.camel@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dU1pnpOPTrUAVGE+" Content-Disposition: inline In-Reply-To: <8a7bb14f808ab9da413c11f281041375d9a54b01.camel@intel.com> X-Cookie: Darth Vader sleeps with a Teddywookie. X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8B0E31C0019 X-Stat-Signature: hx4mpf9gbng7wuwrnbwb3g3wg5m5azi3 X-HE-Tag: 1692133328-69985 X-HE-Meta: U2FsdGVkX1/2Pj+OzDPoBJi3MxXh8VNytfiz9FYBe8rLc4w+qCCKdh2PnPwkF12P29I5Yd2RdTohwfvCU1CEFpe5LYKhPDr7J6ZVjHgRXTNoCoWEhDhvuV4Koz+a5s4WCPl53vyB1ZAUivRUKeKt3chftjxS/RQnaOIWRl6npL+2lFQ3Chhetbn2RUAWc6z4JrTx+93b8NgddR23xwh/UEyTWdgjAEmTts49sxSxvYgJaScDpcLd/3aAEObv6QKfzXUvhHdCM5uSuMND5PzxvbqNvYzNfDaqKuiGnLmJthQ1dcu9OMBNQBm2b6PuZR2M7ljOrnwhyBThaa6s8Lt0kkanLLVrcjEe5z8zAqHHuZiskdaud2xTmIF77NgotnA9vUACEfuD98ouo338GBiinTKOrO0K46yNdB0NrfPSRullhd2wmYEQvoGdgUBaiSLcP4FTbPKgR7bD1VsmDiz9Og2y+kC11d4o3iGO9z73QqxxUVFUc9/grrOKyYygsJdrxjAkTIgsLfmS1zolC2qWx3TcZmh4KaUEQjab9sSa0iqLmEaCIklDWhj4vEwgF8y6mwwb+D8eyOymTg3VSvsSzur1AJJcC7dFD3F7AGkOszHOObAmr3vpbr7EOr92p7msZFxBYxyQ1GWGwcUxfNpdfreaYe358+KNvSvQkSDhIHtRvDA2GZo5rFj18hpgRVKgttYwxlp1gY12wXAmgO2EHaFtsOtTIse63GXGdGegUJEtqQ11z4YW3sH3sNJNSfYvZ67q5ZfZy2DhYbZUK0NeqiGWD7IIVb3wHlNLGCv5PslxIcpyQu+gg/7OTf5r/vuf19peyQ8t+B4crrWgWxiufgfoJo/aWHfhCFCNPz0Pk1ATrVmfH+dtRcTrRckRbvYpDLwBevSCSgHB21jomJRwVwE+CZwoByLlOUQyDh/3y5Cwj5ZX/Sd1zQw7Hs+6Dt7JwVm6UdF+rFuwCzsnZzI Qbv852y2 Yd1zsIp7/cucBRgDQOiFNWDBMWgoF3JvtakrLDCAEvgrSsUU3f+pf4bZfSHS4xJ2dTU5bOFEhucO1CwTElAXq5D1nEn/XpkKatpQyl9jbTk7wAWl5CDZgeIhm0gD37FAOxHuoRxY9r98/2ZWOgMpeR3hah0mi+Nj7ktxREYM1b7OK6Dc5MZWPPw5XxtuEXcRomzOP886oWKTh7e3e6YZ3vgne7zLmSvKCXOIe/omlUhHFqJtoRYh+UGvmNf3JXK5LQl1kxW+Hobxaoz71lBjYH3uFcvkQFC/JqXk16MSDJdW/l77e3I3HyQRirdjsTqp/FgqLVujcyvOHuE7hK4DUOAeH1TsULrWw2VyKkJk5Tx+nQTSZPM5JvQwrAgkgJ/UcaV9+tGor31/67v9Phs6YnvS7U2wZZnOs5CvIzmChMRnyuWbJrgG2gdx1714h7uW9qAiqiOhGEuzBWlph//8JsnhNxesqLIRz4TR/s1r3S+6nhvfcCzSburKAFhtQrsSfacpR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --dU1pnpOPTrUAVGE+ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 15, 2023 at 08:42:52PM +0000, Edgecombe, Rick P wrote: > On Mon, 2023-08-07 at 23:00 +0100, Mark Brown wrote: > > +=A0=A0=A0=A0=A0=A0=A0if (flags & ~(SHADOW_STACK_SET_TOKEN | > > SHADOW_STACK_SET_MARKER)) > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return -EINVAL; > Thanks for adding SHADOW_STACK_SET_MARKER. I don't see where it is > defined in these patches though. Might have been left out on accident? I added it to the dependency patches I've got which pull bits out of the x86 series prior to you having rebased it, the ABI bits are mixed in with the x86 architecture changes which I didn't feel like dealing with the rebasing for so I pulled out the ABI portions. I'll resolve this properly when I rebase back onto the x86 series (ideally after the next merge window it'll be in mainline!). For these that'll probably boil down to adding defines to prctl.h for the generic prctl API. --dU1pnpOPTrUAVGE+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTb58UACgkQJNaLcl1U h9Bc4Af/Xi/XuQ8BuGwUsA64+0G15WTAgvnaEr6smr1t4oyMFuQMUHjd7iBjOThm PV/FOTfozLwcOPBbBklofnYUDiI04WMQKwGbdr7Zi1+GFR6+EN7hirIWkuuvQlL5 NKBQjm5eyQL/yYYt4BJ6hRDbRNoCsRtT6zZHwZJpMXiv+nVQBOZlasA6cZ0TgBO3 HkA5PardmuhDrB+yavSIm9rV91v8lOpnDP5q3yF8ShV6Il1n6n8cY4FsnTaXQfpk dYkB1QCKNAiqGdIWRgeV11iWfrslrXztH2Z94tOjqgbLti1lmf9XEIoX4Wk9Juu8 JF1NdrdhL8X0X+5VS1Mt4bHie2rizQ== =r3Gb -----END PGP SIGNATURE----- --dU1pnpOPTrUAVGE+--