From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64690C49EAB for ; Tue, 5 Nov 2019 10:07:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 290F421A4A for ; Tue, 5 Nov 2019 10:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AtEtacNh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 290F421A4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B5CF76B0003; Tue, 5 Nov 2019 05:07:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0DB86B0006; Tue, 5 Nov 2019 05:07:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A23126B0007; Tue, 5 Nov 2019 05:07:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 90CB96B0003 for ; Tue, 5 Nov 2019 05:07:46 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 52CB7824999B for ; Tue, 5 Nov 2019 10:07:46 +0000 (UTC) X-FDA: 76121797332.26.pan95_43cccef3d8c1a X-HE-Tag: pan95_43cccef3d8c1a X-Filterd-Recvd-Size: 3858 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Nov 2019 10:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572948465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+p6MzjaCDgcAgk98VJBsyJP1N813kTt9VSOvi9TO8ZM=; b=AtEtacNhCGs/V+NferlO1/shjJfbhz2PbMW6OdFt8ZF9drWYGHwBGtr9zaYdudIravRdGn i8tpp6F/5e6KgedG7vOwU/acScGDolB0nPn1SBy0RoJPR5EThKoreLJWr6MZiza4EaA18h EK6AidkZu3RIUft47VL+97ULBvDiEKw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-M3qGGrxpM7GVcLI_o98zVQ-1; Tue, 05 Nov 2019 05:07:41 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F4EE800C73; Tue, 5 Nov 2019 10:07:39 +0000 (UTC) Received: from [10.36.117.253] (ovpn-117-253.ams2.redhat.com [10.36.117.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id A429561069; Tue, 5 Nov 2019 10:07:35 +0000 (UTC) Subject: Re: [PATCH v3] mm/memory_hotplug: Fix try_offline_node() To: Masayoshi Mizuma Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Tang Chen , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Keith Busch , Jiri Olsa , "Peter Zijlstra (Intel)" , Jani Nikula , Nayna Jain , Michal Hocko , Oscar Salvador , Stephen Rothwell , Dan Williams , Pavel Tatashin References: <20191102120221.7553-1-david@redhat.com> <20191105012049.x2k4v2xizd2tim5b@gabell> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <495a43af-befb-91f9-0097-9f0b449ff632@redhat.com> Date: Tue, 5 Nov 2019 11:07:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191105012049.x2k4v2xizd2tim5b@gabell> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: M3qGGrxpM7GVcLI_o98zVQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.11.19 02:20, Masayoshi Mizuma wrote: > 5.4-rc5 with this patch works for memory-hotadd and remove, thanks! > Please feel free to add: >=20 > Tested-by: Masayoshi Mizuma >=20 > Without this patch, memory hotplug fails as panic: >=20 > BUG: kernel NULL pointer dereference, address: 0000000000000000 > ... > Call Trace: > remove_memory_block_devices+0x81/0xc0 > try_remove_memory+0xb4/0x130 > ? walk_memory_blocks+0x75/0xa0 > __remove_memory+0xa/0x20 > acpi_memory_device_remove+0x84/0x100 > acpi_bus_trim+0x57/0x90 > acpi_bus_trim+0x2e/0x90 > acpi_device_hotplug+0x2b2/0x4d0 > acpi_hotplug_work_fn+0x1a/0x30 > process_one_work+0x171/0x380 > worker_thread+0x49/0x3f0 > kthread+0xf8/0x130 > ? max_active_store+0x80/0x80 > ? kthread_bind+0x10/0x10 > ret_from_fork+0x35/0x40 >=20 > - Masa Thanks a lot for testing! --=20 Thanks, David / dhildenb