linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Tang Chen <tangchen@cn.fujitsu.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Keith Busch <keith.busch@intel.com>, Jiri Olsa <jolsa@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Nayna Jain <nayna@linux.ibm.com>, Michal Hocko <mhocko@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Dan Williams <dan.j.williams@intel.com>,
	Pavel Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH v3] mm/memory_hotplug: Fix try_offline_node()
Date: Tue, 5 Nov 2019 11:07:34 +0100	[thread overview]
Message-ID: <495a43af-befb-91f9-0097-9f0b449ff632@redhat.com> (raw)
In-Reply-To: <20191105012049.x2k4v2xizd2tim5b@gabell>

On 05.11.19 02:20, Masayoshi Mizuma wrote:
> 5.4-rc5 with this patch works for memory-hotadd and remove, thanks!
> Please feel free to add:
> 
>      Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
> Without this patch, memory hotplug fails as panic:
> 
>   BUG: kernel NULL pointer dereference, address: 0000000000000000
>   ...
>   Call Trace:
>    remove_memory_block_devices+0x81/0xc0
>    try_remove_memory+0xb4/0x130
>    ? walk_memory_blocks+0x75/0xa0
>    __remove_memory+0xa/0x20
>    acpi_memory_device_remove+0x84/0x100
>    acpi_bus_trim+0x57/0x90
>    acpi_bus_trim+0x2e/0x90
>    acpi_device_hotplug+0x2b2/0x4d0
>    acpi_hotplug_work_fn+0x1a/0x30
>    process_one_work+0x171/0x380
>    worker_thread+0x49/0x3f0
>    kthread+0xf8/0x130
>    ? max_active_store+0x80/0x80
>    ? kthread_bind+0x10/0x10
>    ret_from_fork+0x35/0x40
> 
> - Masa

Thanks a lot for testing!

-- 

Thanks,

David / dhildenb



  reply	other threads:[~2019-11-05 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02 12:02 David Hildenbrand
2019-11-05  1:20 ` Masayoshi Mizuma
2019-11-05 10:07   ` David Hildenbrand [this message]
2019-11-06 23:14 ` David Hildenbrand
2019-11-08  3:58   ` Andrew Morton
2019-11-16  0:08     ` Andrew Morton
2019-11-16  0:12       ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495a43af-befb-91f9-0097-9f0b449ff632@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jani.nikula@intel.com \
    --cc=jolsa@kernel.org \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=msys.mizuma@gmail.com \
    --cc=nayna@linux.ibm.com \
    --cc=osalvador@suse.de \
    --cc=pasha.tatashin@soleen.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tangchen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox