From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40E3C7115D for ; Fri, 20 Jun 2025 09:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8065D6B0092; Fri, 20 Jun 2025 05:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6E36B0093; Fri, 20 Jun 2025 05:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C5376B0095; Fri, 20 Jun 2025 05:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5B9016B0092 for ; Fri, 20 Jun 2025 05:37:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F0974803D8 for ; Fri, 20 Jun 2025 09:37:33 +0000 (UTC) X-FDA: 83575276386.21.E0122EC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 949BB1C0008 for ; Fri, 20 Jun 2025 09:37:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uPTauNI1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VtQWQQlk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uPTauNI1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VtQWQQlk; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750412252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BBJFHILD9Do9Wn7lKr2d+o9XPVjgGjFz9Sr+qBv9zHA=; b=odXl9kraLqmbwxgZ0QI0ssJNkPGC2NwUNsPJHfMjmTlJ1jeftHyZpJL4nJNmM78wnFDIPC uhtxik6WHbIgctmZq2/EvNZhyEzeaBh83MSIW2P/1BKnxlKtWCDA5UFa7K0TR2R+Fx/txe s6IgkWGl1LT8KibcMfA9w9ZFoANABYE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uPTauNI1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VtQWQQlk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uPTauNI1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VtQWQQlk; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750412252; a=rsa-sha256; cv=none; b=YO4v7MNlr15uBDMA2yhr8dE7xyiYDeMbwfhUn5KglqL3UUVlriQrMup3+elXvF2Fx4oh6g yMtFPgn/ls+g9ONB5BgQmwk+8RWnA92sFF8qeQcn6bvCUd2lcXx0SDdfvJ+/a7dD+Qbphp 6ZVabSf7gXfnTOIL96IX8djFI5xydVc= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D7261F390; Fri, 20 Jun 2025 09:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750412249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BBJFHILD9Do9Wn7lKr2d+o9XPVjgGjFz9Sr+qBv9zHA=; b=uPTauNI1tTsikoj3IwxJxtdH95u87Cg7A2OW+M52sjjnJcwW6XUQ2pB2yo6vzPFPFCy52H Y+09nt2ZtZqDKyWdX+o0josPpDvbyJdtqy63D7Rix686PRGXcGYSTjvM4/qmK7O0VZwmAw L07icR7jBUvf3+sAU4jwImXUlSv4B70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750412249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BBJFHILD9Do9Wn7lKr2d+o9XPVjgGjFz9Sr+qBv9zHA=; b=VtQWQQlksryJCVZkh/4Q6dSyWH5Ck/2oJVOfb/r9PH1C+bBKNUKANvTVWrGiZUqenHgBDQ ++zMLrYNiKIAYNCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750412249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BBJFHILD9Do9Wn7lKr2d+o9XPVjgGjFz9Sr+qBv9zHA=; b=uPTauNI1tTsikoj3IwxJxtdH95u87Cg7A2OW+M52sjjnJcwW6XUQ2pB2yo6vzPFPFCy52H Y+09nt2ZtZqDKyWdX+o0josPpDvbyJdtqy63D7Rix686PRGXcGYSTjvM4/qmK7O0VZwmAw L07icR7jBUvf3+sAU4jwImXUlSv4B70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750412249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BBJFHILD9Do9Wn7lKr2d+o9XPVjgGjFz9Sr+qBv9zHA=; b=VtQWQQlksryJCVZkh/4Q6dSyWH5Ck/2oJVOfb/r9PH1C+bBKNUKANvTVWrGiZUqenHgBDQ ++zMLrYNiKIAYNCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D855213736; Fri, 20 Jun 2025 09:37:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OHp8NNgrVWgQdgAAD6G6ig (envelope-from ); Fri, 20 Jun 2025 09:37:28 +0000 Message-ID: <49455248-04b5-465e-9c76-b5dfbe6ac329@suse.cz> Date: Fri, 20 Jun 2025 11:37:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer To: Shivank Garg , Matthew Wilcox Cc: seanjc@google.com, david@redhat.com, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev References: <20250618112935.7629-1-shivankg@amd.com> <20250618112935.7629-4-shivankg@amd.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 949BB1C0008 X-Stat-Signature: 3uajacjf6f5kexfq6jq8tkdcf97tiiid X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750412251-989423 X-HE-Meta: U2FsdGVkX1+9Tm7Ln/N0TFn/ZHq/xaEaS70Wlf9nU/5pMilEn0bWD5ZEgZOBegIfQ15IB/HNvpc4I9grqIiO7EjMi/ve6PBjalnkDtZQr8KNl6h6yaDHnPQuRNOUfEyRlmk5+yN7NkfJiAmcAgXKVpXLHlIeG22Lds9iQtlHqpNqL037d4432ZoSR/dVQAN+1CUOeM1sGOzh/AOkK7s7mUz65e69QjJd2P+sUy7rom2E/wfzPNsKy+/CmYAR7hgXlYJsE36HRPzVpV6iU/5737TBk4TMDzLmK5lHfaOvz15LMH9+6Aky0D5tHTHfXnFSatnf9A1KRpbDe3m/ecsTCdGyvWx0wIWu0WlMtq5+LjvFThIVn6qgccrIMoCz7/3Xf260JVoFML913amGjH2oGfjeLgmPyKarlUHSqF3pFOisMtZIACTlOlEyFwuAeaNVh2W5SzwPGpjQooAQCCcbM2pEBC2kpBlia7tb/5uaI3Smgum8Dj3Gy/LOYau454x2jWh460ZfzTAI3sGhNy50mh5End5ly/Dy0Mzb1XVbP0/lNKql7rXKdsmLhfyo+N4gkzTWg3EJfh3ucyQ20OrJuDHju918DgD+OId9TxmqDEvBbbJKyV3XXoTSN5RrHCuQ6Alv2AKPGIS0rPRf3VhSFNDvDoJ8hm+uUgYu7S/yDnYikBlivAq2tjevYPeRrpO9w+astvAJrl2xZmi80wODIONVDZI8M+ZiIilc0QG0hUWdVoUWfijwhUjACSlp6QyKMPtdCGn/DHQfTCo+pll1ZMyYqKe2qWALrz799fWgK1wSN1I8PXtpggRCVvFvAFeI8HXbRM3rKZ+2kxGQYJz0BKlpZ7xINrDP63nKtwii+z6fTHTIabJRm2yOsBtDSQH92UhjfqzmlFlOn9h1YEwE6JQABjohQjIPg+t68wtj5+zOW4TpJkp/PAZ8E9NXCwy0LuREs8BhiLIiK0h/Vxo Et5OazW/ fBhfrCP2yM9MjC+W89lcGfhQnSnBgpK8dVHrleXpFEchoNbsjhAydTHZUbo1ktmywUzu0IeXnKQuKxFw56GCguFrwm2qrQrNGVO6eeOQ96t7F9dg22Hf15reV+2nxqcN692uE/V+kPiPeuAwwSjvB4x7Wyf5t+v9Xo03/FOC+hXLdtT6J3mCu+brYw22MZdVqLZkkZ/5PV4uNmtyQ18aX0xQdv33+aBTo7icWSON2b9fx90U7DBOJOhUZ/XJwTmqRvkJTbRb147+hIpiPYCxslltxY6PK8FJY8UzF6eG6l83caAFV+YmZBVbnfSEhymazkgmT8Ra1n5cP9gOcM+vCzUIB5Vz6C0E+eSHF1mFwL0S7mI3N1vOtaL2IzJ/c/FPcpTt2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/25 07:59, Shivank Garg wrote: > > > On 6/19/2025 9:33 PM, Matthew Wilcox wrote: >> On Wed, Jun 18, 2025 at 11:29:31AM +0000, Shivank Garg wrote: >>> From: Shivansh Dhiman >>> >>> Add NUMA mempolicy support to the filemap allocation path by introducing >>> new APIs that take a mempolicy argument: >>> - filemap_grab_folio_mpol() >>> - filemap_alloc_folio_mpol() >>> - __filemap_get_folio_mpol() >> >> You don't use these APIs in this series, so I can't evaludate whether >> any of my suggestiosn for improving this patch would actually work. >> NACK. Introduce the APIs *with a user*. Come on, this isn't a new >> requirement. > > Hi willy, > > Thank you for the feedback. > > filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio(). > > filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used > to support the filemap_grab_folio_mpol(). Maybe they can be static then and don't need to be declared in the header. > Thanks, > Shivank