Re: [linux-next:master 6728/7105] mm/rmap.c:1413: warning: Function parameter or struct member 'flags' not described in 'folio_add_new_anon_rmap'

["Liu, Yujie" <yujie.liu@intel.com>]

On Thu, 2024-06-20 at 09:06 +1200, Barry Song wrote:
> > 
> > tree:  
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > master
> > head:   2102cb0d050d34d50b9642a3a50861787527e922
> > commit: 41bb9aa5f614423659ced668d0f1ff0c1da6552e [6728/7105] mm:
> > extend rmap flags arguments for folio_add_new_anon_rmap
> > config: arm-pxa910_defconfig
> > (https://download.01.org/0day-ci/archive/20240620/202406200059.tVU9
> > semU-lkp@intel.com/config)
> > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build):
> > (https://download.01.org/0day-ci/archive/20240620/202406200059.tVU9
> > semU-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a
> > new version of
> > the same patch/commit), kindly add following tags
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes:
> > > https://lore.kernel.org/oe-kbuild-all/202406200059.tVU9semU-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > > > mm/rmap.c:1413: warning: Function parameter or struct member
> > > > 'flags' not described in 'folio_add_new_anon_rmap'
> > 
> 
> Hi, Thanks very much for the report!
> 
> Would you test if the below patch fix the WARNING?

Thanks for sending the patch. It fixes the doc warning for me.

Tested-by: Yujie Liu <yujie.liu@intel.com>

> From: Barry Song <v-songbaohua@oppo.com>
> Date: Thu, 20 Jun 2024 08:57:55 +1200
> Subject: [PATCH] mm: fix the missing doc for flags of
>  folio_add_new_anon_rmap()
> 
> Fix mm/rmap.c:1413: warning: Function parameter or struct member
> 'flags' not described in 'folio_add_new_anon_rmap'.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202406200059.tVU9semU-lkp@intel.com/
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
>  mm/rmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 9b7310120ccb..df1a43295c85 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1390,6 +1390,7 @@ void folio_add_anon_rmap_pmd(struct folio
> *folio, struct page *page,
>   * @folio:	The folio to add the mapping to.
>   * @vma:	the vm area in which the mapping is added
>   * @address:	the user virtual address mapped
> + * @flags:	The rmap flags
>   *
>   * Like folio_add_anon_rmap_*() but must only be called on *new*
> folios.
>   * This means the inc-and-test can be bypassed.