From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51B2C7115B for ; Mon, 23 Jun 2025 05:32:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F27396B00A5; Mon, 23 Jun 2025 01:32:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFEEC6B00AB; Mon, 23 Jun 2025 01:32:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DED176B00AC; Mon, 23 Jun 2025 01:32:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE93B6B00A5 for ; Mon, 23 Jun 2025 01:32:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D9D4D161A57 for ; Mon, 23 Jun 2025 05:32:46 +0000 (UTC) X-FDA: 83585545932.26.87D6276 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by imf19.hostedemail.com (Postfix) with ESMTP id F03481A0005 for ; Mon, 23 Jun 2025 05:32:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="jO/BBkl9"; spf=pass (imf19.hostedemail.com: domain of shivankg@amd.com designates 40.107.223.79 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750656764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mWz3Tm7gqNGmXhZGN/HkQcvxu2N/bCCDPxnCx6Ijn1E=; b=JhD7O20xzQcMggPqBrGHiNUZ4cbKTb82hRRgQSxj0JvcTjZqkUkxr+6nIeTNcnIcLiqD1w eJaXLPJbj0U9VJVMWUtdJ6OxZGy1+FM7rcBAC4BXJLLN3ZLoeGXfJPBruIDDHFpfrSeq1I fuhdotvwZ9sE40EXWZWC20mNfKR4QVM= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="jO/BBkl9"; spf=pass (imf19.hostedemail.com: domain of shivankg@amd.com designates 40.107.223.79 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750656764; a=rsa-sha256; cv=pass; b=VKp9BgniyoCzhyaDJVDdWwQy5OVlWDqigKCigqa581l2OOysjUh8xt4K3pMGmNmNe9rm0w /OEMWNvajjksy+260E5KJVFjG6jLXtRP/QNG3uUbcGmjKwxIG7ORy6reKY4/dW9qOHqTdj TTrGZRcFNoDhYMCTqhjPZMLmuL5EyR8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IrS9F/palSfrCA7NymqY6vTF3rbn4iuH15pcBiXtCPPKteuPPpANlfczN+PnUSKGoYNJNpOEpAFFS+xlz+pk9jwrxuMfj5RibqIvz0Z+qAunj5Ci51G9xqNawjY0Hb1tyyqiEvxkNm2NdYEb4Sgg0BJgEcUDCDpa3h9plrG43bxkgf2zsCo36VaQyYrbVlippS8eHMmUHDEL8X90lUtyl7kc0fhtQvFJnBi8gRnaeeBIdyEMJ+WI+lODxhbg1YZf2uHxNgkDF9lGAqIRqeKBOEJsqBmiFZhofnkxx3pxIOEUMpvP2XzZjpQLqxIf9DwCsBFrgQXkZ32e3XQ0sa9upg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mWz3Tm7gqNGmXhZGN/HkQcvxu2N/bCCDPxnCx6Ijn1E=; b=Pgkda/CZAaaQEX/MXywCYWZBHmei1jcZn+TLdCiOtGmxP31Ot2uFC585ynXLImU1KIOhBIDoEBD+zamRFhEcMGFkc/VW1MwbxHN3ICME0P/rbZVl5C1tS+K36ioPKhILUi3WicevTZv66goINpPsFZs9oXWJea2YuJ2NWaTUNO7zFNiWsFypbDSZJHrIbASVUZ3HezQFdFRf1InXJu5ITF+qqy668/WBx4Ak2qOKxG/Vd3dWiJMzz8anBPZoWyIvs6OBnMdA6PEWfMXW9iS+n5hnMEW8Howhfvi/RucIGkUh9XI9M7sh+2nYXwlYzIx2uml3HM0xRdbVgv3yQICadQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mWz3Tm7gqNGmXhZGN/HkQcvxu2N/bCCDPxnCx6Ijn1E=; b=jO/BBkl9je2PRpHmfSKUt9RjH8mMOWgBV8cjlDh+liiCauOISzchI6HmbQ5SiwlbCD/kPqcwIxasBJH/L+ok901l0EIvWavJW4N0SylmWSJTwMqvptoOZIXXsRCbIf4Fh+ljFbXO6K0n5mLLl69fFDQZHUIAkxygnbDxi3SowJY= Received: from SJ5PPFF6E64BC2C.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::9aa) by DS7PR12MB6336.namprd12.prod.outlook.com (2603:10b6:8:93::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.22; Mon, 23 Jun 2025 05:32:38 +0000 Received: from SJ5PPFF6E64BC2C.namprd12.prod.outlook.com ([fe80::40bb:ae48:4c30:c3bf]) by SJ5PPFF6E64BC2C.namprd12.prod.outlook.com ([fe80::40bb:ae48:4c30:c3bf%8]) with mapi id 15.20.8722.031; Mon, 23 Jun 2025 05:32:37 +0000 Message-ID: <49404594-880d-4f48-a855-1066b295009d@amd.com> Date: Mon, 23 Jun 2025 11:02:26 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass To: Sean Christopherson , Mike Rapoport Cc: Christian Brauner , Vlastimil Babka , david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, viro@zeniv.linux.org.uk, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20250619073136.506022-2-shivankg@amd.com> <20250619-fixpunkt-querfeldein-53eb22d0135f@brauner> <20250619-ablichten-korpulent-0efe2ddd0ee6@brauner> Content-Language: en-US From: Shivank Garg In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0243.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:21a::6) To SJ5PPFF6E64BC2C.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::9aa) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PPFF6E64BC2C:EE_|DS7PR12MB6336:EE_ X-MS-Office365-Filtering-Correlation-Id: dc33c665-627d-4938-45cf-08ddb2175d2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YmEzZklJbmMvNFpZdjFTN25EZGhEa280ZkVha2o4Nnc0cWd1b2lqeFUxYkpO?= =?utf-8?B?aTlnUnRCMlJxd1NnRW10Zm1vd1dURnJlcGcxZzdFTmcyQW9DZi85TXJjZ240?= =?utf-8?B?cWI3OWFmakdvMGQrNU5wRHVmSmJlSVJqdVIrTjRia2xGbU9rYlE3amFqWUhK?= =?utf-8?B?MURCRTErY1dmQ0pkYkhlcXdUa2c5enViSmdKQlVlWW5RbUI2MmVvS1Z2SFVJ?= =?utf-8?B?N1hkeDYxd0ZHMlhRMnYrRVZ0RjFUWnRMclBZVnhUSjJXYW84eEJGVHNaSHdH?= =?utf-8?B?VVpNdTRUb1ZOclJQZWhmb2RmV0pralBTUzN1bUFhZHBIM1JmdStkcWJaN0h3?= =?utf-8?B?b1gySGh1UUZramVMWnM2cXNpU2R0Y1BBMWdFTnZWNWxLUVVIZTZ0cDJuZ1Ju?= =?utf-8?B?d2ZHc2R3M09IR1N4YjRoNlIyaC8rek15NGYyeDdIVnJBS0FZMytzZCt0ai9k?= =?utf-8?B?dGJtN3ZBS2lzTDNsais1MmdhWnNDc1J5aEpaMzVSUlZCNHZzUWk5SE5RL0pY?= =?utf-8?B?RmZGeDZWQkZnaUJxVmh4aFZqK21jdm44cUtCQ0oyNkczaDNPc2VBVGZabktJ?= =?utf-8?B?NFU4QitRbEgzbUlIc01La0owcU03bTJEMlNnTFF3b1hoWHMza1o0RzBTSmNQ?= =?utf-8?B?SDdneHoxZHliODVqZ1hYUVBnOGN5bGtnVENMQ2N0L2ludUlSQ28wQ2IrNmFX?= =?utf-8?B?RjZuTkl4UGpXSTgvWkRZRVpPcEZkdnpUdzNOYTJOaGVVTG1sb0szaWJFVkpj?= =?utf-8?B?NHlnZ3BzZXRySDJEakhyMHRJeEVIUmxnV2tBY2tWMlliMGl3aHVwdWVlMjU4?= =?utf-8?B?Q0ZLKzFmbTYvUllKQTkwOXNzQit6TmNReGZjd2piY0FtRjBHaUkxZ1UycnQv?= =?utf-8?B?L3hKaTRRand0NUlybk4yUDNuOXh0TzFGcEUvSG5lanpIRlBESHRUaDNQazRp?= =?utf-8?B?bnJzUFVyaEpWYXNlYnBCVGlRbmtsVXo4dyt1SE10MEh3SG82SzJRWHZaZ1Js?= =?utf-8?B?NTFuMFBuR2NIU2pGa0lWa2J5WWxIN0VmZ2I0UkxzRFhoVWVDOVZ5azhGRURT?= =?utf-8?B?ZGRrTW9rZ212Q1lhVEZBaHdIUG5uTXM4cjRRcHZVYm1OaGZXcXhRSjI1dFRB?= =?utf-8?B?TkdHU1FZMUlvWndSeHRNRlMvcHErRnJ4ZFd2Z0g1T2J3cW04ODU0dEthZCtv?= =?utf-8?B?dDNKaElLckFaYkdudGo5d0JEcDNreG1TK2kvN0E5RlZ2TkhLMysrWGFobHhB?= =?utf-8?B?Zi9lZ29FSVRPM2FHb3hFY0dnQUxQVGhwamI3eVRwR1NxcithV0FVc2hMbFdB?= =?utf-8?B?SmNYanRXaXNjb3VYaExLNDh2OVIrN0hhSEM5UVY1RHdaeitpMUNJV3lzODkw?= =?utf-8?B?ZkREOWhvSFBJa1FNdzlLTU1peHNSNE5OTEhTYjQyMGs1QkVLbkQ4YmgwZFVF?= =?utf-8?B?WCtPQVJ3VVgxWXpXblFsRWJQUkpHdkJqVllVSTdsWVJCSkpKUWNORjZSd2Iz?= =?utf-8?B?TXNjZ0xOMGFmK1pUM1R2VWZ1YUczZFdjU21NcWh2cExweGNHeElESEVpOXQ4?= =?utf-8?B?UzZZcHp1NnhEbEE4dFQ3dTVveHN0b2h1NGVjeVpCZzdZODkxRS94aUl5RFNx?= =?utf-8?B?Z3d3OElSNTlyS3AySHJXaEh2NUM0Vk5vdzRHa1JVY2xRSkVqd3g3ZWZVWllm?= =?utf-8?B?OVJxaU9iUktjSEo2SEw1N05WVGFtc1o2VUpqajR4TTlLL0tDMTlLTW52M012?= =?utf-8?B?WXFHSTFrbWNwSktlNEZaNFkwaS9YVXIrbDdkTEtjNkkrcDVXNGNrTldlbHRo?= =?utf-8?B?ckdaTXBFbHNVWDQwc2hZMFhTUnBlaUdtUlhWcUUwSDNtRGMxYXI2Z0ZwZkJD?= =?utf-8?B?L0xveG1KSDhZd3pxM2VDMTlSL1lmMloyT1pJZUJMKzVQYTVHam9QcHdyODJp?= =?utf-8?Q?QYbh4rLaDs0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ5PPFF6E64BC2C.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVUwQ2V1KzRtbHdoQlJrMHdFdkpjS1hWNDQ0MTcwRTJkdHplOXRMT245Z1lm?= =?utf-8?B?bFZRMUxYajdFdUZHL0MrSzBpNDdZKytad09NY3p1VHVtaUhnRHUxckhmaGpN?= =?utf-8?B?ZGp5YUNOaW0yd1ZIQnE3cGtockRCR0VFR1RxN2pzSllSSlBtWGhWb0NMSzJv?= =?utf-8?B?c1FTZ21YMkgrVzFoZUNkcmd5bTA5Y1l5T001MnVtV2Q0TDYwc3EwRWRLRzgz?= =?utf-8?B?cFFqV2NOL1QwVmozSkxhc0ZTMXd0NjJXRmt1cjhEcll0TDZmWkZ3MzlERkhC?= =?utf-8?B?d3ZVb2ZxT2d4VlQxaVhpMlZkTTltSnQvbkRNZ21CK3J4TFltTnV2WjV0SVFN?= =?utf-8?B?MGpnbGg1WkVxbHZ3THBPcVU2N0lzdlRMdkk3RDNIQ21oTUk5cXpQMnVScVJW?= =?utf-8?B?ZFowNU9CQXhodGY4MUM0VVFvQk5PTC8wVUJtaXRkdkk2a0xXVGgzb0VjRmVv?= =?utf-8?B?OGJWeWsrc3g1eTJRSmxwS25uTnZUNmVseEh1K3NVaGp3RktUSEo3TGtnbDBx?= =?utf-8?B?UWJzVTgxUjZhajBGaHZWZWVqZHd0R0RVS3pnZ1BIMlF2ZHl1cmN6UWEzUlZp?= =?utf-8?B?akNuKzRsTkQ4MHRhY2RKNkYzdUY1WVpJS0ZMK3lNR3AxNmppd1grc1ZUS1A3?= =?utf-8?B?Q0s1ZWtFNGh1RmNmVFlHc3Q2azBQR2FkN3lTeUlqbVdHZGJqeStDbUpVVG5i?= =?utf-8?B?Q2VZMi9ydlZNL2FZL0VJQktTNjEyY2tQdkdXUC9XTjZFZVVXZFhuT0MrOVRv?= =?utf-8?B?ZGUybkx3ZXlIWXhQcmYvbmVqanVIaHNCRWN4UjBWalIzY01HZkQxTVVHcEdL?= =?utf-8?B?OHAybDIzZnU3WUdlV3NYQzFZUmxIRzhGdENkM1YzRjJrVFNaUXp5QmREc0NT?= =?utf-8?B?dHMzbHNWenptM3plWkE4UTB2UXJvZ0tHY2ZIOU5rSTBrYU55bUZ4dnJ2clNG?= =?utf-8?B?VzRRSDJvdFByQk5rbkJQeXZJWXRhN2tPMnVqSFMwUDZ3V21oS1EwRFRBV2NC?= =?utf-8?B?aWQ4a2N6eDZxMERzVW9xeTEySkJoVEw2Y0UxUWx4ODhhL1lkY2EwQnJIbFhN?= =?utf-8?B?QXFKSE16Mm82WFJ6c2paNUpIQXlCVm9LVVppL0ZOZEhUWXVsWkFBSmI0aUU1?= =?utf-8?B?empwWmlJUGZJZTYxWlFkTDdwSElybzlhcTBvYkJ3K3Q3OFZZZmlTYzBPTW50?= =?utf-8?B?S2VaTXpZZVorSzEzOFBjUTVRY0UrRk5zTytEdVBkcHBnanhrNi90L2QrTmxS?= =?utf-8?B?cnRKNmZJbHdQak52MWZ5WTN2MmVNUThLaDk1SDFJeWwwU3lWT3lrTEMyMUhC?= =?utf-8?B?UGMzOE1UU1pzMmNuN0xVVE5RSVQvdnJINnhXUllwaGkzb01uVy9DdnFJV1Rm?= =?utf-8?B?M0FYL2luY2VKclN4WnkvM2IvUW5BQ3ZWdk9URmhYR0l1dnZNcTRtRG9UYUhm?= =?utf-8?B?UWk3VkVqT1AwRFVKbXpCY3lOV3NOcWF5a2JVWEVoakZhM2tNTkkzUEI3UEFH?= =?utf-8?B?aEo0M2tKZVk4SGNtaVZxQ3JuaVlobjc1ZDA2eVNLQTJWN0NPTSsyV09KSEU0?= =?utf-8?B?VUxQdWJNbGV3OXQ3TjZTbzJTZ09PZzNjOFZqZHA3Q0tmekZDVUROVVVDT3Fy?= =?utf-8?B?ZGhPeC9HZDdxVzRFbWgxUFVWVDgyeHFEV1lUZzBrL29ndUxGK1lMdEFVMFF1?= =?utf-8?B?QkQ5Nzk0Wlc5UVlYREhWaVBFbEZnYW9vNXFLR25YRzJSZEl5ZXg1YmZsZ1V2?= =?utf-8?B?ZXRDbzJVQ0k5M0JlL3pDcWRvMW1wVkxvU3RnbzhDUjhwellIZlBsSmRPajY5?= =?utf-8?B?SWk5Y1k0dmIzUk1zd21SbzBrVlhVSFdtOElBbDFwZE5GRnZHVmlJcHZzZmxz?= =?utf-8?B?Y2I5cmJMRFZSNkpBUFBZYXl6OXEvRjg0d3Q0Z0J3MjU2N3RYMC9UaUVzZXRI?= =?utf-8?B?YmtTZ3FyeGVrYlFZNzVjWDVjRk81ZERrd3ltbzlNdjBOcW1PRk5xZE4weWJK?= =?utf-8?B?aDRybWROam9aeDUzRFVycVljR05TeFBvWE9GdGNTYnllWjRwSnc3eFZpT1F1?= =?utf-8?B?bWlIM3dxY2kvRDU0djRBak9GdlhWU0JNcjBJZWlFZ1U0cXVrZzVwVnhKQktv?= =?utf-8?Q?L4dvfY0VZCszb4Dzfhm4kNKIz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc33c665-627d-4938-45cf-08ddb2175d2c X-MS-Exchange-CrossTenant-AuthSource: SJ5PPFF6E64BC2C.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 05:32:37.7338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t5mlB28exQY423Gl6iHlKnQoYF1Jxt77/Xa7zKIQHj+Vetup/18gEc1NbmTk5wcUY8sBqymlbjDGxK6I3XFcMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6336 X-Rspamd-Queue-Id: F03481A0005 X-Stat-Signature: 61h17aro681bzrycx46x68erkr1x5ifx X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750656763-409305 X-HE-Meta: U2FsdGVkX18p4NPkC1S3HU4HtVejp7BUmH7aChmBtQ2clGOr7P4HaHfRTelIs9DXfzJQrbWhHW5W90FGN+UqAy2hG3gJdVrAUWQwfMHkFMCAR/lTAmgkTH3FFgGs6Bhw+TY75VUx4Ex7K1nbv/JeSp8Trd14uAitJIfmxgFcj+blyTy/MoiX83FamrkQnXE6XouFNSqEYUs5tlDGrEulUNJUZOSs9h2EG2/j6LNuCcwvoJRRB8uq/H0Xl92TCu6vkklgSZUuGYzUPE28qAxZ4UR+/v5IKoOgKNJ/1tohfx9dY59FI0GvNuGqlXylHv2/ipg1mQHjXlGM1pkf0IR4CCsMdXOOhX621lXj6NgVf5nCEqFgiZQWYqt1oTvSVxKwSFls1BNJtmOxkp2lMxYY5YuRAVc8r/+hVnjArg+RYM8V4hUeHGUClSwG4fgvIGlCVt7qNN2ePAVpLihtI/Ja9uDUUZ0ZLqSDlyHTNn5mh/zP773mQmGj10tPZnqus9kmlBDubkiJY5Z+G+LEe8g5wjFwF+RpB18ErqSNsebjNZjkxVFlv6PCGwFayLIpnZAojmDAE0nwwFISEW0Dw3jfg2jTDyqPPro4VtMpwb1Fs7iputXL+HCv42MXmpaBCC+sfGXQflUcatN2oYZwz4aSODIcBegtCT09xvuBQ13Xvd9DDpih2ETUvBEpF5Wvz1GO+RtA/wkugAaw1P24WExHS2BU2ymk9hevWvuts/a96XFibij+5ck30B8zysT5OvNSRS3oAmORAhvrNFyfOFgYORCNGX8n0HWSk2sEdjdVa2JrHZgiEOlE3CVE0Wr6ZNZA+gLiQ01z6Uk4cKYAE0L+GG9rOhrCqR8sws+FAWNxprLJ6CA9GqjvtGRKiK3zpz56ziLB1l5tOZkK9YEpFCO6JkcXXRVpp+hvQIjdmezS4RKMj/uOKZAl/3WpTFyqv85GklucTFQ4PKU/r7uCwU2 m3hk9mky qT2iAppmqbcixghULr1siapzwh+kiIYq/cgPbVeVJqC3l5xTNMELWXUdJM9uu+pMvlcVQvzh6opJasRzVp666YnwVrxPraHMappt+OPaGumjVtadb0ZAV9vhOK948LaPmUZ/TCNpx6FfccuZteDzXC6OUv6MV4ByoX6yFgMmrgQjFHfsAB+RGMpKZHiEq3GadX8ypv+YlzHXR+7UpjsBULkFk4QoRNrOKm5gmplWAAw7f7m13EaxZisNnxt168fxfa6ua0rDmE6H8NiR3072KTt9h/P2TG5SAMMzEwAq5asZ2sZfm2RuR0Dk9j6f+9zeNc+3WI+rny3ubAErQ3f8nR5pwZpRcMkX3u4SruwaMRcLKi4zqrhCRdmboKIYm9172qTuRr59gsS9WPBFZ08xN81fTmgbVsVnKRBcSO6gIj8LuuRpkEg+Fn6q/n4OVjzg8JZ5yKqRAqnPcTk8bOMnzL0tQrSJcJoDlFbsDdB4V7CowtSaKPon1I7+U4VyD6RSqDrJYBmh/bssxzQPAfWlyM0+kBvTOk29T3P52w5P0MyeJhprERU2veb5lNvG1GFvIAz2E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/2025 8:32 PM, Sean Christopherson wrote: > On Thu, Jun 19, 2025, Mike Rapoport wrote: >> On Thu, Jun 19, 2025 at 02:06:17PM +0200, Christian Brauner wrote: >>> On Thu, Jun 19, 2025 at 02:01:22PM +0300, Mike Rapoport wrote: >>>> On Thu, Jun 19, 2025 at 12:38:25PM +0200, Christian Brauner wrote: >>>>> On Thu, Jun 19, 2025 at 11:13:49AM +0200, Vlastimil Babka wrote: >>>>>> On 6/19/25 09:31, Shivank Garg wrote: >>>>>>> Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create >>>>>>> anonymous inodes with proper security context. This replaces the current >>>>>>> pattern of calling alloc_anon_inode() followed by >>>>>>> inode_init_security_anon() for creating security context manually. >>>>>>> >>>>>>> This change also fixes a security regression in secretmem where the >>>>>>> S_PRIVATE flag was not cleared after alloc_anon_inode(), causing >>>>>>> LSM/SELinux checks to be bypassed for secretmem file descriptors. >>>>>>> >>>>>>> As guest_memfd currently resides in the KVM module, we need to export this >>>>>> >>>>>> Could we use the new EXPORT_SYMBOL_GPL_FOR_MODULES() thingy to make this >>>>>> explicit for KVM? >>>>> >>>>> Oh? Enlighten me about that, if you have a second, please. >>>> >>>> From Documentation/core-api/symbol-namespaces.rst: >>>> >>>> The macro takes a comma separated list of module names, allowing only those >>>> modules to access this symbol. Simple tail-globs are supported. >>>> >>>> For example:: >>>> >>>> EXPORT_SYMBOL_GPL_FOR_MODULES(preempt_notifier_inc, "kvm,kvm-*") >>>> >>>> will limit usage of this symbol to modules whoes name matches the given >>>> patterns. >>> >>> Is that still mostly advisory and can still be easily circumenvented? > > Yes and no. For out-of-tree modules, it's mostly advisory. Though I can imagine > if someone tries to report a bug because their module is masquerading as e.g. kvm, > then they will be told to go away (in far less polite words :-D). > > For in-tree modules, the restriction is much more enforceable. Renaming a module > to circumvent a restricted export will raise major red flags, and getting "proper" > access to a symbol would require an ack from the relevant maintainers. E.g. for > many KVM-induced exports, it's not that other module writers are trying to misbehave, > there simply aren't any guardrails to deter them from using a "dangerous" export. > > The other big benefit I see is documentation, e.g. both for readers/developers to > understand the intent, and for auditing purposes (I would be shocked if there > aren't exports that were KVM-induced, but that are no longer necessary). > > And we can utilize the framework to do additional hardening. E.g. for exports > that exist solely for KVM, I plan on adding wrappers so that the symbols are > exproted if and only if KVM is enabled in the kernel .config[*]. Again, that's > far from perfect, e.g. AFAIK every distro enables KVM, but it should help keep > everyone honest. > > [*] https://lore.kernel.org/all/ZzJOoFFPjrzYzKir@google.com > >> The commit message says >> >> will limit the use of said function to kvm.ko, any other module trying >> to use this symbol will refure to load (and get modpost build >> failures). > > To Christian's point, the restrictions are trivial to circumvent by out-of-tree > modules. E.g. to get access to the above, simply name your module kvm-lol.ko or > whatever. Thanks for the info. I have posted the revised patch with EXPORT_SYMBOL_GPL_FOR_MODULES: https://lore.kernel.org/linux-mm/20250620070328.803704-3-shivankg@amd.com Please review when you have a chance. Thanks, Shivank