From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAD5E7719C for ; Sat, 11 Jan 2025 01:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AED86B00A1; Fri, 10 Jan 2025 20:17:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85E7D6B00A2; Fri, 10 Jan 2025 20:17:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 726066B00A3; Fri, 10 Jan 2025 20:17:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 543F76B00A1 for ; Fri, 10 Jan 2025 20:17:21 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6BC5C01DC for ; Sat, 11 Jan 2025 01:17:20 +0000 (UTC) X-FDA: 82993407840.29.D59764E Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf24.hostedemail.com (Postfix) with ESMTP id B2E4F18000C for ; Sat, 11 Jan 2025 01:17:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="me/JjYTr"; spf=pass (imf24.hostedemail.com: domain of richard.henderson@linaro.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736558237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oFDqME3Q1nThGD1k29pkHgYDyzcQcez3iTxF/87K9DM=; b=O4ywNz3ikHhzC7zb3c+JVCpU4S0/e7819AD2eahA5EUcjnpvM8dP65iip5fqy5PTZ6QdyI ataMz+VsEwJ2SWr5S5O8gBih36kL3HWFjQ86IyF1sOfx9Y/GlVEhDsWzJqWoRr+6wgEf2V 63HPLWENRT7qHrdYkTQoRu9c6tvgmto= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="me/JjYTr"; spf=pass (imf24.hostedemail.com: domain of richard.henderson@linaro.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736558237; a=rsa-sha256; cv=none; b=ar3vClRrTork+7+u4rMqLww/25PWdV/Yf6tOuArP0QGVzNZY2YTsfoAlw+XfAbpCgCCMX4 P22wcIpK2qHU6LUSLz7eRa8eWRGVNJORMXfeUxT4lPNVsrK4ZikP/gz6pf66aZvxyfZ/Vj Lw+taqggU20XRyy6y5VkVvCBAA5g2qo= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21675fd60feso59729215ad.2 for ; Fri, 10 Jan 2025 17:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736558236; x=1737163036; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oFDqME3Q1nThGD1k29pkHgYDyzcQcez3iTxF/87K9DM=; b=me/JjYTrngGFL2GshwatDfbz6IGZXRTQEsgX/ZPDNv9m/BDGYsnpl6T0rKNb2d6wjB UnCJn9gRFX4/qInhxElGOwme6SFxaDj83lQOKMQ6LV0fKMBhTixxrFTIPXpiGkMEPAFV KNfX6B5RMUIq/OG6qGqgmD4JKnbuFnOiCCT0PEXiNQINCssZu63PlY2Nv5aznMbPq+U3 teF7eO6ge/HdMa2MOG36vO08GOtWJZdd91wXV7N94+sI7l7dpnXoiSbe0rY04gKDdiHe ez67PaEQePT6e1IMFyjfxkQOQgnYrBl0Vw0Om8zl9PRukffLrjnRtATnme3fXTdFvfsO UZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736558236; x=1737163036; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oFDqME3Q1nThGD1k29pkHgYDyzcQcez3iTxF/87K9DM=; b=s8iUYEVgyH2NhTrZRqBaA8eDq6n2nK5drQ7+dFQ5ouAKZmVOltetdolfIvtES0P+oN 5vFWof6t6XBnfxpi5DhShpPvN59QJJ/LEQOYk4bcWCwyARHf6fgl9AHq6LokeWeoR0Pv bowPIeG9yvSyENXoYErkGV2BYuXEFGPSKNr6XcgxiKKXEHv43Sx2zKn2cOzi+9NtXBzH jOZAU+u1BoB7V15nrMBCBSqUgjQf4UNDrp+MZJd0h7wBLg1xwxk3rW30XUgmATfXl7Jr YYAG/0PtTpCauowRmaW/52HcuNLh3O2QQVpGCWJ5fQkJYqltozjnGC+9OzNtYdUcI7F1 DIDg== X-Forwarded-Encrypted: i=1; AJvYcCVCZYAZ0GuN3YVZ5D+P7WVHm+h3EOl6/fNiFA55M3Uhv7YZbUGHgQbbVYNK62lPnq1DaklduBcGjQ==@kvack.org X-Gm-Message-State: AOJu0YxK41KvA1sR94gwu/GhTdjtC8Z/bsrbVuZJyvoG5NXRUH8kMGBE 3Ai8fGa36ZwcoUr9wpaEZOwLrPWA/ppgi9wpAlBzM7eAUo4meSK6kkLxwK/0KtI= X-Gm-Gg: ASbGnctJZq/GddmKWl1nJDl05268ZwGtyVJ3ttGHxcX9uiwwFkRIqIxJ8vF0bYwjfEI A+KdIXwKhgsmV7SXIqkiXN9nakwVm4e+H3+9aTbJTOf3+TPLAhqi9Vvv4RgihwuGvdGJ2TwEkxp ht7IrhEX37hISuUGyrW7AL7j6SrmhLdRfd9Uu70VKXl6lnFk8VrUMK5YRTr+kYXbb2c8spyBCPh HTen6ev8z9B5QbD3Fa4wv6FNgEA20v92vki9OgzspjYVfaKa+2rZ0BFvO5WZ092AUraVeFd05Zx stVkaal5YyFI7Jq1ux4c4ucayRVQyKA= X-Google-Smtp-Source: AGHT+IE452X910tVgFm5oJf0XtFxutdqQAAARDDjZaJsInDm3xqPn8tv471ky9X/6A5ID/0JjcVFfg== X-Received: by 2002:a05:6a00:3913:b0:725:e309:7110 with SMTP id d2e1a72fcca58-72d21f1ab41mr18362201b3a.5.1736558236255; Fri, 10 Jan 2025 17:17:16 -0800 (PST) Received: from [192.168.132.227] (76-14-228-138.or.wavecable.com. [76.14.228.138]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4056ac96sm2194946b3a.65.2025.01.10.17.17.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 17:17:15 -0800 (PST) Message-ID: <4931d683-bebd-4617-ac55-f40f578f2e18@linaro.org> Date: Fri, 10 Jan 2025 17:17:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support To: "Eric W. Biederman" , John Paul Adrian Glaubitz Cc: Arnd Bergmann , Matt Turner , Kees Cook , "Paul E. McKenney" , linux-alpha@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Cree , Sam James , "Maciej W. Rozycki" , Geert Uytterhoeven , Michael Karcher , Chris Hofstaedtler , util-linux@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev References: <20250103140148.370368-1-glaubitz@physik.fu-berlin.de> <24f03227-1b55-4e50-b6e9-7ac74fda2602@app.fastmail.com> <678ee681-12c3-4e79-a04b-495daf343846@app.fastmail.com> <82d33a2d-dffe-4268-a175-4536b3f9c07f@app.fastmail.com> <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: ykusjbin73oth9jfoh4iabscjug3hdh7 X-Rspamd-Queue-Id: B2E4F18000C X-Rspam-User: X-HE-Tag: 1736558237-134456 X-HE-Meta: U2FsdGVkX18+kMthVc+xy3DW6J/izP2wELItnDKgRKvZnaHZct+Bt61HAMzOuVAC0zYe7T9Yzdk4spgZFEShLJoPzfxyS8ew5q1ZHmAXxWtXBOS4Rra7/FacpG4KNVZSAUCA13BnrAjA3V8A904g/ZNmy3nxD3E0XboiZQ9LtyaEM2aiX6D20brXYXLxVyJyVPTbV18+3N2EOuadDCwUaUAGLd6gTuf0NqIvr53SQPVXWjhjRk+1YXJ+7lkYPc0w6YzIOIuF0Wn0s09MBf2Uc7oCxQlYTNRtX4sS+IhUwn7TstgeTfw0xXT69zR0TV6c0CPZP6pDS2wF0GUShrBnkFmvvcMTQoNrohRdREfH+j76Uol+vRhFb2F/aNixdwMmhAoQEbg/sa/DXJARa941d/rYdmY3NQR20tQOtOn6tdAitbASnsrDfkaRYiRwNeSTqXWjIpn538fwZwcBZislEO8KNaCGbOeUWoHUn1eD+yyR0ZmXAocdGXaSKhlV93FSQU65+oNrhZcTA+dvA+atUnLaphPxiILPiFlV73aei/cpZok1HGYrmxfaOBvQEjfwzbXhNgDKZ9TnfdQGd0/7qQ2bZ0KOPiGQxC983rq1PS4BOh6x/uXyxY/nWeGJJzctU27Xsz/L3qDG863YnpI/Gjkehjlozfdf1oGmfVdRDPw1WYUZCyzCOxrMQejt6NPT2+ZFtU2+0Aff68ZW7IiLIA+jpEW0VfuKGL/aX4ffweD/LLrZWBJHqUYQ4fgby0tK2LATeq7nWtTXRCsC0iE7heU4kEDrgKFf+4SECM4uh5izBfNeDoUwuwrLgos5ewueaZPVXVHpMcMwqFmxrP6C+eOaOlKEYlqg5ljnvhwWclrG1FQ0AxLEHp0OJ3ZW6UgfI4oXOc2YOV/nFlre7Cb8CbZOhElPb4EdJCLCfmaVY3HpAgSDQp9J2E4qKtPL2a5ObRwGPgnxoRl3QKgy52h LTEQs/6q b321i3+Qlt1ekpop8clw09i+Hde3laeY0X/86V4DN/OrgQZugcrsDFMgHQ7uK8haPCLJkZApy0D3AOU//KyuLS9bIlFW10TE8aCe5/GyEE7sBM3hskVtKSSw11StJMJJkWSzVONG4/0yo+gI5sX3q6113719KZe9p3mqxnML+B1SDq0yHRSU9SRqvwAhUkF70j7foIRh9Oxjw09hXYIGLh11eziJyiLIH4+RvN/mBuoyFbbhJKnmcc6f5m32OXZzRlXh2u0pi5d4NvXEOcbT8ED+BueoQweS8trDMEALCgmmUoowTM0IacGTaEBaFCfpdoXCP4mltNp5DHm8tds0FqnPvKiwGJIUFKuoXnOEff8NYFCNlNZvdhW97uO9U9jxcgLs7kcVhaljucwx16B/TR1sJ0Cz3ieHOExpbTTVeco0x9RlrRbr+3DsQXav3hRaSC/QZNiDPtYo0qtiY8DjQeEbVdx4N43DD30V3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/10/25 16:16, Eric W. Biederman wrote: > > Richard Henderson writes[1]: > >> There was a Spec benchmark (I forget which) which was memory bound and ran >> twice as fast with 32-bit pointers. >> >> I copied the idea from DEC to the ELF abi, but never did all the other work >> to allow the toolchain to take advantage. >> >> Amusingly, a later Spec changed the benchmark data sets to not fit into a >> 32-bit address space, specifically because of this. >> >> I expect one could delete the ELF bit and personality and no one would >> notice. Not even the 10 remaining Alpha users. > > In [2] it was pointed out that parts of setarch weren't working > properly on alpha because it has it's own SET_PERSONALITY > implementation. In the discussion that followed Richard Henderson > pointed out that the 32bit pointer support for alpha was never > completed. > > Fix this by removing alpha's 32bit pointer support. > > As a bit of paranoia refuse to execute any alpha binaries that hafe > the EF_ALPHA_32BIT flag set. Just to fail explicitly in case someone > somewhere has binaries that trying to use alpha's 32bit pointer > support. > > [1] https://lkml.kernel.org/r/CAFXwXrkgu=4Qn-v1PjnOR4SG0oUb9LSa0g6QXpBq4ttm52pJOQ@mail.gmail.com > [2] https://lkml.kernel.org/r/20250103140148.370368-1-glaubitz@physik.fu-berlin.de > Signed-off-by: "Eric W. Biederman" Thanks for cleaning this up. Reviewed-by: Richard Henderson r~ > --- > arch/alpha/include/asm/elf.h | 6 +----- > arch/alpha/include/asm/pgtable.h | 2 +- > arch/alpha/include/asm/processor.h | 8 ++------ > arch/alpha/kernel/osf_sys.c | 11 ++--------- > 4 files changed, 6 insertions(+), 21 deletions(-) > > diff --git a/arch/alpha/include/asm/elf.h b/arch/alpha/include/asm/elf.h > index 4d7c46f50382..50c82187e60e 100644 > --- a/arch/alpha/include/asm/elf.h > +++ b/arch/alpha/include/asm/elf.h > @@ -74,7 +74,7 @@ typedef elf_fpreg_t elf_fpregset_t[ELF_NFPREG]; > /* > * This is used to ensure we don't load something for the wrong architecture. > */ > -#define elf_check_arch(x) ((x)->e_machine == EM_ALPHA) > +#define elf_check_arch(x) (((x)->e_machine == EM_ALPHA) && !((x)->e_flags & EF_ALPHA_32BIT)) > > /* > * These are used to set parameters in the core dumps. > @@ -137,10 +137,6 @@ extern int dump_elf_task(elf_greg_t *dest, struct task_struct *task); > : amask (AMASK_CIX) ? "ev6" : "ev67"); \ > }) > > -#define SET_PERSONALITY(EX) \ > - set_personality(((EX).e_flags & EF_ALPHA_32BIT) \ > - ? PER_LINUX_32BIT : PER_LINUX) > - > extern int alpha_l1i_cacheshape; > extern int alpha_l1d_cacheshape; > extern int alpha_l2_cacheshape; > diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pgtable.h > index 635f0a5f5bbd..02e8817a8921 100644 > --- a/arch/alpha/include/asm/pgtable.h > +++ b/arch/alpha/include/asm/pgtable.h > @@ -360,7 +360,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) > > extern void paging_init(void); > > -/* We have our own get_unmapped_area to cope with ADDR_LIMIT_32BIT. */ > +/* We have our own get_unmapped_area */ > #define HAVE_ARCH_UNMAPPED_AREA > > #endif /* _ALPHA_PGTABLE_H */ > diff --git a/arch/alpha/include/asm/processor.h b/arch/alpha/include/asm/processor.h > index 55bb1c09fd39..5dce5518a211 100644 > --- a/arch/alpha/include/asm/processor.h > +++ b/arch/alpha/include/asm/processor.h > @@ -8,23 +8,19 @@ > #ifndef __ASM_ALPHA_PROCESSOR_H > #define __ASM_ALPHA_PROCESSOR_H > > -#include /* for ADDR_LIMIT_32BIT */ > - > /* > * We have a 42-bit user address space: 4TB user VM... > */ > #define TASK_SIZE (0x40000000000UL) > > -#define STACK_TOP \ > - (current->personality & ADDR_LIMIT_32BIT ? 0x80000000 : 0x00120000000UL) > +#define STACK_TOP (0x00120000000UL) > > #define STACK_TOP_MAX 0x00120000000UL > > /* This decides where the kernel will search for a free chunk of vm > * space during mmap's. > */ > -#define TASK_UNMAPPED_BASE \ > - ((current->personality & ADDR_LIMIT_32BIT) ? 0x40000000 : TASK_SIZE / 2) > +#define TASK_UNMAPPED_BASE (TASK_SIZE / 2) > > /* This is dead. Everything has been moved to thread_info. */ > struct thread_struct { }; > diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c > index 86185021f75a..a08e8edef1a4 100644 > --- a/arch/alpha/kernel/osf_sys.c > +++ b/arch/alpha/kernel/osf_sys.c > @@ -1210,8 +1210,7 @@ SYSCALL_DEFINE1(old_adjtimex, struct timex32 __user *, txc_p) > return ret; > } > > -/* Get an address range which is currently unmapped. Similar to the > - generic version except that we know how to honor ADDR_LIMIT_32BIT. */ > +/* Get an address range which is currently unmapped. */ > > static unsigned long > arch_get_unmapped_area_1(unsigned long addr, unsigned long len, > @@ -1230,13 +1229,7 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, > unsigned long len, unsigned long pgoff, > unsigned long flags, vm_flags_t vm_flags) > { > - unsigned long limit; > - > - /* "32 bit" actually means 31 bit, since pointers sign extend. */ > - if (current->personality & ADDR_LIMIT_32BIT) > - limit = 0x80000000; > - else > - limit = TASK_SIZE; > + unsigned long limit = TASK_SIZE; > > if (len > limit) > return -ENOMEM;