From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AC4C43334 for ; Wed, 29 Jun 2022 22:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8C0F6B0072; Wed, 29 Jun 2022 18:15:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3BF58E0002; Wed, 29 Jun 2022 18:15:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 903486B0074; Wed, 29 Jun 2022 18:15:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 826D56B0072 for ; Wed, 29 Jun 2022 18:15:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4F54A35223 for ; Wed, 29 Jun 2022 22:15:13 +0000 (UTC) X-FDA: 79632680106.30.B8B8BC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 720851C002E for ; Wed, 29 Jun 2022 22:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656540910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JfIp4/8d6FKNViDaImkd8XOnHcFGT6GmiXjgK1Qhx+g=; b=Cla+XRC2CGYt5+grjuInG8UO4kN3Cr2T6gD1i1maS231r1u3tHzDMQ28WY8Bz83wJrRat+ bs8gmL9VnGMTVDJzDKLWZ5weHWc6HwiA645pmvrQawIeGx+9ivaXce6EMWV43BZi8XSRbg sIam1t8N5iQGTcRYRfPTe4P6DtfKBaw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-507-7hSvA-CGN4WNOZI073tWiA-1; Wed, 29 Jun 2022 18:15:09 -0400 X-MC-Unique: 7hSvA-CGN4WNOZI073tWiA-1 Received: by mail-wm1-f70.google.com with SMTP id z11-20020a05600c0a0b00b003a043991610so404138wmp.8 for ; Wed, 29 Jun 2022 15:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=JfIp4/8d6FKNViDaImkd8XOnHcFGT6GmiXjgK1Qhx+g=; b=6dKMU54ln7DHdzYGEyWUdlLqxaRwYTFuJfSSydG0sTGCQNAxMhajrn9q8o7KHnPR/L IzsAeF9PNcsbr97cqRWyTEyBIolnQQuK3sjvO9oDM3oF/kT4WU3DoauDTWZcaalfXITa 0X6dDQGaBkhbb+t4yKIAMsN0vMmALOZpFsGmmG50t9SmO9+xaFaIXXhVPnCT8KNdSBW2 010Imufz8v026uSnZq3xR9uzkKidIboxkHzHlRAt0FYAVVORgwH/S3M4ZeOR82/SP1TN 0M1p1Q+NgsUwlNb7yjrU81d86V/k5aXjlOYgOMY6E9+AZsnpFsicxyLA958RX0bvrdrK VMpg== X-Gm-Message-State: AJIora+A0eO+xUJFAbQpII8NE9pYFZ4ZRl9dxHlXbn/JIfrECl59KxBi 73Pa/sVzbL4yI0IzRlK2iRoB+myyw/sTd8gDLgnnxsawIHmrdSmUGW2paSKo9yaNBWOcpjQXSBw mfkr22rQJpw8= X-Received: by 2002:a5d:5481:0:b0:21a:3573:def0 with SMTP id h1-20020a5d5481000000b0021a3573def0mr5049194wrv.28.1656540908360; Wed, 29 Jun 2022 15:15:08 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t5fcdInM+cviZFvBrEBaCvHGKr28RaqkJjmjlhZihtB4ptS3bDvlPUJ4iGFvCByQR4VNIvKw== X-Received: by 2002:a5d:5481:0:b0:21a:3573:def0 with SMTP id h1-20020a5d5481000000b0021a3573def0mr5049172wrv.28.1656540908120; Wed, 29 Jun 2022 15:15:08 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:e600:d4fa:af4b:d7b6:20df? (p200300cbc708e600d4faaf4bd7b620df.dip0.t-ipconnect.de. [2003:cb:c708:e600:d4fa:af4b:d7b6:20df]) by smtp.gmail.com with ESMTPSA id e20-20020a5d5954000000b0020fcaba73bcsm17891932wri.104.2022.06.29.15.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 15:15:07 -0700 (PDT) Message-ID: <49315889-96de-8e41-f8ee-dd5b33c5e1db@redhat.com> Date: Thu, 30 Jun 2022 00:15:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages To: Felix Kuehling , Alex Sierra , jgg@nvidia.com Cc: linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org, akpm@linux-foundation.org References: <20220629035426.20013-1-alex.sierra@amd.com> <20220629035426.20013-2-alex.sierra@amd.com> <575b48a6-e372-acda-9a7c-449f307a588c@amd.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <575b48a6-e372-acda-9a7c-449f307a588c@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656540911; a=rsa-sha256; cv=none; b=hNcd7+jCOpsdIdckT/18p4LNPpbLWLNfX9qHtOhYkOYwSCbGQ3ssMsbvSTqhsKI/jJrIeF EBbxofVC/IftKS9X6lCfZV9Thg3fBJCq0UuOpJhA+GhhsYQvCO/thv79qmlAIL3IX1UZ+C TYPwthSQ7gk8QY6dTerY0ot04rxtE3k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cla+XRC2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656540911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JfIp4/8d6FKNViDaImkd8XOnHcFGT6GmiXjgK1Qhx+g=; b=Ps5UBl822mFCXCxDL3WmoafHdE/aBP76/5lWtXhZLnLwTdC0lJ3lBYSxAXrYYgrYMZKO8h rpZFMxdaKFjLWxlWToN99YFuGD5aGgVN38Yr7+TbLixfGY0SYppupDKiVp3ZhrSuN+M9WC b89He/r6gavDOON9D6es30JCFqPlqDc= X-Rspam-User: X-Stat-Signature: oezzemhnf8cww13u77eregobcmpjm4to X-Rspamd-Queue-Id: 720851C002E Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cla+XRC2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1656540911-602310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.06.22 00:08, Felix Kuehling wrote: > On 2022-06-29 03:33, David Hildenbrand wrote: >> On 29.06.22 05:54, Alex Sierra wrote: >>> is_pinnable_page() and folio_is_pinnable() were renamed to >>> is_longterm_pinnable_page() and folio_is_longterm_pinnable() >>> respectively. These functions are used in the FOLL_LONGTERM flag >>> context. >> Subject talks about "*_pages" >> >> >> Can you elaborate why the move from mm.h to memremap.h is justified? > > Patch 2 adds is_device_coherent_page in memremap.h and updates > is_longterm_pinnable_page to call is_device_coherent_page. memremap.h > cannot include mm.h because it is itself included by mm.h. So the choice > was to move is_longterm_pinnable_page to memremap.h, or move > is_device_coherent_page and all its dependencies to mm.h. The latter > would have been a bigger change. I really don't think something mm generic that compiles without ZONE_DEVICE belongs into memremap.h. Please find a cleaner way to get this done. -- Thanks, David / dhildenb