Re: [PATCH][V3]Make get_user_pages interruptible

[Pekka Enberg <penberg@cs.helsinki.fi>]

Ying Han wrote:
> thanks Pekka and i think one example of the case you mentioned is in
> access_process_vm() which is calling
> get_user_pages(tsk, mm, addr, 1, write, 1, &pages, &vma). However, it
> is allocating only one page here which
> much less likely to be stuck under memory pressure. Like you said, in
> order to make it more flexible for future
> changes, i might make the change like:
>>>>>                         */
>>>>> -                       if (unlikely(test_tsk_thread_flag(tsk, TIF_MEMDIE)))
>>>>> -                               return i ? i : -ENOMEM;
>>>>> +                       if (unlikely(sigkill_pending(current) | | sigkill_pending(tsk)))
>>>>> +                               return i ? i : -ERESTARTSYS;
> 
> is this something acceptable?

The formatting is bit wacky but I'm certainly OK with the change.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>