From: Rik van Riel <riel@redhat.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 8/8] mm: add add_to_swap stub
Date: Sun, 23 Nov 2008 17:55:16 -0500 [thread overview]
Message-ID: <4929DF54.8050104@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0811232205180.4142@blonde.site>
Hugh Dickins wrote:
> If we add a failing stub for add_to_swap(),
> then we can remove the #ifdef CONFIG_SWAP from mm/vmscan.c.
>
> This was intended as a source cleanup, but looking more closely, it turns
> out that the !CONFIG_SWAP case was going to keep_locked for an anonymous
> page, whereas now it goes to the more suitable activate_locked, like the
> CONFIG_SWAP nr_swap_pages 0 case.
If there is no swap space available, we will not scan the
anon pages at all.
Hmm, maybe we need a special simplified get_scan_ratio()
for !CONFIG_SWAP?
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-23 22:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 21:53 [PATCH 0/8] mm: from gup to vmscan Hugh Dickins
2008-11-23 21:55 ` [PATCH 1/8] mm: gup persist for write permission Hugh Dickins
2008-11-23 21:56 ` [PATCH 2/8] mm: wp lock page before deciding cow Hugh Dickins
2008-11-23 21:58 ` [PATCH 3/8] mm: reuse_swap_page replaces can_share_swap_page Hugh Dickins
2008-11-23 22:11 ` [PATCH] memcg: memswap controller core swapcache fixes Hugh Dickins
2008-11-24 5:43 ` KAMEZAWA Hiroyuki
2008-11-24 6:15 ` KAMEZAWA Hiroyuki
2008-11-24 12:29 ` Hugh Dickins
2008-11-24 12:57 ` KAMEZAWA Hiroyuki
2008-11-23 22:43 ` [PATCH 3/8] mm: reuse_swap_page replaces can_share_swap_page Rik van Riel
2008-11-23 22:00 ` [PATCH 4/8] mm: try_to_free_swap replaces remove_exclusive_swap_page Hugh Dickins
2008-11-23 22:01 ` [PATCH 5/8] mm: try_to_unuse check removing right swap Hugh Dickins
2008-11-23 22:03 ` [PATCH 6/8] mm: remove try_to_munlock from vmscan Hugh Dickins
2008-11-23 22:53 ` Rik van Riel
2008-11-24 17:34 ` Lee Schermerhorn
2008-11-24 19:29 ` Hugh Dickins
2008-12-01 20:16 ` Lee Schermerhorn
2008-12-02 0:51 ` Hugh Dickins
2008-11-23 22:05 ` [PATCH 7/8] mm: remove gfp_mask from add_to_swap Hugh Dickins
2008-11-23 22:07 ` [PATCH 8/8] mm: add add_to_swap stub Hugh Dickins
2008-11-23 22:55 ` Rik van Riel [this message]
2008-11-24 13:49 ` Hugh Dickins
2008-11-24 13:53 ` [PATCH 9/8] mm: optimize get_scan_ratio for no swap Hugh Dickins
2008-11-24 14:11 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4929DF54.8050104@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox