From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4929D175.2000200@redhat.com> Date: Sun, 23 Nov 2008 16:56:05 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 8/7] mm: further cleanup page_add_new_anon_rmap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Andrew Morton , Lee Schermerhorn , Nick Piggin , linux-mm@kvack.org List-ID: Hugh Dickins wrote: > Moving lru_cache_add_active_or_unevictable() into page_add_new_anon_rmap() > was good but done stupidly: we should SetPageSwapBacked() there too; and > we know for sure that this anonymous, swap-backed page is not file cache. True, but ... > if (page_evictable(page, vma)) > - lru_cache_add_lru(page, LRU_ACTIVE + page_is_file_cache(page)); > + lru_cache_add_lru(page, LRU_ACTIVE); Then you will want to s/LRU_ACTIVE/LRU_ACTIVE_ANON/ here. -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org