From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -mm] vmscan: bail out of page reclaim after swap_cluster_max pages
Date: Sat, 22 Nov 2008 11:57:41 -0500 [thread overview]
Message-ID: <49283A05.1060009@redhat.com> (raw)
In-Reply-To: <20081122191258.26B0.KOSAKI.MOTOHIRO@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> Rik, sorry, I nak current your patch.
> because it don't fix old akpm issue.
You are right. We do need to keep pressure between zones
equivalent to the size of the zones (or more precisely, to
the number of pages the zones have on their LRU lists).
However, having dozens of direct reclaim tasks all getting
to the lower priority levels can be disastrous, causing
extraordinarily large amounts of memory to be swapped out
and minutes-long stalls to applications.
I think we can come up with a middle ground here:
- always let kswapd continue its rounds
- have direct reclaim tasks continue when priority == DEF_PRIORITY
- break out of the loop for direct reclaim tasks, when
priority < DEF_PRIORITY and enough pages have been freed
Does that sound like it would mostly preserve memory pressure
between zones, while avoiding the worst of the worst when it
comes to excessive page eviction?
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-22 16:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 22:12 Rik van Riel
2008-11-14 0:51 ` KOSAKI Motohiro
2008-11-14 3:27 ` Andrew Morton
2008-11-14 14:36 ` Rik van Riel
2008-11-14 17:18 ` Andrew Morton
2008-11-16 7:43 ` KOSAKI Motohiro
2008-11-16 7:54 ` Andrew Morton
2008-11-16 7:56 ` KOSAKI Motohiro
2008-11-16 8:02 ` Andrew Morton
2008-11-22 10:22 ` KOSAKI Motohiro
2008-11-22 16:57 ` Rik van Riel [this message]
2008-11-24 19:12 ` KOSAKI Motohiro
2008-11-24 19:18 ` Rik van Riel
2008-11-16 7:38 ` KOSAKI Motohiro
2008-11-17 0:38 ` KAMEZAWA Hiroyuki
2008-11-17 3:43 ` Balbir Singh
2008-11-19 16:54 ` Mel Gorman
2008-11-21 11:59 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49283A05.1060009@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox