From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E902C36011 for ; Thu, 27 Mar 2025 15:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07D8C2800FD; Thu, 27 Mar 2025 11:06:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02BCA2800F8; Thu, 27 Mar 2025 11:06:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E37A72800FD; Thu, 27 Mar 2025 11:06:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C64922800F8 for ; Thu, 27 Mar 2025 11:06:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 47B16161002 for ; Thu, 27 Mar 2025 15:06:24 +0000 (UTC) X-FDA: 83267657088.10.57807A7 Received: from mout.web.de (mout.web.de [217.72.192.78]) by imf22.hostedemail.com (Postfix) with ESMTP id A6EE8C003D for ; Thu, 27 Mar 2025 15:06:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b="H82cPS/1"; dmarc=pass (policy=quarantine) header.from=web.de; spf=pass (imf22.hostedemail.com: domain of Markus.Elfring@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743087971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oc4HlqCoJnV7jIDygaPvu7y9WnX1Qq3j1lOvFDKhkHk=; b=NRaHI28MWaTqhrQG09/lDGjhM4kH2dvGg1gNO2jfA9UKWAM+G7sLz/PATmWKuN1kmENOkb 0pc0Je86JOMzAKiNuibjRQDrMaRi7GNmnbAutmqNifMkKtFp6HkKvENsyxYEFg5A/46mSc B249qUDEZcCJOj/yqARIawnrwYKv8gU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b="H82cPS/1"; dmarc=pass (policy=quarantine) header.from=web.de; spf=pass (imf22.hostedemail.com: domain of Markus.Elfring@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743087971; a=rsa-sha256; cv=none; b=xSVjJO7NDZK0WAD/xwUJ8nvnVImfF3lHsdDHFwPrtrtwv6PmADwqPyU06YSpAWmf1dud/H KEzFwL2R+u3NUV+ftlYanxjwFc2W4lx8Q6Yq5rZwdNnPCcKV51YfzVAB2pCH/fO+Cq1Lc1 InlKwtDoh5OpK2vq8MK9wQZjpdxhaLc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743087941; x=1743692741; i=markus.elfring@web.de; bh=Oc4HlqCoJnV7jIDygaPvu7y9WnX1Qq3j1lOvFDKhkHk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=H82cPS/1vPtnSgOTtkjjXV6JBPZG1azsR30Jp11zyuHmQQ3E+fN+R2TLDu3NmpzB D/QBbFA/9sm27O11UfGbT3nesxx1mYWQKhp8LUZFaTdn8JSuTkn5knoH696OsQkjf hvvQPxv46Sp5tw5E9jZbRF4Edl1UtNIcYTU4F5aTt8ELwC/f2u2yUflfmys7HNN5A Tt3vGa1Fc5o7504Gg2U/k188XfxEAs+c7AmIWE7e3Yd06pyci2oLwgsJlD1cfMm2f Y5LMCmss8EkaKN6L4IU9GgXz7k+4R0EdjA+C4bQqh0GgYckWJt9m0nC2wCMonqeRg lKTbBEnjfCGitVtMiA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.93.33]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MdwNg-1tODOl2Msg-00bJWW; Thu, 27 Mar 2025 16:05:41 +0100 Message-ID: <49276ee6-6eb5-418e-99ad-3ed9d3e82414@web.de> Date: Thu, 27 Mar 2025 16:05:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3] mm/page_alloc: Consolidate unlikely handling in page_expected_state To: Ye Liu , linux-mm@kvack.org Cc: Ye Liu , LKML , Andrew Morton , Anshuman Khandual , Sidhartha Kumar References: <20250326011752.917564-1-ye.liu@linux.dev> <0ceb4ab8-adb5-46bf-98e4-61a1bd908e20@web.de> <7c278ba6-c1a2-4ef7-a4ac-48c233dce7a3@linux.dev> Content-Language: en-GB From: Markus Elfring In-Reply-To: <7c278ba6-c1a2-4ef7-a4ac-48c233dce7a3@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wpAIhCth5swCXSkgJ6ytdCPabeROu+FRL1sBRwMdxNtkBYSi0zl L63x+U0NvWP8WK+uXqrbggTJLU54WZR6VnZoA2zDMxOhqRhdH0KHK2dvI6SqeLm+NGmGkSh r5r3rgcJMEf387Ixr9aH/quc7ICqeAe34TG3lgG+6qSf9n3yVZVMHKSYxEUBianPGZn2g+8 A2k7pAQdbZKVMEw1eyTDQ== UI-OutboundReport: notjunk:1;M01:P0:vj8KNkbA55I=;tyF2Zr3Xc0d12YUI7ZiQQg3GZOj 8VcJhf/l4gJbrEiJy1oMxv0ebR0fx6fPdYtPNXqmpJfDORbc5Fh6JPGoI3bNLc32vXwqAskbz upmkrtd6CSdtb7PxbnfXLlkBZasu6KpPmxzM42Exxt9m8ZAJKYxhgQtv6d5Ud0r2MwKVVnbXY fqkB0hDxXmqu4wtxkWh6MVZPfMugbwa4zbJ8H1uCH8PHpg1AcgCKLOuSBeoUTZELSnnHMnvMV fm4Mlm3p7QTDDcwv+QyGmhTeDPojhftHo1l/7YN4kaUu6ect8pRV5gHeeqwgeyRdw82/4owCT ZlBQdwmn3RR0RrULGYTXzb6OZi3C4aL9uMTATHJlcfWAT6pGKkLpnCie516599isrfhyDH8Eq gy8GzkT8e6NteOrzl45d6D1AkXjBJir2aTYLasqhpW+EW8KosB+csC6xNtZcS9biO/eB/HjP6 qkxsCst3P9btgA8sAHXOtlqYVLsRNh/Kg4LEr2CSw7V+dHLEJVcTDpqd8igQC5nWxk0Mv7zNm f+tbi9d/Ij3g51B6s8SqlQH4wyy7gHXgiewH3llFxEhHNnof6c3jPhfPrDy67bYs1F9Gpl8gp bpI3z/WX1jVvbi4SBQzR0qR5+HntWqZPJaDrcciWnL7Fr2mh4T8/I6oco3/F8n+TQWPqFWLLe cxbMwBbaaPlS8TOU8VBH2UqnVwoe+tBBDYolOcWIFzN6E8uxTJCJMkSx9jUJ0a9LLQL84f9Dx QSP9V+NThw+TnHvVhkolkQn9sGKIzDqJ5ZEnK/1odlNomyoZ0NaE5/ocyCgkBGibhnqFHr3fw XlA+BRt3PfUDAPHl/ZOg/yDtgXSCMwyZkw1oIaLK+eXLmT6tG7n0Wn6BLotMG2X9nvaHShyVn PvSi8zfNfJXI8r8wlrLjBt5bI26awZaUOBM8yn+TVOtljM784oKusd59uc3LCyQGJHNirXRDf jJpgPDPbCxDj2Usnx40HNA+Fy3oNQqxk+KoyAt9YxigquxyOkRMSCKhFmRi0YA0Opslj7/Djj 8rTt9Cuodpv4B9SZDhAsS2Mky79vIYm4/o8egsVGKptZbMN9Ewyhosgte13QbVEb0f2LZjk+i pXZRZvoAFMMrq38oVEf9EOTM57QupZrCOUUihuwJzk5oHzei+ot4FmLLwrOBff48SUF3yjTZO kDmLTQ5PK1wMT//+5P4u/a8NsTk0u/QgSV3tp2Jeqf8qCHkXbbYxb7fo0axvDE7e5rnqkVDfs GeiWpWuff/HmRZm8CAH8FWuTGkF2jteNC9Hk6NeYKJ7V6HOgJdvDe74tv4kaAdUTpAIpliwPx +kjURyu2k1Kg+9QmF5qLGwtb3sckqv8kVYEUXj2EOS1sTm7sa7BjsebUBoF57Qdg76tn7WrQp 0yECWOTJY8GLYIQQt1ejFOcUea4MmgxOOGx96mXp38N0LuytOFml4szX27JWGvEEro6reoDm1 eE+Pp4GxY+ZdHXBULJl4RxYhqN4fsuNNzsmca+pdhrduIa4nx X-Rspamd-Server: rspam01 X-Stat-Signature: zscbc7nobpik3idphyjf1ym8mfyjwbb9 X-Rspam-User: X-Rspamd-Queue-Id: A6EE8C003D X-HE-Tag: 1743087970-328208 X-HE-Meta: U2FsdGVkX196jGMxF5eoNXsuvYP/Asu9SqhdLzm6KIO1KOv9b94W9nr/jrumLQtbO2NzeTzwC5AmG0wIMJaWbhYWkPBALBWb01bohqisKQSmYmxKaAnz89KwZ7DzFj3eJhGBZ3KvzzFIUflv8m3tKrn+A1K4o35j29IKeaw3WUD53uczrvBDgFe8EspLz7h9pxQwi+2+UiE1mkeWqaFXHdC7SFByz9VKXW1GLFqNFsb0S1Q85d9xmQuucRfdtO/xQ4P71JPNJNUiikTw0AGkgJfu5hEgNUJtwL+ZSGPATaGWKuW0SeivlwMUr0qUf2CpIWZdfKmCnKzIujp+v0dNxao2AIITKnP8YHJGBmNQCWh6ph1JPS2xmFpGyvvS8tzMF7+0rnV5ZKEHJUzY6CmP0X1p8OAg+D2Dr47hfpjH3+sxoRtHdInDFJ90zMgHgElaRs++flH9WVNjynVX0HFU5cIn4+f62AHXA5yqmJivytNIXUsw8pR6r2vlORJTyn7/VYSA7INEpQNyb8nACuvzt+i/bl0InaDJmf9V2qDDy0v1repGPl9czoJM3mWT83XjAFtTUjoGguwkcTufvWXIAeBeVqp/wdBpk0aSh8xyZG2ZQP902yVyQCfLLHZppBWXMgLrcC9CNEvfljsAq0v3Ag2/RjaTNe2t6XyBFMgAs7znaaAVh2+tPSjluxjEHivpRi5Ln9ywOdDoRfi/AZNCF2a+nPsilOt3CQT9KzCMbFqh1N+LrG5O3uDzXEvgXJ8GsbYbrB/GYWACoU1xb5cPLWRf7XZA/m6wEXUmO6iy8pD/E32chsxEn2+ODeE3q9HOZsSsCsTdcAwd2B2Wuv1DXsrUX61aGyXc6ujjwJh12Z6hIO5wuWBl8Bh1ApChaeZ7CasDP8Y8I93jXwL8LY4uRkyJhc5IPAqa69VbOmfUNRowHkDHO8F2/38J5eFtm7neIIQVpoqtJ1wGFsS71Yh zvKvW8dO nEfZYVy0WFNmNRJw80OHJCzQUmsz6e6uDoNfmO/0QcTy0HSDUB2VqiYP1Jxi8soQ8+cu72w1MgFSeGgaCZi1SBZN56KEKjBpvZjfWof+wdfQa+/3u8aDYT/OudPL+CYs3JenbbuAwAV3+r9UBMhn9wSDbMxqrYFhmKjaqlCG4k0a0y0Ohh7+f/OKgHYdmSgA4wzryf1aDvAHvL9LNFJbOD7Ia34uylytlQOC6kl35Fqth64W5aVi4+WsfXAEZS9eMmN6TZMMJQz+jweunUTnHxjOIhEcJxgfg9NWzBzXBZCmx0/IpA0Z2GOctDQxg1iPHOqjvM/m2M9Hrce9Lieo8MNSpR5Pbd0uoWOCVn9xAZgxY2wapqrZMKrQBJKcYMBWK/ptmFrknUj2TBXY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/= tree/Documentation/process/submitting-patches.rst?h=3Dv6.14#n94 > > How about this? I hope that such review can trigger improvements in change descriptions for further patch versions. > Consolidate the handling of unlikely conditions in the page_expected_sta= te > function to reduce code duplication and improve readability. =E2=80=A6 Would you like to append parentheses to any function names? Regards, Markus