From: Markus Elfring <Markus.Elfring@web.de>
To: Ye Liu <liuye@kylinos.cn>, linux-mm@kvack.org
Cc: Ye Liu <ye.liu@linux.dev>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [v3] mm/page_alloc: Consolidate unlikely handling in page_expected_state
Date: Thu, 27 Mar 2025 16:05:38 +0100 [thread overview]
Message-ID: <49276ee6-6eb5-418e-99ad-3ed9d3e82414@web.de> (raw)
In-Reply-To: <7c278ba6-c1a2-4ef7-a4ac-48c233dce7a3@linux.dev>
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n94
>
> How about this?
I hope that such review can trigger improvements in change descriptions
for further patch versions.
> Consolidate the handling of unlikely conditions in the page_expected_state
> function to reduce code duplication and improve readability.
…
Would you like to append parentheses to any function names?
Regards,
Markus
next prev parent reply other threads:[~2025-03-27 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 1:17 [PATCH v3] " Ye Liu
2025-03-26 8:48 ` Markus Elfring
2025-03-26 9:34 ` Ye Liu
2025-03-27 15:05 ` Markus Elfring [this message]
2025-03-28 1:27 ` [v3] " Ye Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49276ee6-6eb5-418e-99ad-3ed9d3e82414@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=sidhartha.kumar@oracle.com \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox