From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D79D8C77B7C for ; Wed, 31 May 2023 08:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B6FA6B0072; Wed, 31 May 2023 04:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 466FB6B0074; Wed, 31 May 2023 04:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 307D08E0001; Wed, 31 May 2023 04:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1EB206B0072 for ; Wed, 31 May 2023 04:46:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD7EB1402A3 for ; Wed, 31 May 2023 08:46:41 +0000 (UTC) X-FDA: 80849919402.17.8B0E517 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id AC861180010 for ; Wed, 31 May 2023 08:46:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M0VYzDgH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685522799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nx2y8OB2aLxSFND9I+Qn5cRQvjq0n5CCY38YbkEtKAw=; b=oiQ0yKJAD0rktL/y568gnzcuwR8OkWbJnhxnNqZSIT+WuVtdVMxp+Hc3FbLdYfxAnrc5JA eyoMwfOyyMelo2FH4zt1TF6R497iAi7UNBm3nH8HcLnRtkreyWYtqSij8gTVrw9E3PRhAV tav0FODNoxrAKRxMjfPydkX5Yq6ZFH4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M0VYzDgH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685522799; a=rsa-sha256; cv=none; b=mkMe53iHfm5Oo0vu029gVDnRhuiMeMof/PfFYJHi7NNN8VMLBLZ6l6nfvc3F6LrJEYeth6 sqj8U2lunIHOK0+FOkFsM8U0Hiif6ddZk0HqxKF4bHfdiwE0ZpTkNG7/OSkTfttZLRhGi/ ZkFL3Y1yePwVBY6E2y5wkkoacs3roXc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685522798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nx2y8OB2aLxSFND9I+Qn5cRQvjq0n5CCY38YbkEtKAw=; b=M0VYzDgHceRQeCXhEOuDPosrIE+gV124U7kZuTufpsVzuFMqepRN0Rfs5p2ffZ/NOAZlcG BAr4KqFsRA7TULaWnAXMEcpVspJ4mqBi4OaGeCzRmaTmDXQYAiZx2wYEPMsl6xrGBPNi5i /PK9suSGP2ztTTci3mxGijFn3k/mJec= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-b-cROzK_NUu1qtcXW2J4dw-1; Wed, 31 May 2023 04:46:33 -0400 X-MC-Unique: b-cROzK_NUu1qtcXW2J4dw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f6f6a3fa20so82468025e9.1 for ; Wed, 31 May 2023 01:46:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685522792; x=1688114792; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nx2y8OB2aLxSFND9I+Qn5cRQvjq0n5CCY38YbkEtKAw=; b=H1DjCJhhXRRUi8wgD/T3VjstplycR2Vm5jl8KA1+wwb7bhGHPBJSOab09zP1MPJbAB sbt4J40dUP1O3UMBKVafH4gKBr9YNOy2DLZaqS78Sd2ahaXOqR8jol2+aabchx3QgVi/ BSu9wf0yEDIcomHC4D8KHm+bDkE4oy8qK+1QGdfzvrVmwqF+xkxgEITZTd/ywRqit/6s 0XQB/SJScRjNId/bs6ZRsW3AqaNcVw54/sLtMnosqRcY5gGiVkSFaAoJlXN3OhIOibxx CilpKr4kBlXTjSSARaHCAprVlfaTZULejFl1ANFB8Wa5fLhAQVhlkFYbvEsJjG52WlRh dqEQ== X-Gm-Message-State: AC+VfDzLtpNxEZQy/Jwdti0EE9uclvGP72XS2WSyTMckciOvHihBAoEp hQqXKVWFlyzIv1YcH7Z5t1HC7oitqA2i3rrCsdvHRzdZRCyowLZcA7KnCgpwFhQ8fnFzWIlb2fv dHQYRTMjfbxU= X-Received: by 2002:a1c:ed14:0:b0:3f5:ffe2:91c0 with SMTP id l20-20020a1ced14000000b003f5ffe291c0mr3840035wmh.0.1685522792111; Wed, 31 May 2023 01:46:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ40ukZYaC9+p2ae+0GrHp4hYdn2NPfwIUaiQLhpoTRtuUrMnrS/tcvC//4ponMDsKOMIldq3Q== X-Received: by 2002:a1c:ed14:0:b0:3f5:ffe2:91c0 with SMTP id l20-20020a1ced14000000b003f5ffe291c0mr3840011wmh.0.1685522791768; Wed, 31 May 2023 01:46:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:cb00:fc9f:d303:d4cc:9f26? (p200300cbc749cb00fc9fd303d4cc9f26.dip0.t-ipconnect.de. [2003:cb:c749:cb00:fc9f:d303:d4cc:9f26]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c231100b003f31d44f0cbsm23714702wmo.29.2023.05.31.01.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 01:46:31 -0700 (PDT) Message-ID: <492558dc-1377-fc4b-126f-c358bb000ff7@redhat.com> Date: Wed, 31 May 2023 10:46:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: David Howells Cc: Christoph Hellwig , Lorenzo Stoakes , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton References: <20230526214142.958751-1-dhowells@redhat.com> <20230526214142.958751-2-dhowells@redhat.com> <510965.1685522152@warthog.procyon.org.uk> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v4 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() In-Reply-To: <510965.1685522152@warthog.procyon.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AC861180010 X-Stat-Signature: pyccch9d4qtb6njx5us38azkqd463159 X-Rspam-User: X-HE-Tag: 1685522799-547038 X-HE-Meta: U2FsdGVkX18LXi5yI9AWvAOwVoa0g1ty9OIo8fLSisUVl6Quzm40mrNiMdjiY7on9EHlndYQt9h0D7OAuZpERk2SE8hGpWxrnWG/xLfLRKuyJBoDU06Lwime46y6+fQPaLiYaCRgzeWPTifQI/3IRGxQRQnxlgVjazkKPu57kGVIAkSe6mW8d6S33yymXc/JFJ03s7/MtR/8zU1IDRY9z9VISJp/XAqmiAjBagULYJPo9D7CfZUvlfp2EnyBsa18j0jkApVKZIysZ+11WssUu6Xa/tsENFw0KYMepk9b4TN7pyHDY/2RhK7Q49dYL7bqajrXEV8F5QgYdKubRcRkOOK72BnLJBfHfZIBmSXqMBy7ANv2riCyU8yBPRGyrhv8r8yVzXXsYOxeObGkuWTfSADh+zc+gOBFOjcJlzemBHhTxJ/gXKVWCBYB1BOvX5sB2xsTYsZmicrcgvqV+1YaVUN1YZebULfCFeldv1PqEhL2vyx3tRciOAtLTa9eb3mWzxckbjmBoxhp3Tc0fj/VAJfpAu9i49L3TBhx4pxPUPgro3lT9bzDHKbUJNnfshnJIkQsLcoJ2HSO6d+92PyovKHv+LJZ0xFdUVK6Rue4qapNp2b92yExd1nesX44cWgszd4AkJiF34orpV7a1QNkHzLBcmpRyn4q2zNetPobGZdyoawjnRK5E2GSMrXvVEbr0xLtz0GbhjJ7mOWrAO1qVOz+XWqj0s84fxH1b6Q3WhoV3taqIa2N17IiGLyxkc0dzSSms1Y0IX3keLFTmc7Mt9oGCyozhRVlqRCwQRvElys1InvCCPYNuLC0B44p8Zd4/bQEL84RxmxyAgs5Sqluam6ZQRkF6IeLH4yXdq5CvtWXhaz0r/iIFJ/YUsJgE31/MHIQ/E8ZszhIxlmlFcAqHSK8vndbs9+5IGRATb0z6bLSu1KC8hX8BimCL/Bthr5PGHs3S4PidguxskRb9C1 ldluaUud eEU7HQCVkXo/mPON9vS8nUDklliV/mXYszxl8W71kr5Go0mHyKTbnJbHh8Ir0ng2hMEY5p4qZrZy3sS/mCvN3iSDmU5ijhPLXfJvY3/D1JekFA8drJ+UwNRpZrooBXzBilpVs5OxrF3sz9oDoRggt6FHzYAXBreTj7sds36Lrz/DMiph5iEhYK/qS7J8x2gxIlB8TWDJVUR13iVNIlCHZChIu6D0jYQsiMcUvvmXFWkcNZ4XxkVR1Lbr2ULdDMqlEdyZ95tOubvbdiqj5jc+jjgR9KVhkaXDjBP1w6MWxrhJa0BdwtHS732CzTXZ4yDaCsUviaTsp4YNEGCnuACOmF7XCJyIsaNvju5/QrjQKUicl7JX77OZI0zeNX3X8W3bAIyIURl+6PKi5gCP+1yony6vYxFruIlI2su0ch29oiYX9JYsMrFnUEgvIXrABpbt4NyowOmxYO2Mdq0g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.05.23 10:35, David Howells wrote: > David Hildenbrand wrote: > >>> Make pin_user_pages*() leave a ZERO_PAGE unpinned if it extracts a pointer >>> to it from the page tables and make unpin_user_page*() correspondingly >>> ignore a ZERO_PAGE when unpinning. We don't want to risk overrunning a >>> zero page's refcount as we're only allowed ~2 million pins on it - >>> something that userspace can conceivably trigger. >> >> 2 millions pins (FOLL_PIN, which increments the refcount by 1024) or 2 million >> references ? > > Definitely pins. It's tricky because we've been using "pinned" to mean held > by a refcount or held by a flag too. > Yes, it would be clearer if we would be using "pinned" now only for FOLL_PIN and everything else is simply "taking a temporary reference on the page". > 2 million pins on the zero page is in the realms of possibility. It only > takes 32768 64-page DIO writes. > >>> @@ -3079,6 +3096,9 @@ EXPORT_SYMBOL_GPL(get_user_pages_fast); >>> * >>> * FOLL_PIN means that the pages must be released via unpin_user_page(). Please >>> * see Documentation/core-api/pin_user_pages.rst for further details. >>> + * >>> + * Note that if a zero_page is amongst the returned pages, it will not have >>> + * pins in it and unpin_user_page() will not remove pins from it. >>> */ >> >> "it will not have pins in it" sounds fairly weird to a non-native speaker. > > Oh, I know. The problem is that "pin" is now really ambiguous. Can we change > "FOLL_PIN" to "FOLL_NAIL"? Or maybe "FOLL_SCREW" - your pages are screwed if > you use DIO and fork at the same time. > I'm hoping that "pinning" will be "FOLL_PIN" (intention to access page content) and everything else is simply "taking a temporary page reference". >> "Note that the refcount of any zero_pages returned among the pinned pages will >> not be incremented, and unpin_user_page() will similarly not decrement it." > > That's not really right (although it happens to be true), because we're > talking primarily about the pin counter, not the refcount - and they may be > separate. In any case (FOLL_PIN/FOLL_GET) you increment/decrement the refcount. If we have a separate pincount, we increment/decrement the refcount by 1 when (un)pinning. Sure, if we'd have a separate pincount we'd also not be modifying it. -- Thanks, David / dhildenb