From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22EEC83F1B for ; Wed, 16 Jul 2025 18:18:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EA188D0006; Wed, 16 Jul 2025 14:18:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 399FD8D0001; Wed, 16 Jul 2025 14:18:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 261CA8D0006; Wed, 16 Jul 2025 14:18:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 126448D0001 for ; Wed, 16 Jul 2025 14:18:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A41A8593DB for ; Wed, 16 Jul 2025 18:18:10 +0000 (UTC) X-FDA: 83670937140.02.91ACB66 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 1D5FC140011 for ; Wed, 16 Jul 2025 18:18:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XjocGw94; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752689888; a=rsa-sha256; cv=none; b=3ZexwbJL6qt8wikrhlv+vnzxrAxpwe45VXkOOzvKZWm2j+Xw4ZbV7gPzonAhw0tDhzJo1p hAzDiWsG7HJDdxVCrwNgOBLkd8+FcpbZX03Q5YS7YKotiChMtTVeXn7ZMyMcyGHN3PWXm8 Q0FvD3u/96zEC9XPZjqTqNr2rQ6RuO0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XjocGw94; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752689888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KoaD2dI4jsgxjvFdQ3bse6bIyKN+Bp/X5u648JOU8EA=; b=DyFGwpTYWbqnEiIupjIBRZ+mjoYgylXhhMoHY4p1W5jldITzA5c0pnLbftm3LxRfNgl+ai JLmlxrf076r3Y4N6fv8W2Twh0hY1YmCeQMI0xMSGPZ4bxIOCAAWkC4BEqVsACiu+V0xaWC Qp64cIh8tx8V+QVjWb1PP5WhiYxjFds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752689887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KoaD2dI4jsgxjvFdQ3bse6bIyKN+Bp/X5u648JOU8EA=; b=XjocGw94jTaW1GX6P/1o3LRDDonkytytrUNqIm4Bgatru8FBI8ZK/QI1CuCrRx9mv7WS0A ywXbRz7/XymUolP/enrSQf7odncsBe/gn47/MojpI8I/uSa8dIVTOkJUq32MHOHlCzaPcc 8yeRGF9liHluBbA7R4DrD6nvO1IC6fk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-rfxSHcusPc-jEL3dCunEpg-1; Wed, 16 Jul 2025 14:18:04 -0400 X-MC-Unique: rfxSHcusPc-jEL3dCunEpg-1 X-Mimecast-MFC-AGG-ID: rfxSHcusPc-jEL3dCunEpg_1752689883 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45526e19f43so385715e9.3 for ; Wed, 16 Jul 2025 11:18:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752689883; x=1753294683; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KoaD2dI4jsgxjvFdQ3bse6bIyKN+Bp/X5u648JOU8EA=; b=s+L4uP6JHnRMxj3YjTh8QHwsthaMsnZWZbyKyJisyaFnd3NPwTYSGGRWmnUf3enO1v izQ37lPZaWWzogyF95OT/WDdWge/jTcodV6/BFUMItHAVQD5VeN2Noi8f5tuWGTUP3FT z6HUKdiHgoIS7VmX/q9qgsfSEZBCeoMlafkj536Z3PvoYSOrxt2ZxfnIo5eESb9BGRW3 cwKDlNInS6liQANOVlcNNPL9Z+UO2pNkK2958AMmx48hn/H4f+N48queicZbFhjPdkF8 MgljDmwAhVC/M0Sp+fHn4AtdXOXo1dimzX37HQ61s46f2oe2BoOH/lfbi+dEy4X2T5qr ezTw== X-Forwarded-Encrypted: i=1; AJvYcCUePY6EQj1InigJ/ttGgFagflSZG8G805I3rYgGmAKxZFLuf63IJd71tujmGwsSABzaOmyOrTZOUw==@kvack.org X-Gm-Message-State: AOJu0YykZAQbiF+K3uDlV4xeneTpo650htUSgz7Kt4UT9RJgOo0HBDji 6E1zj4rDOOLeBcdbowa6Rl7cTsebP8igXW1tDJ9RRg4DJZPYgl0ZGhfzAQCh4nO7XiPODk0j4gE 27ViJA/ottyl6Lf6Hg1/pQllYc6DfKHGeenS0Er+GDdaKXtHB2lSI X-Gm-Gg: ASbGncvKqmqlPley7ozNUIFPeQPSI0qFjTNtJWo326+xvkU9ff5qS6i7YETs/o2RxcY SWK7QKVMs0BtWE+zfzlw1LVQ3i8KkxjAA/FWoMDPmsOp7xmdat6O7yqGOtlq8A831u1qpZ4yO2u i251ucEmf4KGyA7LcJRifcWV7UrjccxRzK/z5Fqtu3ib1ZHoU8AW7/VGbUOs7NqnWShtQJ9dQBD e9C/k1Bwf1bNsZMtCrDfQ9VW63hpTJmiN9zItX7YuUDG5AZhj6AIlU8OXtIO7b9ERJ9dpZij6SI kmUXkYaIcJbNes9FOv8dT2IiWKe+L2HDUZCnSqvWuZyrRklMCCDY+vZBSHUGiGxtEhhVPFF+MMX GRcMsjn8mqHDrrLwUONiw/r7W/bfkvWzZwn63DTeND06xKyK/Tbh85sCsR0FQmSzzWmQ= X-Received: by 2002:a05:600c:674a:b0:450:d4a6:799e with SMTP id 5b1f17b1804b1-4562e275dedmr35862145e9.20.1752689882731; Wed, 16 Jul 2025 11:18:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDtCtTt6AdmmHAkeWIdTpPG0P/rIzq4lzVryUKHl2R7KTsR+2uSQiEcESSjyANyUz/j+rLMw== X-Received: by 2002:a05:600c:674a:b0:450:d4a6:799e with SMTP id 5b1f17b1804b1-4562e275dedmr35861915e9.20.1752689882273; Wed, 16 Jul 2025 11:18:02 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e14e82sm18680454f8f.71.2025.07.16.11.18.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 11:18:01 -0700 (PDT) Message-ID: <492025a7-4132-4944-b55b-90c6d6e40bba@redhat.com> Date: Wed, 16 Jul 2025 20:18:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm/util: introduce snapshot_page() To: Luiz Capitulino , willy@infradead.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, shivankg@amd.com, sj@kernel.org, harry.yoo@oracle.com References: <637a03a05cb2e3df88f84ff9e9f9642374ef813a.1752499009.git.luizcap@redhat.com> <900252c7-b16c-49b9-8c01-60e6a7a48683@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <900252c7-b16c-49b9-8c01-60e6a7a48683@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FFEiE2giuZL3PGtSvXm5gOIQeSrdBmWnlSycGgQ5ods_1752689883 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1D5FC140011 X-Stat-Signature: uh48t7b45unmk1adoznp8j43xjjwr7m3 X-HE-Tag: 1752689887-905328 X-HE-Meta: U2FsdGVkX1+ZOocAnhw9c6hKdJiez9G/vYd9RuHDvlMdFg9dVaLBpWK/5W8kVMh8guUocazkte1ldsuEicrpSPhj0yGIbx5NzjfXqstCPMUrh4AE1g6/gw6zexNpNV9QBR5H7QdosKzVEzVW3yyk8OeBYY+NWVcoo6u47IpDwVm/SBsKuIhhHZp4jvmmc/laRMRwHyjTX5B5KmYCd1Ht2X245yJmZhmZdXelzvJOFF1mXi7eQP3MQbiAY7GrHoT1aTf6B09xTMNazVEtA5ZRRcwGldyxGc2MEo4doLs0P+GUw6MfwK6A5Wad0Efz6b+iQZTZ3X00sKYTM6LiVEKeOScd13G+Dekuk/grlp61uu+2utwr1h/wU7ehLjpJXPJFMzwHyqHhzAt1Rrqb3V8sAfoO6HojYdSCvoT6zub3dTv9a54oNkEXPk8MlInIXJml+NMVcBwS6nc4M/GuFI3lM3qD8MRREJf8USzQkw8DKDGYnfw9PwXE7CSsojXIGr3IyoLJbY7bYBu5+9fuF1MvTExENG5XPhJDpVMve5nid2UsKe1Qab8wlcKNXQ8AdrhDjdAGj8SvGlelvScTq10WHhPUfn+F3m7FOgYiQf0v3wMbUyUQ97wYyuoc71HDkG7UiRvHpT8ABlpcMxBK4YTBFnLOMubpGJICYWLX8Z+KfqQ8TQpPCjucGNOS7kq0fc2zpIcB1ka+GhxoEh2fU36kOZ4zOJNafvh/bVoLxFARNYmg4V0HoaLxCmFg5FrIYLbQ4NIwUlz4Fk+fXSXPxFN+sBmqhGxltq8h700F1QWSjnsAy3i2v9EJECvS6ZILYk1EoGu9KBkfqW/1gzHdXSoJSa9oGpopWaRZPON9Jo9bEsMY1tvMjNlSJAOIvMrCQo/0i0kiIWNFKYAKIpRBtaM6hfetOayg3QQ120iNvtALglp+rzkrVbFR37eZUXunIJDLyN4BqOzARyLEDo4gGdP ASqH3iMH TEh4DRFnFjgrAyOTu+OGNucb71/F+ysStn02K9j7x0NX6eWkhmA0vOQsfQ0oyTlOb7PIU6KEmtkgANj1p/M4mKT3AIuiehSgiaeq+Ba1JS1NH5WS+T1Dggyoq6tE3/mNMDIphnyypG5WNth0yRTqqEuTZwLXjLYdD45t06gSqyQ1d+qO2JvH1mlYEmzlkIxkBPngCSG4FbspMyju9oEYw02iMy8DQgLKY65jcG/Zd6wVFIk7M3sVCCoOfcmwKwb8aDeJ/0Yoh76c6ryZkRa18Eh7dyar5Mcp2YQgafZ1IXKV4YF16Gy+IlxDRrKOpJKYW89j2YVK09pKHj+Vz5lGGoOz/olESvR9gb/yJM5fB8VATLT6y9xfkLDNJhHjqo78ILsApq850wqzt1dC/vUIE60I+cQWXUSdVcECi6JXOHAyX2K9hEBNDlukQnf1esqgSQwO1FB+NPP3U3fM5u52HunXP8fPx3fQ1SDJJeavMiR8ujbBdtygcT8sECY1tRbUCUhya X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 19:36, Luiz Capitulino wrote: > On 2025-07-16 06:16, David Hildenbrand wrote: >> [...] >> >>> -dump: >>> - __dump_folio(foliop, &precise, pfn, idx); >>> + __dump_folio(&ps.folio_snapshot, &ps.page_snapshot, ps.pfn, ps.idx); >> >> Nit that can be cleaned up later on top: >> >> We should probably call this >> >> __dump_page_snapshot() and then just pass ... the page_snapshot. >> >>> } >>> void dump_page(const struct page *page, const char *reason) >>> diff --git a/mm/util.c b/mm/util.c >>> index 0b270c43d7d1..f270bf42465b 100644 >>> --- a/mm/util.c >>> +++ b/mm/util.c >>> @@ -25,6 +25,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> @@ -1171,3 +1172,81 @@ int compat_vma_mmap_prepare(struct file *file, struct vm_area_struct *vma) >>> return 0; >>> } >>> EXPORT_SYMBOL(compat_vma_mmap_prepare); >>> + >>> +static void set_ps_flags(struct page_snapshot *ps, const struct folio *folio, >>> + const struct page *page) >>> +{ >>> + /* >>> + * Only the first page of a high-order buddy page has PageBuddy() set. >>> + * So we have to check manually whether this page is part of a high- >>> + * order buddy page. >>> + */ >>> + if (PageBuddy(page)) >>> + ps->flags |= PAGE_SNAPSHOT_PG_BUDDY; >>> + else if (page_count(page) == 0 && is_free_buddy_page(page)) >>> + ps->flags |= PAGE_SNAPSHOT_PG_BUDDY; >>> + >>> + if (folio_test_idle(folio)) >>> + ps->flags |= PAGE_SNAPSHOT_PG_IDLE; >>> +} >>> + >>> +/** >>> + * snapshot_page() - Create a snapshot of a struct page >>> + * @ps: Pointer to a struct page_snapshot to store the page snapshot >>> + * @page: The page to snapshot >>> + * >>> + * Create a snapshot of the page and store both its struct page and struct >>> + * folio representations in @ps. >>> + * >>> + * Note that creating a faithful snapshot may fail if the compound >> >> Maybe highlight that this is not really expected to happen, ever. >> >>> + * state of the page keeps changing (e.g., due to a folio split). In >>> + * this case, ps->faithful is set to false, and the snapshot assumes >> >> There is no ps->faithful. > > Yes, good catch. This was from an earlier version. > > Is it fine if I fix only this with a follow up patch for Andrew in this > thread or would you prefer that I post v4 with all the other changes as > well? I think the series was part of mm-new, but now I only spot it in mm-everything, weird. Maybe because of a conflict with the other stable_page_flags() change? So whatever Andrew prefers, really :) -- Cheers, David / dhildenb