From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94346C001E0 for ; Wed, 26 Jul 2023 09:25:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E44756B0071; Wed, 26 Jul 2023 05:25:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF48C6B0074; Wed, 26 Jul 2023 05:25:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBC146B0075; Wed, 26 Jul 2023 05:25:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC7D66B0071 for ; Wed, 26 Jul 2023 05:25:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D94A160C2A for ; Wed, 26 Jul 2023 09:25:15 +0000 (UTC) X-FDA: 81053229390.23.883777B Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf27.hostedemail.com (Postfix) with ESMTP id 22BC34000F for ; Wed, 26 Jul 2023 09:25:12 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="FbQ/cU5K"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690363513; a=rsa-sha256; cv=none; b=nhJewuw9tgriHEI3XcfTrxF6YdeGhNwrgNetSLXS9zauWTTka/OyDMPB+Z6lH1jpJsI6nk iPoTeNKTZeV1CGON1x9mPN4srP1GUuEtTYSCC4muEFHHrPvgFQacDNa/ZNQ8c8cAdYNov3 RW1eOfa/euy20V6trE5DnUS9P33QzH8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="FbQ/cU5K"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690363513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ajWZi1kTG9ZsFll3P13XRfH/M90QTcK5ZSE2yNZ8xrc=; b=gmBc3t0hdSjQoPt3j3p4Prd0Jptp0zBukogxoBb2CIqW97pDzs40CZROrLUQu43NQvsmxl Wa7lv2SaWIfP1zkwBDqpPumLdTSDjY26pgJK/rV3+R8ppWbMG4Ps+wmLdlSCJAGSzpT/hi QLaa3dJVuQxiSf0ZrqmF46LcqeE7GqA= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-66d6a9851f3so1488063b3a.0 for ; Wed, 26 Jul 2023 02:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690363511; x=1690968311; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ajWZi1kTG9ZsFll3P13XRfH/M90QTcK5ZSE2yNZ8xrc=; b=FbQ/cU5KkBidPkx8Y2uGYCzGutSB6xNfkWiQEKQsSST8W9zvQhHhApft87PlLY8dLU DGKfOcVpxkQTOOl80Aro56BnjlNO41fZWD7CmV5GDlB1LjEDjOf3Kop2mVKp+naFiQzY As6MgqOMDkFvMljdz6Un/7KTBl/NUqtiNwtAlVNm8YXgeUKehHDEJVTDK07iwDWpbMUs Auk85ACWfB5lfW+mTAMWhogzlI0RHaQpyoe7zLfXc22574NosN/xSHT+kEdNg0VX/lgH cTQssA2/OElC5yJBDMwL3y7p8+2qs+uUi9JaKT2yW1TXFErKU2nPA1SSCU5AFvvQq6bi em9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690363511; x=1690968311; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ajWZi1kTG9ZsFll3P13XRfH/M90QTcK5ZSE2yNZ8xrc=; b=AX9Hl2Bd0Ds8/pwjOOp59/37qeMibQkB1xYlIrgI1a7JjLk+lsKXVXBUOF7Psxdq4N Olos/UVKywlOuOY+FEP5Hd5aw65ZNu/1m+y7PRrgfSItMjXNKVI1RbS0soIamgAG9w3F 2wzluoDvzTDSauvlrolQ740njIm4F4oTD42hYfLGyBVAWGR9QvLDmCNiMIc6PMd3dvYD j48fvnZd8iwgHA3K5Cs1C5vlywK6oUIgmpzP0EqKzyIMNKLpx4g0roCMabl52JnNEyjd HR76cPvYQh5Per8A0ZYXks4k7Qu3dRWf6J4gfimyu2SnH1oAEpgxHp8W+MnOk32vQXRX XsoA== X-Gm-Message-State: ABy/qLYB9Dd5j8TSJcI6Pr9EK0KrV/kJS6WMoDYOeGgN4JTynoLwrzZh euYQeTyPaqvi6tb2XW0F+wyWjA== X-Google-Smtp-Source: APBJJlH7Lt4w+KKgSvUzSkJhF0oF8+b3ljHzveqc3Noqsk7KflIEw6xDKQ/sXRTNdo5n0Hc+oIf56w== X-Received: by 2002:a05:6a20:729a:b0:100:b92b:e8be with SMTP id o26-20020a056a20729a00b00100b92be8bemr1785615pzk.2.1690363511718; Wed, 26 Jul 2023 02:25:11 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id h2-20020aa786c2000000b00682a99b01basm2004283pfo.0.2023.07.26.02.25.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 02:25:11 -0700 (PDT) Message-ID: <491f5c8f-ccc6-dab8-71b3-caeedc8c4b39@bytedance.com> Date: Wed, 26 Jul 2023 17:24:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 17/47] rcu: dynamically allocate the rcu-lazy shrinker Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-18-zhengqi.arch@bytedance.com> <3A164818-56E1-4EB4-A927-1B2D23B81659@linux.dev> From: Qi Zheng In-Reply-To: <3A164818-56E1-4EB4-A927-1B2D23B81659@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 22BC34000F X-Stat-Signature: d988r6qjspfmidunkh9ocwhida19onnb X-HE-Tag: 1690363512-459649 X-HE-Meta: U2FsdGVkX18Zzgy8yf+D90cfo8QMEAq5VXRaIzXxcDMXv934WfyDyuCEIbam8YUImYKETJq4rUDhLQqi4dIJJ8x3PZ6tLipcxDu1nsEMJNA70f+M3c4AGN78NsOQKR3r4Rsr35G9n/ugpUCrfeGCLf/RREtZZcK72oaRMbR/n2Qv4GDA9JysTKBJawhLABx1lEUjF9HvDl+KqvSZ2Lz7GyufAU/8aA1g3r7q8rkPimYD7y4sExlwpfOkc64K38HpFHq8YQuATA1xzv9vKpfsqoD3W1lG8hEquswI1FhQjt9++Q2kr0fh56NyZZjk52tV+Qgl8zTfD5yJT01cVc9GQ9MINeK5oF2S/BHvJ5tDlpth8aHSsLrDVNKstFl3iBbVjEKLCwdgVTWTaQzoHzs6sx2ZnQgALakzlGLictYvT2ykWbLSXjLb5Vm/+4V9CbZjKaC0naKBaf+1CVL7GQDF6xm0i4ctvG49v/ki71CzPo9X992lKw8PAGAiP7piHdQz8YXDbyJ4Mi3bmdXN9IUFTzFjO5JnWdQ9bIYPmQnFfwGKjh/qU2bP40e97gPpbLWrP+z6U4STPKLqKEaxI8aH92Ayz1se5pI2OEZttoOxAI91RClSyetUhoGmwwrRJ3HewhebEHZ1KwSCvEa7zzJZUs4APCczp3nxSrSHNLQJ/bPhTQoAQvmEpaqkEotA5KojvWKTlgZK0NAlAo1DzKgWqzTHfGwBv+jJmHzgHz204agdW54Agtg5CozzT3eFozLhvrD1AKxUi3lPycaibl2c2ZaGU17XblTYImBxmqGhlISyauGdBwpCCkKAh/vak2T5YHDpOcvC0JC/WidUKmn9wE9Nw34xNmxcOe5oyoWZT6C/75CTke7mP0wjZNQ5cjakrx0bZZQo8ekto69VGYX1mwsjBbWalXFYPFicQrXe1f5QFGPsfci9SKiM3JGAhAbDwG8h06FligpoYH9W3zf jH5GROs5 INLRrTeBumM7wkRs90PEmPPjKv8io9rPWOZtK76PiyC6FaFIrCAujtX7kpe4MY3VMnpz4Kqx4bHMKIAhnp2gXjxMGPGovxlLpmV6U88n9/NCSGTkm05TaBNNVrJpFFK2IYz4edMouGnlG2GnH+t1ycIs5ZzgOUXqEQBtR1lCdwfXkYIlbnrEHbl7T2uzP2NxRCT//q7nWgpww/E7KoCuy7GK3azo7K0OlLmFdVgTFA0SwEKIGb3gaqYF0tnoh+nAXSBmboYFqiqUlnOyYMtfgKETMsdSiedDxjmdjQBNuOTeTRzzGWmx3q0mWqTRvf2+fb9gMxBZCym8qMX4RmoutqmUOIbz10hYWH4Q+iJZ52OmJSJAi5WS0e3x3RqXogD5iczGnQsKz10veyEHh+D9EXJFIsbwUm5C+hIw+d7j1ey1I4Pg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/26 15:04, Muchun Song wrote: > > >> On Jul 24, 2023, at 17:43, Qi Zheng wrote: >> >> Use new APIs to dynamically allocate the rcu-lazy shrinker. >> >> Signed-off-by: Qi Zheng >> --- >> kernel/rcu/tree_nocb.h | 19 +++++++++++-------- >> 1 file changed, 11 insertions(+), 8 deletions(-) >> >> diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h >> index 43229d2b0c44..919f17561733 100644 >> --- a/kernel/rcu/tree_nocb.h >> +++ b/kernel/rcu/tree_nocb.h >> @@ -1397,12 +1397,7 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) >> return count ? count : SHRINK_STOP; >> } >> >> -static struct shrinker lazy_rcu_shrinker = { >> - .count_objects = lazy_rcu_shrink_count, >> - .scan_objects = lazy_rcu_shrink_scan, >> - .batch = 0, >> - .seeks = DEFAULT_SEEKS, >> -}; >> +static struct shrinker *lazy_rcu_shrinker; > > Seems there is no users of this variable, maybe we could drop > this. Yeah, will change it to a local variable. And the patch #15 is the same. >