From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8856EB64D7 for ; Wed, 21 Jun 2023 11:16:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 476428D0002; Wed, 21 Jun 2023 07:16:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4265C8D0001; Wed, 21 Jun 2023 07:16:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EDD28D0002; Wed, 21 Jun 2023 07:16:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1EA798D0001 for ; Wed, 21 Jun 2023 07:16:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D02CCB0365 for ; Wed, 21 Jun 2023 11:16:16 +0000 (UTC) X-FDA: 80926501152.21.2FDFD48 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 8FB4F1C0009 for ; Wed, 21 Jun 2023 11:16:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OqPrb7ZL; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687346174; a=rsa-sha256; cv=none; b=13pJhFCOX4oE2eeOFdltMJLi41gs2BsTdDAlFv9Uyn/gQzCDgp1baflWiFdwfLVxKf1fUo GU+QVl1jySl37aBAQECYiOeHoITFknl4D+tq0IE1DnNt+eCQ9SiOvIwc+1oEj24xdFcgzc 39UKBIf16qOVbQPBZazeaVEE9Sid7go= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OqPrb7ZL; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687346174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2fnhuWzdBfkar4+hdkMDDz6Iqk6jdX4zAVvcaAIwIr8=; b=bss/Cpxo6xdKh5fB87fdHkbnQT7lHf8zTT/Fcei0hUI+/HmINZpAjNpTwnQUphimO1fl6Z cQkzI4TL3S8OgZFjGAThTrz62IzG5bFLcsYxlEGIRxomhYsMeoAkcZDhhgrzzG7sYMDei2 7QcTZIXgP3YeCHI4s2JlbZJWI3GXtcg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687346173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2fnhuWzdBfkar4+hdkMDDz6Iqk6jdX4zAVvcaAIwIr8=; b=OqPrb7ZLhugWK1GRlNinB5b4C9mRIujv43Np5141tb8EjpzpuPxIsaeT87qISAubuLLOo8 oCcltPMgCwE/asy+25/IPyjIi2l7IzHtNKO6aKIa4vkSIzk+MdnOrhf0EXR+3UUaweTio1 mICSnWsI0SicDZeUjqcK8PAPyuQ2kqc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-wMfaHFzNPp2iTRLWg4NnWA-1; Wed, 21 Jun 2023 07:16:12 -0400 X-MC-Unique: wMfaHFzNPp2iTRLWg4NnWA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3110d623e2bso2872401f8f.2 for ; Wed, 21 Jun 2023 04:16:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687346171; x=1689938171; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2fnhuWzdBfkar4+hdkMDDz6Iqk6jdX4zAVvcaAIwIr8=; b=l9VVZwaV1j59E8jBB3E87Mnrm+kP2cWxkmbhsGa4VPwVrgZOW0r+vtlT2e66KvCqUM mHMJA5vUA1R4OmwEvGyg65lqxCPJsxtDKAKbDt+Z7ej3/D3tR9vBQi6y9geb9y0B64Kr YcTQ8P3dr4DC4oI63GzIBMFsVctrQgmCXT+l75y8zAuK50wEGbgcQwtssa7TUjdX2UEF R++u/Zm1kPDk0e6NfVcypqUI0fITjZxyw8P8GXf6vmWli6cKKRSSK9d3/s2aYmd+Kyh2 ej5J9aBdpP+G5sRAseFYloJqn/vH5oSGD6dzhHuAPN3q43qzpiL/y0vM5bBRLloLH6RP 09dQ== X-Gm-Message-State: AC+VfDyXDFQaGhTDhitcwfVYifjKbzlZv2U29e3+Xyjy59uo8QnTy0wN fv2lz/qvegR5HPEofUhl8zHofZ/D7cAlvrxJXrww6i9ISioZhmC/i/Zq5jEccygs0+adVKfUUvC fRFFIbIf+UtU= X-Received: by 2002:a5d:538b:0:b0:30a:b3c4:3b8d with SMTP id d11-20020a5d538b000000b0030ab3c43b8dmr14642950wrv.41.1687346171173; Wed, 21 Jun 2023 04:16:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6nq5w3zbOV5Ltq1LgoMFUtlUu6NJWp8HfGSS4V3Lye+jtg/ZXPvFGiVckUSDLFBBLXHZSA/w== X-Received: by 2002:a5d:538b:0:b0:30a:b3c4:3b8d with SMTP id d11-20020a5d538b000000b0030ab3c43b8dmr14642931wrv.41.1687346170806; Wed, 21 Jun 2023 04:16:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:9c00:7978:3030:9d9a:1aef? (p200300cbc70b9c00797830309d9a1aef.dip0.t-ipconnect.de. [2003:cb:c70b:9c00:7978:3030:9d9a:1aef]) by smtp.gmail.com with ESMTPSA id a1-20020adff7c1000000b0030fafcbbd33sm4172812wrq.50.2023.06.21.04.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 04:16:10 -0700 (PDT) Message-ID: <490e71a6-e5fb-e063-5c0e-20085548f88e@redhat.com> Date: Wed, 21 Jun 2023 13:16:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm: page_alloc: use the correct type of list for free pages To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <7e7ab533247d40c0ea0373c18a6a48e5667f9e10.1687333557.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <7e7ab533247d40c0ea0373c18a6a48e5667f9e10.1687333557.git.baolin.wang@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8FB4F1C0009 X-Stat-Signature: aw793w7tkoh9xdaeeu4a6jgu11rntw5k X-Rspam-User: X-HE-Tag: 1687346174-71610 X-HE-Meta: U2FsdGVkX18rSSrcNTrZpKhd8A6ETYS/d5/m9iAa8qo1XqqQwA2TsTttFC2Kwv+wRwdcmKL823KiiwCTSmUcVj8TcFQC4TbC/mFSMcIGf0eXAQofDVCsAXJizOt1s/dVPUqRzQcQ5qHecwNc7FVwN09BXt+Eom4k27kfwht2jrEA7iB7E2v0RfFRUHXQYEqOmqviyBSVjgRAx6OZ0G24q2KhmW223mj+tobVhhyTQATULnuMaI1uIowuXAhKAp7M/UeZR20C1F/QFe49DxyjaADvhHvfiK8QdwN7Yw5CZCXUM2LjLtseRUFp6eIb2S0NOVNYnIunympe1vbR8p+GT4sPKD75PM1NydvdKyA7VI55DElgbKZmNWHaT/sP111obMSdc7i2jPdUfpUXqro/IaidDer87d17QBJmlONVu9ppLzT2mr65tcjmB7Pf3nBodpx4b+bRoplu7m5qT/gmmcsI9QjGpZcTn04oJy+P7/AxoPH5RbMd73Fp4yKgdOdG2xxJEsZl/5rcTCJhdLKh67v9yT9nvTZj5iLYqccMIzxFIqhoiAL8NucrF8L952Z5dCuysWzpKP8lKZONbfq4jYUjfRHXBATqJdHAt7U5eUU7rxH0peQzvNV+vx/eQnhNDgj0YkqOwEhZVf9mvj3VFriAa72tnn0/yVnamklwz48S0nVM72i2I0l0Tq5HvSRs+OqkRGQX3nqqusR54tLemY8OTiqHnzmlclgGyJMCm1Irz3t8qjRJPearnCiB1rF4K5sJgnyrFK45a/NfiOrsJ0/gREnSnHdfbn0iOaW+W8tb3jRVBshx27xwPyMx4uksaQ/A9hlzTVnOFyY08hfTegwzhH2o2WOckVPDRR8RZlXM5vxWXTXTSfGwu7J1PnPlxynbiLftoO4RbBXJ47n1Qi8R0+RASSrKuQA75gbBJTmCyFXzBtgMC0P3DKgcVBTbQ6kZIrxKOw2irnktNH8 30jGZ/Wh ZOsGvxBfGruBImIJGpAOz9aZmPsH9584YQ+8NZ1IByd9z1wlpKk+wxyfdG23gYMPJ17ALCuAS+3HKw2buGzF43B+S1+NT0qv8ZjAe1TPmbr+ryz8jrPZ765dbqL9VgI/gEzZ5RnVT+YeiqouoJDsC5+l+dtiNZBHrUcpmWnvrdaPedqUfarGT4p4LLUc1hxAchofVEO+ol/68kvwtTmJnWXlbCIlwW5WRKqmg9r09A4wuBr3fCjwAY3jC3p5ZXdPcYxB1L/sQ5QIM4dbLwvD34a/DR1VmPhBLzTyLYqstbue/8HvkP9V1DHhn+SoAC1ZkPBf6IzuHLp86zrDdXd8C3OquGlxiGYR51iYHR0M9krZtvvZlC4kCkfa77ZWsgrxbwMjI5K2bFeFuW+JQ0tNMIgfZGfz+i/WF4Mjep00moEXTNw4nP0t84CbDthy+3rWpz1XwqYd+h9SaYoXRhC4RzyAQJpA1606ZuEmT4Tjso4TyvW4tftQXpc8GeXPJEa4M4OjxAiOG6boYb0MZBFqHKYC7mgWuBZoJwKIa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.06.23 10:14, Baolin Wang wrote: > Commit bf75f200569d ("mm/page_alloc: add page->buddy_list and page->pcp_list") > introduces page->buddy_list and page->pcp_list as a union with page->lru, but > missed to change get_page_from_free_area() to use page->buddy_list to clarify > the correct type of list for a free page. > > Signed-off-by: Baolin Wang > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 5c691426822a..c1839a53326c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -727,7 +727,7 @@ static inline struct page *get_page_from_free_area(struct free_area *area, > int migratetype) > { > return list_first_entry_or_null(&area->free_list[migratetype], > - struct page, lru); > + struct page, buddy_list); > } > > /* Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb