From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF419C433EF for ; Wed, 6 Jul 2022 11:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CE656B0071; Wed, 6 Jul 2022 07:52:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 356B46B0073; Wed, 6 Jul 2022 07:52:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE936B0074; Wed, 6 Jul 2022 07:52:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 053DD6B0071 for ; Wed, 6 Jul 2022 07:52:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CD0C660793 for ; Wed, 6 Jul 2022 11:52:02 +0000 (UTC) X-FDA: 79656511284.03.E543865 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf14.hostedemail.com (Postfix) with ESMTP id CC29E100041 for ; Wed, 6 Jul 2022 11:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657108321; x=1688644321; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=hpbARSw+mzjqyHDAAY0dROTZcZffIHZIEhHvSpr0V38=; b=W3vxrjD+piIJHetq589n37yi7H8z0vUXcy1drdU8d5c1bypwt4V1QPeb 9Hqc9waLHoS5f4zsKrU/NMqukxRU184nZ480S45C+YLghJLIZ7NtnbcNv oI5MIsTTcRHV87aVHDHonUXCr0FUzvhDG4rmq9BKkA0LU1UIcrEw80p7B Uo6dk+gYUAl3i6Ag7P80+ENzVtgtFzjmJXSvJch9fNEtSBoPxV6cIXA9G R4htf4II+j4Ni4ixBGHPNi7Q9ecRyK2500Xp/vUwSkO9SR8YFMrN8Xo3r BxhmFjvNyQg+yvrltDoV8q98vRN9GDu0ZusRQcI0xRA7erSigX6m+7jZ/ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10399"; a="266753599" X-IronPort-AV: E=Sophos;i="5.92,249,1650956400"; d="scan'208";a="266753599" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 04:52:00 -0700 X-IronPort-AV: E=Sophos;i="5.92,249,1650956400"; d="scan'208";a="620280067" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.249.172.215]) ([10.249.172.215]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 04:51:55 -0700 Subject: Re: [PATCH 04/13] tracing/brcm: Use the new __vstring() helper To: Arend Van Spriel , Steven Rostedt , kernel test robot Cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, Ingo Molnar , Andrew Morton , Linux Memory Management List , Franky Lin , Hante Meuleman , Kalle Valo , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org References: <20220705224749.622796175@goodmis.org> <202207061019.0zRrehFH-lkp@intel.com> <20220705225049.665db869@gandalf.local.home> <0aa190fb-b761-6114-93c0-347aa5950a2e@gmail.com> From: "Chen, Rong A" Message-ID: <490e01e6-cc33-9cd0-adda-b07c052700aa@intel.com> Date: Wed, 6 Jul 2022 19:51:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0aa190fb-b761-6114-93c0-347aa5950a2e@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657108322; a=rsa-sha256; cv=none; b=Zv1uaGL9RHBob/rrLsZ3lv+FyhD9xaKhE9mxzUK66MmMgIEhqIuInK8dnuuVIPizntVjCG rikE2LvFapMHHfMbMBgsWik746GS3AAcC30n0Kku8wQD4aNtX2kp4yp9/asQg70g/IVhDM TR37F2+pdVaBngq+iiaoKG5OwLyrxd8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W3vxrjD+; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=rong.a.chen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657108322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SpV3nQGcRwcPeX6TxVqcw2UrtG+HzbCQqiieq7vSvyo=; b=5zW/Ma9CR+uWAM9M1PxoEfmC7L/ndO5zdiBzjG63ttaQq1d1jR1iX18G11MS2MR+YyCUk9 ckwnNNxgHROIEdsiSaj0OeZaZiwWeaAY/5CJ+K88tQNZeBdl2O7rlcR14k5NZuczJw62YW TlL8nhHfZHvui+ykX2pBJc08Q+N87m4= X-Rspamd-Server: rspam04 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W3vxrjD+; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=rong.a.chen@intel.com X-Stat-Signature: fbxpfqwx7nnm8tminc99cxihf3xtgkzz X-Rspamd-Queue-Id: CC29E100041 X-HE-Tag: 1657108321-354313 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/6/2022 5:09 PM, Arend Van Spriel wrote: > On 7/6/2022 4:50 AM, Steven Rostedt wrote: >> On Wed, 6 Jul 2022 10:35:50 +0800 >> kernel test robot wrote: >> >>> Hi Steven, >>> >>> Thank you for the patch! Perhaps something to improve: >>> >>> [auto build test WARNING on rostedt-trace/for-next] >>> [also build test WARNING on wireless-next/main wireless/main >>> linus/master v5.19-rc5 next-20220705] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch] >>> >> >> >>> If you fix the issue, kindly add following tag where applicable >>> Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >> >> OK, let's look at all the warnings. >> >>> >>>     In file included from include/trace/define_trace.h:102, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.h:133, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:12: >>>     drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h: >>> In function 'trace_event_get_offsets_brcmf_err': >>>>> include/trace/trace_events.h:261:16: warning: function >>>>> 'trace_event_get_offsets_brcmf_err' might be a candidate for >>>>> 'gnu_printf' format attribute [-Wsuggest-attribute=format] >> >>   1. "might be a candidate for 'gnu_printf' format attribute" >> >>>       261 |         struct trace_event_raw_##call __maybe_unused >>> *entry;            \ >>>           |                ^~~~~~~~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h:31:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        31 | TRACE_EVENT(brcmf_err, >>>           | ^~~~~~~~~~~ >>>     drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h: >>> In function 'trace_event_get_offsets_brcmf_dbg': >>>>> include/trace/trace_events.h:261:16: warning: function >>>>> 'trace_event_get_offsets_brcmf_dbg' might be a candidate for >>>>> 'gnu_printf' format attribute [-Wsuggest-attribute=format] >> >>   2. "might be a candidate for 'gnu_printf' format attribute" >> >>>       261 |         struct trace_event_raw_##call __maybe_unused >>> *entry;            \ >>>           |                ^~~~~~~~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h:45:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        45 | TRACE_EVENT(brcmf_dbg, >>>           | ^~~~~~~~~~~ >>>     In file included from include/trace/define_trace.h:102, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.h:133, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:12: >>>     drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h: >>> In function 'trace_event_raw_event_brcmf_err': >>>     include/trace/trace_events.h:386:16: warning: function >>> 'trace_event_raw_event_brcmf_err' might be a candidate for >>> 'gnu_printf' format attribute [-Wsuggest-attribute=format] >> >>   3. "might be a candidate for 'gnu_printf' format attribute" >> >>>       386 |         struct trace_event_raw_##call >>> *entry;                           \ >>>           |                ^~~~~~~~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h:31:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        31 | TRACE_EVENT(brcmf_err, >>>           | ^~~~~~~~~~~ >>>     drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h: >>> In function 'trace_event_raw_event_brcmf_dbg': >>>     include/trace/trace_events.h:386:16: warning: function >>> 'trace_event_raw_event_brcmf_dbg' might be a candidate for >>> 'gnu_printf' format attribute [-Wsuggest-attribute=format] >> >>   4. "might be a candidate for 'gnu_printf' format attribute" >> >>>       386 |         struct trace_event_raw_##call >>> *entry;                           \ >>>           |                ^~~~~~~~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h:45:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        45 | TRACE_EVENT(brcmf_dbg, >>>           | ^~~~~~~~~~~ >>>     In file included from include/trace/define_trace.h:103, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.h:133, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:12: >>>     drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h: >>> In function 'perf_trace_brcmf_err': >>>     include/trace/perf.h:64:16: warning: function >>> 'perf_trace_brcmf_err' might be a candidate for 'gnu_printf' format >>> attribute [-Wsuggest-attribute=format] >> >>   5. "might be a candidate for 'gnu_printf' format attribute" >> >>>        64 |         struct hlist_head >>> *head;                                        \ >>>           |                ^~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h:31:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        31 | TRACE_EVENT(brcmf_err, >>>           | ^~~~~~~~~~~ >>>     drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h: >>> In function 'perf_trace_brcmf_dbg': >>>     include/trace/perf.h:64:16: warning: function >>> 'perf_trace_brcmf_dbg' might be a candidate for 'gnu_printf' format >>> attribute [-Wsuggest-attribute=format] >> >>   6. "might be a candidate for 'gnu_printf' format attribute" >> >>>        64 |         struct hlist_head >>> *head;                                        \ >>>           |                ^~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/./tracepoint.h:45:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        45 | TRACE_EVENT(brcmf_dbg, >>>           | ^~~~~~~~~~~ >>> -- >>>     In file included from include/trace/define_trace.h:102, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h:82, >>> >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_events.h:38, >>> >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_events.c:22: >>> >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/./brcms_trace_brcmsmac_msg.h: >>> In function 'trace_event_get_offsets_brcms_dbg': >>>>> include/trace/trace_events.h:261:16: warning: function >>>>> 'trace_event_get_offsets_brcms_dbg' might be a candidate for >>>>> 'gnu_printf' format attribute [-Wsuggest-attribute=format] >> >>   7. "might be a candidate for 'gnu_printf' format attribute" >> >>>       261 |         struct trace_event_raw_##call __maybe_unused >>> *entry;            \ >>>           |                ^~~~~~~~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/./brcms_trace_brcmsmac_msg.h:59:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        59 | TRACE_EVENT(brcms_dbg, >>>           | ^~~~~~~~~~~ >>>     In file included from include/trace/define_trace.h:102, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h:82, >>> >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_events.h:38, >>> >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_events.c:22: >>> >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/./brcms_trace_brcmsmac_msg.h: >>> In function 'trace_event_raw_event_brcms_dbg': >>>     include/trace/trace_events.h:386:16: warning: function >>> 'trace_event_raw_event_brcms_dbg' might be a candidate for >>> 'gnu_printf' format attribute [-Wsuggest-attribute=format] >> >>   8. "might be a candidate for 'gnu_printf' format attribute" >> >> >>>       386 |         struct trace_event_raw_##call >>> *entry;                           \ >>>           |                ^~~~~~~~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/./brcms_trace_brcmsmac_msg.h:59:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        59 | TRACE_EVENT(brcms_dbg, >>>           | ^~~~~~~~~~~ >>>     In file included from include/trace/define_trace.h:103, >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h:82, >>> >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_events.h:38, >>> >>>                      from >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_events.c:22: >>> >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/./brcms_trace_brcmsmac_msg.h: >>> In function 'perf_trace_brcms_dbg': >>>     include/trace/perf.h:64:16: warning: function >>> 'perf_trace_brcms_dbg' might be a candidate for 'gnu_printf' format >>> attribute [-Wsuggest-attribute=format] >> >>   9. "might be a candidate for 'gnu_printf' format attribute" >> >>>        64 |         struct hlist_head >>> *head;                                        \ >>>           |                ^~~~~~~~~~ >>>     include/trace/trace_events.h:40:9: note: in expansion of macro >>> 'DECLARE_EVENT_CLASS' >>>        40 | >>> DECLARE_EVENT_CLASS(name,                              \ >>>           |         ^~~~~~~~~~~~~~~~~~~ >>> >>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/./brcms_trace_brcmsmac_msg.h:59:1: >>> note: in expansion of macro 'TRACE_EVENT' >>>        59 | TRACE_EVENT(brcms_dbg, >>>           | ^~~~~~~~~~~ >>> >>> >>> vim +261 include/trace/trace_events.h >>> >>> 55de2c0b5610cb include/trace/trace_events.h Masami Hiramatsu >>> 2021-11-22  253 >>> 091ad3658e3c76 include/trace/ftrace.h       Ingo Molnar >>> 2009-11-26  254  #undef DECLARE_EVENT_CLASS >>> 091ad3658e3c76 include/trace/ftrace.h       Ingo Molnar >>> 2009-11-26  255  #define DECLARE_EVENT_CLASS(call, proto, args, >>> tstruct, assign, print)    \ >>> d0ee8f4a1f5f3d include/trace/trace_events.h Steven Rostedt (Red Hat >>> 2015-05-13  256) static inline notrace int >>> trace_event_get_offsets_##call(        \ >>> 62323a148fbeb0 include/trace/trace_events.h Steven Rostedt (Red Hat >>> 2015-05-13  257)     struct trace_event_data_offsets_##call >>> *__data_offsets, proto)    \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  258  {                                    \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  259      int __data_size = 0;                        \ >>> 114e7b52dee69c include/trace/ftrace.h       Filipe Brandenburger >>> 2014-02-28  260      int __maybe_unused __item_length;                \ >>> a7237765730a10 include/trace/trace_events.h Steven Rostedt (Red Hat >>> 2015-05-13 @261)     struct trace_event_raw_##call __maybe_unused >>> *entry;        \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  262                                      \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  263      tstruct;                            \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  264                                      \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  265      return __data_size;                        \ >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  266  } >>> 7fcb7c472f455d include/trace/ftrace.h       Li Zefan >>> 2009-06-01  267 >>> >> >> Really? 9 warnings about something that *MIGHT* be a candidate for >> gnu_printf format attribute?  This is a macro that expanded into >> something >> that could possibly use the printf format, but is nested deep in macro >> magic. >> >> Can we please shut this up? > > Need a vote? Here it is: +1 > > Regards, > Arend > Hi, Sorry for the noise, we'll stop reporting this warning next time. Best Regards, Rong Chen