From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A960C52D71 for ; Thu, 8 Aug 2024 18:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAC5A6B0085; Thu, 8 Aug 2024 14:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D35B66B0088; Thu, 8 Aug 2024 14:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAFD86B0089; Thu, 8 Aug 2024 14:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 982CD6B0085 for ; Thu, 8 Aug 2024 14:26:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 51D63161615 for ; Thu, 8 Aug 2024 18:26:47 +0000 (UTC) X-FDA: 82429909254.09.62FA69A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 209B1A001A for ; Thu, 8 Aug 2024 18:26:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KOX2JyV2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723141551; a=rsa-sha256; cv=none; b=dgCJqRLkze32RJfZ40NtpEkPb9wJgXL/E4iz84ykodkMFUUlSp7FBcTjUV3+bhZxHEt8IX US6qEVfDiHAUlXVg0yOGBo5vXFF/IJ0VmDQrywyridCgfRzDKi+hiQpToMzCKMUvoG82gO A0TuTyqGDk1kLtFE8z4HCWOjgXwui5I= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KOX2JyV2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723141551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPdap2Cj58/bdcNangvbuKkQN3ShkoAAH7Mn0q0r4fY=; b=mw+hcyn3l7fSjsAq2N3Cd5J+wtkh6y9NnEL9g8QOA3LpLQwPbGDW3hWa74c55fNw97/2Qw DTClTZGpKDvKG0CM5BmsbR95BjbeuggKQzPFcDmPNOV9C5tcOZ/vHoN7MJ55Ji0YwMv2Jx JMhiwGlhOOqQBtvO/tSuXjUwVGfGiSQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723141603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oPdap2Cj58/bdcNangvbuKkQN3ShkoAAH7Mn0q0r4fY=; b=KOX2JyV2Gw5/yhJgR7vxrUfa/2/aDEZifUz0cIlf+ap6l+Nw0D6mzaRaQp2AWPHBaT8IoN g737ap0leMzjZq8yVvqHHZ1siRscpFTRNlafEGc7gXa4euvKRafJh/QdJ1z3i4GAb4ED/C pz8J7hv6Aru1alCfNhdva2682QGcks4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-2ljeY0wxNV65S1Da9VTCEg-1; Thu, 08 Aug 2024 14:26:42 -0400 X-MC-Unique: 2ljeY0wxNV65S1Da9VTCEg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42671a6fb9dso8625385e9.3 for ; Thu, 08 Aug 2024 11:26:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723141601; x=1723746401; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oPdap2Cj58/bdcNangvbuKkQN3ShkoAAH7Mn0q0r4fY=; b=pORZ+QguvWpIWoj5sVejzQeWXfYlLBxBC26/6T61Q0EZNl/vOxwkvddVIBOPTgSl6c H2bPrg3YGKb/mIChKXUt3NBZbBBNPdg/0seggZsbpsQ/FGGdZx8oreWIEGaO0Rufmdog XM80jzvpvfB6suNYCA3gX++f/ZaDRrGE5W3may4PoZbEZlpup0m5OjTcy0ClXCEWQ8MJ pUZ8wNO5cRZ7L1RFmuKcHRJsrQMmA3537F1keU3MZTUKIa7g+GP8aNOkNpwQbpAcG0yW inLvSdm9OlNlnViLmzsWKWEfdp4u5wsd6NaXNZjOUNXtYeWk+6nU6lsObArGoYJYowz0 wo0A== X-Forwarded-Encrypted: i=1; AJvYcCUtBB4UJin4KbPplSnxdLgfkkoWlQXNSJ5vg9WrmOPW90fDmKnjG7QxzYfaWDxiSc3GBApPWwKOZZc+Dc2bX9mwvA0= X-Gm-Message-State: AOJu0Yx2Ha2M8nbSGdTJSlrw9wO7H7Kt+g3ebVYzqrUSzPCXGX+TQS1M dZYwbjAIGZiruXUHHH8X2YrP67tdmsf2WtVMxbsM4436JKyLjgbA/c8p5uLSpMyxr27wiWht0/y 6WlJ2mGMGZ1rUVdCQxr/sIpQj4Li8VDwTJEcFlx2wXBRAvbHA X-Received: by 2002:a05:600c:8515:b0:428:387:79ac with SMTP id 5b1f17b1804b1-4290d7d74e8mr11427515e9.6.1723141600833; Thu, 08 Aug 2024 11:26:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHP73emNCQDdWv2KlFW9rCMi1DOUNBEBL6z1+LJwr/UDfUfIx6wmqyICQgAwvUcoNjIIDsz1w== X-Received: by 2002:a05:600c:8515:b0:428:387:79ac with SMTP id 5b1f17b1804b1-4290d7d74e8mr11427405e9.6.1723141600302; Thu, 08 Aug 2024 11:26:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:2a00:f151:50f1:7164:32e6? (p200300cbc7132a00f15150f1716432e6.dip0.t-ipconnect.de. [2003:cb:c713:2a00:f151:50f1:7164:32e6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429c19a1fe4sm82155e9.0.2024.08.08.11.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 11:26:39 -0700 (PDT) Message-ID: <490ae360-50a4-497f-b148-ef077b73e911@redhat.com> Date: Thu, 8 Aug 2024 20:26:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm: don't account memmap per-node To: Pasha Tatashin , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, yosryahmed@google.com References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-5-pasha.tatashin@soleen.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240808154237.220029-5-pasha.tatashin@soleen.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 209B1A001A X-Stat-Signature: hpgq8r6w4mzyaouwg7ympfhpe1t5ju8c X-Rspam-User: X-HE-Tag: 1723141603-818530 X-HE-Meta: U2FsdGVkX19c9WsGon7LZiktZ/wh4BPBAQx+6EEd6wrHHXufPCAq9VoRHTZd4A4zdwdMMyb/KWU1EhNoEGBv39jZmMrKKPQO5mI/B7FSCGbhSR99+PVXd/Ze/em6zVbrp3S6Fesyj0R+h4HfiRnZQchNfL7aXE1Ch+i42enfonJ88M0g47W3u8j5k7SprEkcoEICqqc6+pRJHyBcmUe5gpaASltp23wahY6xSAPw2dymJ6T9iWj/+1TqSirhslMmfxyG9VrW/Pnl7QYgEKpU5PJxxlfCBy8UyXoTpRuipkcNEqToM34tlhki3D/H/cWzwXfuEjwEJY4rX9QMZkTVuzOUE5xzVO+8O8Y3a1lJhhjymt9m37l6QPU04qyN1TUMI5FrWdzt4hmRceVDN3xy7Vm73TSHYn5GZxw6RzHGXy0imbMjPW67cM1nqQYkex95oECyjtrVjfCsznopfWV1nvWyNw4GQ+nDB8/JjLKiBXv1M3lEcA5LI+xLkgZLYalSgKckCG+cFCkai/wSO3YnxhPuRNHMtl7ON5unL70iUSOK7Spq5/LEGuD8czST9zOAgJnDKyO1Ra7yS/6Nl764iXuU16VsozUFqwXkfHj33TojgvlHZPy6BDUsnBR6h1KTlge/dGJtUwi/d9LDUm5GcSSLeSm51OJI/SiytRiB/ISNaRT2si42NYg7yKx5L9qgRDdoWUHE9kadXJqAPz7/fJnfjtQ6anQoaw7uEBrJYhhcFgCc3pGZxSHy3UH6Xbn1zC8i24YZ3E2u4zx9/XAmBDdbRshfoaFitbiHCBX6edYC2oWcTPuUAzRBkXIWNDrNtkZ4D5k07+eq7++fv4i8rsjOTb0BCTJ+fJjcgVj9lIpq+uQBbzcDQV8nR4OwtFgmdpdXz9y26FyjEAwiEswSWQ12FpAHMoXjhOWBWpORdHVo74FE+cEzsB7sQF6WF19iewx29hH4Dd4vvQglala KgQdqcsT jMKEj5r0uFqfNMvD3A49X5vUfc/6Eea7VlE8DWko1JPd2Dih3xwQ2HZjzrzAbNweuuNHWfZPehAvaZ7ulaUmj5U+zqYpYEDw6caGAxIk9ekmJT+4grTF8McPuw0oujCF0/Wk7wGb5Q9Rwm2olRDGucyUVd7UbRyRDMva9c43rvCd7eZXCXrQWvxX1PFg8J6exYqkHMeew0/2pq4qpog5d7lFQ4ySZLAqeIa5FBiLlT3IqLIqFm3XHPZLqgw/nPvZllQGBLquWoaUhkDs+Am+zBEQkHMrTB2pv714MBUzEL/kPBjMWvTRKKB1DO8dQNb1hNhd3CzKUDjPpNlLvIh6TVEbidCtS7yLIO9CLfLAyDukcB9FgVP+xc1SQdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > #ifdef CONFIG_COMPACTION > > struct contig_page_info { > @@ -1255,11 +1272,11 @@ const char * const vmstat_text[] = { > "pgdemote_kswapd", > "pgdemote_direct", > "pgdemote_khugepaged", > - "nr_memmap", > - "nr_memmap_boot", > /* system-wide enum vm_stat_item counters */ > "nr_dirty_threshold", > "nr_dirty_background_threshold", > + "nr_memmap", > + "nr_memmap_boot", While we're at it (sorry, I should have found more time revieweing this earlier!) ... What is the unit here? Should this be "nr_memmap_pages" / "nr_memmap_boot_pages"? Like $ cat /proc/vmstat | grep pages nr_free_pages 3618323 nr_zspages 3 nr_anon_pages 1053316 nr_file_pages 3199210 nr_shmem_hugepages 546 nr_file_hugepages 0 nr_anon_transparent_hugepages 0 nr_page_table_pages 15215 nr_sec_page_table_pages 0 numa_pages_migrated 0 Nothing else jumped at me. -- Cheers, David / dhildenb