From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.18.234]) by e23smtp04.au.ibm.com (8.13.1/8.13.1) with ESMTP id mA2FpQ2N012460 for ; Mon, 3 Nov 2008 02:51:26 +1100 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mA2FqlRP3309592 for ; Mon, 3 Nov 2008 02:52:49 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mA2FqjLZ012842 for ; Mon, 3 Nov 2008 02:52:46 +1100 Message-ID: <490DCCC9.5000508@linux.vnet.ibm.com> Date: Sun, 02 Nov 2008 21:22:41 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com MIME-Version: 1.0 Subject: Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector References: <20081101184812.2575.68112.sendpatchset@balbir-laptop> <20081101184902.2575.11443.sendpatchset@balbir-laptop> <20081102143817.99edca6d.kamezawa.hiroyu@jp.fujitsu.com> <490D42C7.4000301@linux.vnet.ibm.com> <20081102152412.2af29a1b.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20081102152412.2af29a1b.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: linux-mm@kvack.org, YAMAMOTO Takashi , Paul Menage , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, Nick Piggin , David Rientjes , Pavel Emelianov , Dhaval Giani , Andrew Morton List-ID: KAMEZAWA Hiroyuki wrote: > On Sun, 02 Nov 2008 11:33:51 +0530 > Balbir Singh wrote: > >> KAMEZAWA Hiroyuki wrote: >>> On Sun, 02 Nov 2008 00:19:02 +0530 >>> Balbir Singh wrote: >>> >>>> Don't enable multiple hierarchy support by default. This patch introduces >>>> a features element that can be set to enable the nested depth hierarchy >>>> feature. This feature can only be enabled when there is just one cgroup >>>> (the root cgroup). >>>> >>> Why the flag is for the whole system ? >>> flag-per-subtree is of no use ? >> Flag per subtree might not be useful, since we charge all the way up to root, > Ah, what I said is "How about enabling/disabling hierarhcy support per subtree ?" > Sorry for bad text. > > like this. > - you can set hierarchy mode of a cgroup turned on/off when... > * you don't have any tasks under it && it doesn't have any child cgroup. That should not be hard, but having it per-subtree sounds a little complex in terms of exploiting from the end-user perspective and from symmetry perspective (the CPU cgroup controller provides hierarchy control for the full hierarchy). -- Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org