From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2AFC38142 for ; Tue, 24 Jan 2023 14:54:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF92C6B0071; Tue, 24 Jan 2023 09:54:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAA3F6B0072; Tue, 24 Jan 2023 09:54:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4AB46B0075; Tue, 24 Jan 2023 09:54:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C352B6B0071 for ; Tue, 24 Jan 2023 09:54:01 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A05ED120AF1 for ; Tue, 24 Jan 2023 14:54:01 +0000 (UTC) X-FDA: 80389987482.30.8AB51D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 6850E10000D for ; Tue, 24 Jan 2023 14:53:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M1FxX9kO; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674572039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r1o51OJziP6bU+eCmiPMiOHJQX1d0z5FefyRCAiwMaA=; b=xbZFaMjiU1SM+5RvBunEOiuI0Rd/5fHP+8qQDgfwnB8IDrvcNY3ShhRh57A1LUQv++FFDJ sllUKCX12WOcHgZ8qg4hefJi4JaonqTxqYNOijqQyXl+McjXV/moHoQJWGu/oR5DbpZFKT rDjg2IJ4ErczB1jI9TF2c/SAdJL87cM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M1FxX9kO; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674572039; a=rsa-sha256; cv=none; b=HYo9jXN8xCsvH32WTzttujtCxoAC4una5fdcw+A4bgufkVimkuRxReIWIrpRM0Ycy3KX5U pNauJ+mG1Y6vdm2hV+6VfKZaXGDMocO6NEu2hB7Ofl8qMMnXCcgkOmBS1Y8Rba23QQzE1H y+scd7tDHRLUAlUomYwu+CxQI7DUpvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674572038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r1o51OJziP6bU+eCmiPMiOHJQX1d0z5FefyRCAiwMaA=; b=M1FxX9kOQWCxHQ55KpJu7YRX5l4VPjQ0tz3E0UoN18gAGqhrGVgzU6uwBcHBwEw3kM3u6r zKFQnEQYsfQZCQXuv84g7jnp3gqR//SNnIoUlZbEn2tO7CqmTOkUyuEDZ0+YwKWcrHm8LM DBtNJdktlrlnEiZuJ+90rmNKNLb/E2Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-59-puVdDkkDM5SOxDzrlneRkg-1; Tue, 24 Jan 2023 09:53:57 -0500 X-MC-Unique: puVdDkkDM5SOxDzrlneRkg-1 Received: by mail-wr1-f70.google.com with SMTP id v3-20020adfa1c3000000b002bdd6ce1358so2690961wrv.23 for ; Tue, 24 Jan 2023 06:53:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r1o51OJziP6bU+eCmiPMiOHJQX1d0z5FefyRCAiwMaA=; b=W9r8U9op77SsZ2FzyaETSBuU8Mc1V/+o0WSXdCOFtHbsRFaAXPikPq14HxH8WD1Jwv ZP7+W5JwxS7md+15xo1kAs18tSZSyhV7xwnIi7fhjCZRDSGzla0HWz5zt+df9hW4JPvu 5+GyO4gF2vXo9Q/eT4mh59c2SANztcsWID+Y30MPU4IN0PAAUXgl9pZ1U93QPyCATD0z dGmQMuhJJweh7ENhYLGAUTpep8nSNxfYXV+AgxYEh3uPJc8Q+pD05ZlBiJNoZgyXXojm ejPY2/6w4oGgljUuphI1ZKRAn7WwhcozDWWl/mPuvYIVAScXfSN0oT0p3Xd143htbZpZ l/pw== X-Gm-Message-State: AFqh2kqmbXWR8D5A++n4kA9xHUH5fZkEwR9hgattycWmnIkvVFzI/q0L iTn6FHHk7EeR7g9+pFZvAwZGX3WfEwIpgW9jBrmIu+BZQ33skjFABbvCf2QcwACJoUCv+2MstNq xoyvyZ+/SSnM= X-Received: by 2002:a05:600c:4f10:b0:3d3:48f4:7a69 with SMTP id l16-20020a05600c4f1000b003d348f47a69mr29345040wmq.17.1674572036376; Tue, 24 Jan 2023 06:53:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXsWKnb4h2V9IrDZPNQLJb9xuVNOAv4tgAP04/SXdS4jirwC5GnrgtxAI7Zz/EbUkNYX+dYayA== X-Received: by 2002:a05:600c:4f10:b0:3d3:48f4:7a69 with SMTP id l16-20020a05600c4f1000b003d348f47a69mr29345019wmq.17.1674572036027; Tue, 24 Jan 2023 06:53:56 -0800 (PST) Received: from ?IPV6:2003:cb:c707:9d00:9303:90ce:6dcb:2bc9? (p200300cbc7079d00930390ce6dcb2bc9.dip0.t-ipconnect.de. [2003:cb:c707:9d00:9303:90ce:6dcb:2bc9]) by smtp.gmail.com with ESMTPSA id k37-20020a05600c082500b003daf681d05dsm2160914wmp.26.2023.01.24.06.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 06:53:55 -0800 (PST) Message-ID: <4909601d-8b3b-6ec2-b8b5-2764772d6e8d@redhat.com> Date: Tue, 24 Jan 2023 15:53:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8 03/10] mm: Provide a helper to drop a pin/ref on a page To: Christoph Hellwig , David Howells Cc: Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-4-dhowells@redhat.com> <874546.1674571293@warthog.procyon.org.uk> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6850E10000D X-Stat-Signature: uwpf4keq54ya1yzb3mafgt7e6u7spdt8 X-HE-Tag: 1674572039-875602 X-HE-Meta: U2FsdGVkX19dSbIBxbbCWR32tTZeF2wkhS5KBh7/MgsgYTBQqfzdWAK2+BZNxyxkK8hksvt1d3gcZKvp7+ie//4HNeXgAXRFJ06MtFaXUaLcn0iS44mwq1qJbq49B3dwk6jO0XkUQkB0c/9nizpWiKO3IuqUdy04/JscZUgpl+kJGQfkqlPz1dkaNTYHGrL+/cYLWe5VHntdwKE5fOncCKvBYgQ9i2BOfXNFOTu9EonM9jL0E2tB7hX49zt3cU0G5EAu3neMmCtF2S15uphXos0WzuUOLxhgqYjnKIy50uRupBoPO32ysDEYjvZp8h11umwFPU1IS+Uj1F3D2F4g+3aJTG8yV/LlBZJ3sUiYShI5JM8qXvcg/kvyI1Mn+cKwQJJPYFPv5RbZ7rnW5dc+fYsreJEqSbjylYG7lba04qJemsJkxDVCpm0mjlV4EFGL1tjoT/M1NBAG/baRmEqiy3+oUm6N6eQL01m6MoFvivIDmOlzQolGrTZHpOtZjVbi6BsfOrFqTgOCV1HaeW2IXQcDRRex3pCwYOy4pHcXfOQhmHwl+W3IeL0+Cr0CD13hrwRSc0ivHMQpYxeuCRvU4EwEZzlAbBwHvtrQkPGvEK43gg0LluANtqbXlvwcEmUMzYA4DqB21J34skHiQREt4Su2fmhHxkQhmQchoerY9NmXPicNunQbaHZKh0r3apiRIN7u67Fjwn5lEdMb6qgJXBNSoTP17gs6sin7Loo5j0iBSxMAD7fnLhc6GLN9iZCwFjX/Dd1sZ2d0RI14v2VFZdk1ZPyBpBKKpYgNmSy/egpVVrsLqoafm/hZh9NjQ+/Mic0YxttQA56kbr7CqvNZdVDl6W5i7ouHn8EYXgKAkfQgByHYzr5KJEIEFeq5dPzxU1iXqo15kBG6+ho/Jf0+5ftNtYCXENpCPSxMIwpSsrRVw1mf/46yfRrB9l7AnvSvvBVSEfSmJDN/17xyVLx dQ5wEu/w 9ACltmFh1isgHB/6DsmWxi2OSZFxp+KAMRImcKgxM4s9JLVVpIM5l3IWino9P3aevNeWIGm0gheBSWpgTXWtdPDd7A2txYiKOMeFEJBfQcDaSwLqk3/V09pa7y5RKpC42jAhMi7RVq+DzFzkJsVTDUYgtK7QxM1j1SbeGw58gA7ZEjVQIhrhABwTdmVOux8ynC6hmAnuV+D4C7mOL8JiVe8qMdrojLSITAclPuRyXKJdSRmaSTLPwteLUChfPBsDahIlLt0MNfdaDr+lVyC5aK9ZJoDNb0z42nkKG2AnjgOfw4/YPkZJMR/Y3tGIv2AAWrQZmuQBGGtLE8SknnBNIymWoWNwpKeqZInOKvTOMVLkoSO0AtnQ0++OrET0D3QyZ6l9PR9wcxlClGluje6H8riPv8Zhljr6tDGcmeX7ja0sKQ0+m29piM9vHvVOtKZ6zsu+NnviK+yug/w25AJEji06G7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000105, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 15:52, Christoph Hellwig wrote: > On Tue, Jan 24, 2023 at 02:41:33PM +0000, David Howells wrote: >> Yes. Christoph insisted that the bio conversion patch be split up. That >> means there's an interval where you can get FOLL_GET from that. > > The only place where we have both is in the block layer. It never gets > set by bio_set_cleanup_mode. > > Instead we can just keep using put_page dirctly for the BIO_PAGE_REFFED > case in the callers of bio_release_page and in bio_release_pages itself, > and then do away with bio_to_gup_flags and bio_release_page entirely. > Thank you, just what I had in mind ... -- Thanks, David / dhildenb