From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D466DC3DA64 for ; Wed, 31 Jul 2024 14:43:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A7986B0082; Wed, 31 Jul 2024 10:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358096B0083; Wed, 31 Jul 2024 10:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D1A06B0085; Wed, 31 Jul 2024 10:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F29716B0082 for ; Wed, 31 Jul 2024 10:43:43 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9B911A034F for ; Wed, 31 Jul 2024 14:43:43 +0000 (UTC) X-FDA: 82400316726.26.F1682DA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 307EF40016 for ; Wed, 31 Jul 2024 14:43:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wPO0KTMe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8NUhvU3+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wPO0KTMe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8NUhvU3+; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722436947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ErZYWH0yCVNDemD+p8E2JlYmFEAzXVk4NkZZnwYipV8=; b=R6ZZdScpwjB/CjukSExonG9TcqQmE4cJrkWEMwTkCXsYGxkDkE/KP6ZYxX1kqcogGrH+RF 8g4BtEqJJEvCA/ffkEIMmeMGV83dg8CaUbUOUpFAWn3/hS7UTuT03HL0BnGjHm6nSnMv1z s4isgMprxd3mBjjh3eMdghU7+fA+7do= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wPO0KTMe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8NUhvU3+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wPO0KTMe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8NUhvU3+; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722436947; a=rsa-sha256; cv=none; b=YBMcDZYIXB9tN9Xn7rKBYOCFDZu1Ga0a9GpTph1sOj/f07iwEYTD1cLIgtmJRf9bji0zLd rZWW4Wax61h2qcoaItr3N3k+dJlAonbaLUakeOSBt27gUw31uYqy6JNnBASxuZbUZqB9SN NnXWZ5hlHmRsjHqsSaVnjjK5jpRxTfM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 83ACE21A7B; Wed, 31 Jul 2024 14:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722437019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ErZYWH0yCVNDemD+p8E2JlYmFEAzXVk4NkZZnwYipV8=; b=wPO0KTMeLxsLTMKHxSxvuL7yB53HRVZ/ePvvK1hnRaQ0VD/NTQfiitvP64+M5v05LX5B/H r5vyvaamneCQnpuC+gxzfQwBHlMxz7+StYcDDC4k+6nlOBOv6reYbzi+pSe1GDb4uMckZE 40RZLvs0Fr9y9hBrmkXkKxOm19cr6Hs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722437019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ErZYWH0yCVNDemD+p8E2JlYmFEAzXVk4NkZZnwYipV8=; b=8NUhvU3+sLh6ljtIPVkix+w+fzvDC9w/Iya2hRaguhTz6AJZcBJS52Uayh5eRWpyK8DRcM sIQ7bOUsN2+lZdCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722437019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ErZYWH0yCVNDemD+p8E2JlYmFEAzXVk4NkZZnwYipV8=; b=wPO0KTMeLxsLTMKHxSxvuL7yB53HRVZ/ePvvK1hnRaQ0VD/NTQfiitvP64+M5v05LX5B/H r5vyvaamneCQnpuC+gxzfQwBHlMxz7+StYcDDC4k+6nlOBOv6reYbzi+pSe1GDb4uMckZE 40RZLvs0Fr9y9hBrmkXkKxOm19cr6Hs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722437019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ErZYWH0yCVNDemD+p8E2JlYmFEAzXVk4NkZZnwYipV8=; b=8NUhvU3+sLh6ljtIPVkix+w+fzvDC9w/Iya2hRaguhTz6AJZcBJS52Uayh5eRWpyK8DRcM sIQ7bOUsN2+lZdCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6C6C213297; Wed, 31 Jul 2024 14:43:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZLPSGZtNqmbUeAAAD6G6ig (envelope-from ); Wed, 31 Jul 2024 14:43:39 +0000 Message-ID: <4908d9a3-8b04-4808-8190-c1b602cba9dd@suse.cz> Date: Wed, 31 Jul 2024 16:43:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: vrealloc: properly document __GFP_ZERO behavior Content-Language: en-US To: Danilo Krummrich , Andrew Morton Cc: urezki@gmail.com, hch@infradead.org, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240730185049.6244-1-dakr@kernel.org> <20240730185049.6244-4-dakr@kernel.org> <20240730141953.a30fa50c0ba060fe0a765730@linux-foundation.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 307EF40016 X-Stat-Signature: uhn6hry9fuwynkfpsum9xnf9acyg5qwu X-Rspam-User: X-HE-Tag: 1722437020-305855 X-HE-Meta: U2FsdGVkX19MRDfhGCLJ8I4qMBmkR+rdVcr8GjLMP8PCwDvRS0efZ1hwm08P1VLUMhaCiKOPtHnxJoBVL9HXhsj5NCoU6O5roDw4gR4FZMWY0wMmehY1I0w24rEM7sUxnOZSNBYN0jbaCb+mtqz62kHWmGm4jY00CD5HYF0XA9KMLCKLTmyu5vcDL/ueWcOAsDmqro9OHpqQ4oJ8xyi8fqTnRNDgQvQmeyw5M2CLoqpyQ07nU3FU34NlykzXjhn7qjsZZ8vwPqilt/T+l0RGkGG4YhQFXFHFA+PKhlvR8eRrhbtzW2WAGz7O2pRd13lh+wqDq730wXOCEa+MZhOrYbOy0vj8JAYjULX9xyvv83fR9zQZ57/DSX800gY5dhf4hQUgE4Qi5oZl8NtoTrjo9x+HNTzWhr1TpR4gZwIE55Say56lFnfWyOwD0Lud8nezRwAwNXovD+52mbS4KFzLCMhVf94Xi+9T2qNLWj87MqRRZExyfBIqTXdCnWVGubi6C2OTdDVMosza28Q375NjYFfp5f7uYMOMv6mZJOzrEfN7QdZc/qoibg0NxPoKgVY6DMKRqtQU/nZkEUko3hh+qHz8xQIStsY6AdyT0KuBZ9F4lxgCQW1yMW+OBfYuzkM7c8m7KX6OMpAgXh4k8puIonKT7PxFBQeKZ474PSbUBoOE2WqTLF+Nhkg+/TS0n/7mMxRWYBWQ6TAxJPQfGXRiCRS9IG4EzrJrTqHrjzl+T2PH4EaI6cHBI8KckbL4EzzsenXSXotM0WPkCNsOmsbpQ7WHwo8Dj0+WFrcwPIPp+QKRzfOup/77kX8dxXjqd7I7ZxH/TXpPwTr9yC9LEOCm7Nc2pAjislPNffAB/RPn4sCg9VFR3kwk8BvQh4bavWsUQ9hlL+xX+vM0pyS5fCR1GHOeYQ8lIj2dtJfO17oKHjnBgVubs2dlxagZnKBnjh+Q0LzD1C33XsxpULZ1sv/ 8GkFUNp4 +gGD5PRSW49gli2lcvRPj905aC51W5a5/WiDJq+u+DS75e+o3tFYVJ46EG08I+H+9O3cg1Usz6tRv4yjr/cfOmJemQijeQwOsRcotIec97p2iBJVAFFfsJisNM7Uss3rvUJWuhURAK1dYsQbVJPvd5QDEGKs0+EPd85jscYoDEZt5TkMYkC1atMcofJbfg13w5Yi8iu5BBwGWPo7jTfmAayHJdY8HSDWDaqYKjVH/obD3tvUrWoonEXmngJ75keqZm0PQD+BIclo41lvXmFm2tCkyrC9UglFImO3mVSvcWIt7kWIaE9Zw9W1/uHI9LLXZMChqoXGr5dnGTT2iaLPEqucF5bqMZ/IMIqKt5cnt+Ur+NNzmLQHcYSsXtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000906, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/31/24 12:43 AM, Danilo Krummrich wrote: > On Tue, Jul 30, 2024 at 02:19:53PM -0700, Andrew Morton wrote: >> On Tue, 30 Jul 2024 20:49:43 +0200 Danilo Krummrich wrote: >> >> > Properly document that if __GFP_ZERO logic is requested, callers must >> > ensure that, starting with the initial memory allocation, every >> > subsequent call to this API for the same memory allocation is flagged >> > with __GFP_ZERO. Otherwise, it is possible that __GFP_ZERO is not fully >> > honored by this API. >> >> I appear to have just seen this, in a separate mailing. > > What you have seen in a separate mail is a similar patch for krealloc() [1]. > This one is a fixup for vrealloc() from a previous submission you've applied to > mm-unstable. > >> >> Please, slow down. We have two months. Await reviewer feedback, spend >> time over those changelogs, value clarity and accuracy and completeness >> over hastiness. The only reason for rushing things is if a patch is >> disrupting ongoing testing of the linux-next tree. > > There was a discussion in [2], which lead to this fixup series. > > In terms of changelogs this series is indeed a bit "lax", since I have > recognized that you queue up fixup patches for changes that did already land in > mm-unstable to be squashed into the original commits later on. Some of the changes in the fixups would however ideally result in udpdates to the original changelogs in addition to squashing code. Also with 4 fixups to 2 original patches it might be IMHO better to squash on your side and resend as a full replacement. Perhaps also together with the other 2 patches about __GFP_ZERO for krealloc in a single series. As Andrew mentioned we are early in the rc phase to afford this. > [1] https://lore.kernel.org/linux-mm/20240730194214.31483-1-dakr@kernel.org/ > [2] https://lore.kernel.org/linux-mm/20240722163111.4766-1-dakr@kernel.org/T/#m065a7f875b44dc945dd535c2b7168c3d77a98993